[PATCH] genini: support new tags

[PATCH] genini: support new tags

[Yaakov (Cygwin/X)]

[-- Attachment #1: Type: text/plain, Size: 101 bytes --]

The attached patch for genini allows it to recognize (and ignore) the 
new setup.hint tags.


Yaakov

[-- Attachment #2: genini-new-tags.patch --]
[-- Type: text/x-patch, Size: 622 bytes --]

2013-10-07  Yaakov Selkowitz  <yselkowitz@...>

	* genini (parse): Ignore arch:, release:, and skip: tags.

Index: genini
===================================================================
RCS file: /cvs/cygwin-apps/genini/genini,v
retrieving revision 1.14
diff -u -p -r1.14 genini
--- genini	17 Jul 2013 16:33:16 -0000	1.14
+++ genini	7 Oct 2013 19:24:32 -0000
@@ -139,6 +139,15 @@ sub parse {
 	    $main::setup_version = $_;
 	    next;
 	};
+	/^arch:/ and do {
+	    next;
+	};
+	/^release:/ and do {
+	    next;
+	};
+	/^skip:/ and do {
+	    next;
+	};
 	/^\@\s+(\S+)/ and do {
 	    $pname = $1;
 	    $what = '';

Re: [PATCH] genini: support new tags

[Christopher Faylor]

On Mon, Oct 07, 2013 at 02:28:00PM -0500, Yaakov (Cygwin/X) wrote:
>The attached patch for genini allows it to recognize (and ignore) the 
>new setup.hint tags.

Only skip: is a valid setup.hint tag.

cgf

Re: [PATCH] genini: support new tags

[Yaakov (Cygwin/X)]

On 2013-10-07 14:46, Christopher Faylor wrote:
> On Mon, Oct 07, 2013 at 02:28:00PM -0500, Yaakov (Cygwin/X) wrote:
>> The attached patch for genini allows it to recognize (and ignore) the
>> new setup.hint tags.
>
> Only skip: is a valid setup.hint tag.

OK, bad wording, but genini accepts an existing setup.ini as input, so 
it needs to understands its tags as well.


Yaakov

Re: [PATCH] genini: support new tags

[Christopher Faylor]

On Mon, Oct 07, 2013 at 02:59:28PM -0500, Yaakov (Cygwin/X) wrote:
>On 2013-10-07 14:46, Christopher Faylor wrote:
>> On Mon, Oct 07, 2013 at 02:28:00PM -0500, Yaakov (Cygwin/X) wrote:
>>> The attached patch for genini allows it to recognize (and ignore) the
>>> new setup.hint tags.
>>
>> Only skip: is a valid setup.hint tag.
>
>OK, bad wording, but genini accepts an existing setup.ini as input, so 
>it needs to understands its tags as well.

Ok.  I guess genini is more forgiving about accepting setup.ini keywords.

FWIW, I will probably be removing parsing of setup.ini from upset at some
point.  upset no longer reads setup.ini when generating a new setup.ini.

Go ahead and check in.  Thanks for the patch.

cgf

Re: [PATCH] genini: support new tags

[Christopher Faylor]

On Mon, Oct 07, 2013 at 04:04:10PM -0400, Christopher Faylor wrote:
>On Mon, Oct 07, 2013 at 02:59:28PM -0500, Yaakov (Cygwin/X) wrote:
>>On 2013-10-07 14:46, Christopher Faylor wrote:
>>> On Mon, Oct 07, 2013 at 02:28:00PM -0500, Yaakov (Cygwin/X) wrote:
>>>> The attached patch for genini allows it to recognize (and ignore) the
>>>> new setup.hint tags.
>>>
>>> Only skip: is a valid setup.hint tag.
>>
>>OK, bad wording, but genini accepts an existing setup.ini as input, so 
>>it needs to understands its tags as well.
>
>Ok.  I guess genini is more forgiving about accepting setup.ini keywords.
>
>FWIW, I will probably be removing parsing of setup.ini from upset at some
>point.  upset no longer reads setup.ini when generating a new setup.ini.

Actually, this is nonsense.  I forgot that I still have to parse setup.ini
for some stuff.

cgf