From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 390 invoked by alias); 17 Oct 2013 09:38:20 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 376 invoked by uid 89); 17 Oct 2013 09:38:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: calimero.vinschen.de Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Oct 2013 09:38:19 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 7089252021B; Thu, 17 Oct 2013 11:38:17 +0200 (CEST) Date: Thu, 17 Oct 2013 09:38:00 -0000 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: [RFC] cygport: use -Werror=implicit-function-declarations Message-ID: <20131017093817.GA25168@calimero.vinschen.de> Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <525F247D.3010408@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH" Content-Disposition: inline In-Reply-To: <525F247D.3010408@users.sourceforge.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-10/txt/msg00149.txt.bz2 --ReaqsoxgOBHFXBhH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1419 On Oct 16 18:42, Yaakov (Cygwin/X) wrote: > One of the more common causes of SEGVs with x86_64-cygwin packages > occurs when an implicit function declaration causes an assumption > that all arguments and the return value are of type 'int' (32 bits) > where some or all of these are longs or pointers (64 bits on > x86_64). One way of avoiding such errors is to add > -Werror=3Dimplicit-function-declarations to the default > CFLAGS/OBJCFLAGS, and in my brief testing to date, this has already > caught a number of cases where this would have broken the package on > x86_64. >=20 > One potential drawback is that this flag may cause false negatives > in poorly written configure tests; without extensive testing, I > can't say yet how prevalent this would be, but I think that making > this an error and perusing config.log is generally easier than > making it just a warning and having to sift through the entire > output of make. Uh... I'm not so sure about that. I would rather see the configure tests running through, but like the idea to have -Werror=3Dimplicit-function-declaration set for the actual make stage. It's more important that configure tests run to check for existence of stuff, and not being able to configure is a really annoying problem. Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --ReaqsoxgOBHFXBhH Content-Type: application/pgp-signature Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIcBAEBAgAGBQJSX7AJAAoJEPU2Bp2uRE+gK+kP/1AIKKt7VCS8y/3cyLCS3Hu0 vnyeGd2PPg87Ui2tTx4wpewRHS+PUEo4KRuhLxHuwQ8HN6/4DZxGAC2y0DSNzNge 5UfjsYou85nqRLSVPc3VtzdoGBlopRtoKZeK/eWeYivZt0OT739duVGCzT46E/hy no1SebZMqmdW2yjRhYAxJJbIfLIckGhWI6Of7q/MxN6eQgoasao/jBF9hjP+bmul mXggMZ0O2dx1/bO9sdzEmrgldbs5cDlkxCAD4EKbmdhryNj9SWkbuteOG1qce/W5 kf5j7PQxkWs2EGIol4x8sB709DDQ79wCz1WC0m0TNJ3UjtBqZrEDutb/rgaaIQqn JHv5mwgmemiTzHNAW/Ph7/N8ZzNXE4A1a1tdolaBuY2pGyRk+cZn4ZHnAei74x6O yFCZ4uRm2YNkQ91xbrQZ7Yyv8xySXXq1K9pJWnCGh2Kuabrg+tdh4KErI//Tg6KM B2KnNzq4xPEMC0jRU0FK0Zv8l6BUDv4/mP5r6BLYRdDQ0N164JLHZp6Zs1NHarKl 5TqDioPlUkj6atcVvaERy9/2rezorxjU4MEn5P5eomdiI4XojLOeyC/k50nGSXqE qL0UODfiP0AdVLRNpLaaULmwr033Qj81EjYno77q40P/qZ+1ySmDX7YgEnIPJniX ExHXQGEcb02+swFHfEdC =0V+1 -----END PGP SIGNATURE----- --ReaqsoxgOBHFXBhH--