Re: [ITA] base-files

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

[-- Attachment #1: Type: text/plain, Size: 2393 bytes --]

Hi Achim,

On Mar 15 18:45, Achim Gratz wrote:
> 
> Since the current maintainer David Le Sastre Medina seems to have gone
> missing, here's my attempt to wrap up the changes that were implemented
> after the 4.1-2 package was published as experimental (and then never
> released).  The pertinent discussions on the Cygwin ML are listed in the
> ChangeLog.
> 
> Change Log
> ----------
> 4.1-3
>     * Eliminate Windows PATH from default PATH if CYGWIN_NOWINPATH is
>       set.  Record the Windows PATH in ORIGINAL_PATH unless that
>       variable is already set.
>     * Better guard for non-existent /etc/skel.
>     * Improve profile_d function.
>       cygwin.com/ml/cygwin/2012-08/msg00488.html
>     * Add /etc/shells.
>       cygwin.com/ml/cygwin/2014-03/msg00039.html
>     * Use full path for tools and avoid DOS file warning when creating
>       service files.
>       cygwin.com/ml/cygwin/2013-07/msg00114.html
> 
> 
> Git repository (originally cloned from GitHub):
> http://repo.or.cz/w/cygwin-base-files.git
> 
> 
> Test package:
> --8<---------------cut here---------------start------------->8---
> wget="wget -rxnH --cut-dirs=2 http://cygwin.stromeko.net/noarch/release"
> ${wget}/base-files/base-files/base-files-4.1-3.tar.xz
          ^^^^^^^^^^^^^^^^^^^^^
      There's one "base-files" too much.

A few (rather minor) notes:

- I think you should bump the version number.  4.2 or whatever.

- In etc/postinstall/base-files-mketc.sh:

    /usr/bin/chmod 1777 /tmp 2>/dev/null

  This looks gratuitious.  Setup itself already sets /tmp to 1777.
  I never heard of somebody changing the permission of /tmp to
  something else, so it probably doesn't hurt...

- In etc/defaults/etc/profile:

  Just a heads-up.  Be prepared to remove the entire section about
  mkpasswd/mkgroup checking.  It won't work as expected anymore as soon
  as my AD integration code goes release.  Along these lines, I will
  update the base-cygwin package not to create passwd and group files
  anymore.

- Do we still need etc/defaults/etc/profile.d/1777fix.sh?  How long has
  it been?

Other than that, it looks good to me.  I'd say, let's go for it when
you're ready.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]