From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5358 invoked by alias); 22 Apr 2014 14:47:51 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 5345 invoked by uid 89); 22 Apr 2014 14:47:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: mho-02-ewr.mailhop.org Received: from mho-02-ewr.mailhop.org (HELO mho-02-ewr.mailhop.org) (204.13.248.72) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 22 Apr 2014 14:47:49 +0000 Received: from pool-173-76-43-57.bstnma.fios.verizon.net ([173.76.43.57] helo=cgf.cx) by mho-02-ewr.mailhop.org with esmtpa (Exim 4.72) (envelope-from ) id 1Wcbz8-0004TM-Mf for cygwin-apps@cygwin.com; Tue, 22 Apr 2014 14:47:46 +0000 Received: from ednor (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with SMTP id CD12C600D0 for ; Tue, 22 Apr 2014 10:47:44 -0400 (EDT) Received: by ednor (sSMTP sendmail emulation); Tue, 22 Apr 2014 10:47:44 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18IXocylVaSWB1IZJDi/91V Date: Tue, 22 Apr 2014 14:47:00 -0000 From: Christopher Faylor To: cygwin-apps@cygwin.com Subject: Re: [PATCH setup 3/3] Add the last element of URL path to site chooser, if interesting. Message-ID: <20140422144744.GA7528@ednor.casa.cgf.cx> Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <1398078987-5116-1-git-send-email-jon.turney@dronecode.org.uk> <1398078987-5116-4-git-send-email-jon.turney@dronecode.org.uk> <20140421141028.GD661@ednor.casa.cgf.cx> <53555F7C.7070708@dronecode.org.uk> <20140422075315.GB5959@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140422075315.GB5959@calimero.vinschen.de> User-Agent: Mutt/1.5.20 (2009-06-14) X-SW-Source: 2014-04/txt/msg00062.txt.bz2 On Tue, Apr 22, 2014 at 09:53:15AM +0200, Corinna Vinschen wrote: >On Apr 21 19:12, Jon TURNEY wrote: >> On 21/04/2014 15:10, Christopher Faylor wrote: >> > On Mon, Apr 21, 2014 at 12:16:27PM +0100, Jon TURNEY wrote: >> >> If I add the site http://mirrors.kernel.org/sources.redhat.com/cygwinports/ to >> >> setup's mirror list, using the GUI or --site option, I get two indistinguishable >> >> entries named http://mirrors.kernel.org in the mirror list box. >> >> >> >> So, to make the site chooser list entries more distinguishable, add the last >> >> element of the URL path to the site chooser, if it exists and isn't 'cygwin' (or >> >> some other alternatives used by current mirrors) >> >> >> >> As Corinna pointed out in Nov 2010, there is still a corner case of URLs which >> >> share protocol, hostname and the last element of the URL path being >> >> indistinguishable. Additionally, it will need updating for any new mirrors which >> >> don't use one of the expected strings for the last path element in the URL. >> > >> > I'd actually be ok with just displaying the whole URL even if it ends with Cygwin. >> > Is there a reason not to do that? >> >> Last time this was discussed [1], I think you felt that the current site list >> and dialog box is too small to display the full URL usefully. >> >> [1] http://cygwin.com/ml/cygwin-apps/2010-11/msg00134.html > >The dialog has still a lot of space to the left and right of the URL >list window. We could resize it to take the full available space even >in the smallest dialog size. I think that would be sufficient most >of the time. And the dialog can be resized if it doesn't suffice. I agree. I was going to suggest resizing (maybe I did before too). We'd like to get a new version of setup.exe released soon. I think these changes would be nice to have in it. Any chance you could do that Jon? cgf