From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74788 invoked by alias); 2 Mar 2015 16:32:28 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 74778 invoked by uid 89); 2 Mar 2015 16:32:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: calimero.vinschen.de Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Mar 2015 16:32:26 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 8F9D0A8092C; Mon, 2 Mar 2015 17:32:24 +0100 (CET) Date: Mon, 02 Mar 2015 16:32:00 -0000 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: [PATCH setup 4/4] Remove msg() from LogFile::endEntry() Message-ID: <20150302163224.GD12754@calimero.vinschen.de> Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <1425304525-12268-1-git-send-email-jon.turney@dronecode.org.uk> <1425304525-12268-5-git-send-email-jon.turney@dronecode.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gE7i1rD7pdK0Ng3j" Content-Disposition: inline In-Reply-To: <1425304525-12268-5-git-send-email-jon.turney@dronecode.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-03/txt/msg00015.txt.bz2 --gE7i1rD7pdK0Ng3j Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 861 On Mar 2 13:55, Jon TURNEY wrote: > Every single line of log output is written to OutputDebugString() using m= sg(). > This makes setup run quite slowly under a debugger. If you have stdout > connected to the terminal where your debugger is running (e.g. 'gdb setup= '), > this output is duplicated. >=20 > Future work: there are some other uses of msg() to report real errors. A= t the > moment, these are completely invisible unless you are running setup under= a > debugger. These should be converted to use the logger. >=20 > 2015-03-02 Jon TURNEY <...> >=20 > * LogFile.cc (endEntry): Remove msg(). Approved, under the assumption that you'll rework the other msg() calls as well ;) Thanks, Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --gE7i1rD7pdK0Ng3j Content-Type: application/pgp-signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU9JCYAAoJEPU2Bp2uRE+gdTAP+wSFhsNWe641jwBeqpMWlpzW vYsKu/YX5wOofMBlshzsFHJLWaW2SsqPm7c+XlQ0pMhsEIPcVPXiYlcJCtYS6KRN L3CaBqjTmAzMOx9DnAgmpq7NAz/LJ4MVJVIkIz5RFiw8ssXKY6yqTjFq/vV2DVZt pqCYvf9zdx7tmDX2snxaA/KzJhcO/UVxITBCyUAiszyoqBqhXG4jm9WufbvFoUmw uUCnp5ipdMMdGrApO343qeGCiwB0mKXt/+57KsyVWhaqD4j37gMwvJ3G7njTUPbL EoHIQ8QAPkfjbNBhnSuSfodGdFkvztLuN/ysk83GJmVGHRLRJpzGn5MON6Lb+sdp 3XPWJ9enbIBqtuOdr7DQ2gMHAydGkazKyYuTxKdI8Sd0VWryceVIJyby0aYn2OVm ALdr2tFqyEJs1Puh7mopOf78fJbQLqpTEzDav7plkFJvXddnp3Ei7V4yaTnYGZDQ 4TlGr0806lIrqdxTz5Vmv+0UhbUWTFkgEgjdiFSu/SIMtXfGsS5aKUO7kayteqnS OoUojO+Diou/jgXLU76Ab1m0hljRS0y/U7tHBDU/oFgjdyDRbgnIuj54jcKbj+Xm PgwJq6ACXxfCMOa0JHPSoq3ZlH0eGl1NPsanEHaIUB1Xv+/Xr0ULsk7aap8KRvyp oYtWhl+TvPaUm8ywYBu6 =j/r+ -----END PGP SIGNATURE----- --gE7i1rD7pdK0Ng3j--