From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113302 invoked by alias); 9 Jun 2015 09:56:08 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 112637 invoked by uid 89); 9 Jun 2015 09:56:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: calimero.vinschen.de Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Jun 2015 09:56:07 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 600BAA8091D; Tue, 9 Jun 2015 11:56:04 +0200 (CEST) Date: Tue, 09 Jun 2015 09:56:00 -0000 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: setup Message-ID: <20150609095604.GA4993@calimero.vinschen.de> Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <87382fdvjp.fsf@Rainer.invalid> <87h9qkbllg.fsf@Rainer.invalid> <87ioazclrp.fsf@Rainer.invalid> <20150608132823.GN3416@calimero.vinschen.de> <87oakqnkfi.fsf@Rainer.invalid> <20150608193154.GU3416@calimero.vinschen.de> <878ubtor9g.fsf@Rainer.invalid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: <878ubtor9g.fsf@Rainer.invalid> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-06/txt/msg00076.txt.bz2 --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2091 On Jun 8 22:54, Achim Gratz wrote: > Corinna Vinschen writes: > > I'm certainly not de-valuing your patch, but that makes me suspicious. > > The impact of reading from a local SSD should be rather low. That > > reminds me of the buffer size problem slowing down SHA512 evaluation, > > see git diff 0c7564..8648b05. > >[...] > > YY_INPUT 8K > > > > Especially YY_READ_BUF_SIZE defined as 8K might be a culprit here. >=20 > At least from the network the slow part is the loading of the file > (while the progress bar updates). Parsing should happen in that split > second when the loading is complete and before it switches to the > chooser pane. Right, in the networking case the download should be the major factor, but I was referring to the SSD case. > > Can you speed up reading the ini file noticably by defining > > YY_READ_BUF_SIZE to 65536 in inilex.ll? If so, is the impact of using > > base64 still an issue, performance-wise? >=20 > That's not the right place to do the override, since it ends up after > the default definition. Huh? Not for me: diff --git a/inilex.ll b/inilex.ll index 81a7f24..b5ea619 100644 --- a/inilex.ll +++ b/inilex.ll @@ -29,6 +29,7 @@ #include "sha2.h" =20 #define YY_INPUT(buf,result,max_size) { result =3D ini_getchar(buf, max_si= ze); } +#define YY_READ_BUF_SIZE 65536 =20 static int ini_getchar(char *buf, int max_size); static void ignore_line (void); > In any case, from the Flex manual it doesn't > make sense to increase that buffer ("it's almost always too large") and > it is being fed from an io_stream, which is buffered itself. Yes, but it's using the default buffersize of the underlying MSVCRT stdio, which is using some value I don't know off the top of my head. Typically this would be 1K or 4K. YY_INPUT is reading in 8K chunks, so the underlying stdio is very likely already skipping its buffering. So changing YY_READ_BUF_SIZE to 64K *should* have an impact. Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVdrg0AAoJEPU2Bp2uRE+gZB8P/2OwtcDjJRfT68mzkt9+tJuL h3TkVzrvhkYBPG9tjrroQL4/jA8yTsSGf3p8P+nP5WUJ6wlr8QajMaqnFIM8OYDH Q9yzkgD+W/6LO0uES4W1YaajSTDvxLo8B1ayppNAAWwNKadDNfIVkaryfLAiIzZ8 FS6p8f+dRH3AAR1dKgW4ShuIh+XgRW0sNPYpV2cshfjSnu21C7d+wrrl5LnwQ6XD 7IgbtHGq2eLCiaiw0sKTkQeshk696UxGiCSdI31ZJBoxyZA7ErlTseC0tBmf/ONQ RoltSWzEMkyC4mR03SJQ0Ly6dhFgBgmoZ04pHE7pztW3N0Aa7aToCJXN1MU+8JAG MWB0k05nUXDQOetmXLSiEYlvIgx9dLRcXtdCFJMbWGIZUw24srKL0+psGU7W31Xg 03kZDwqIgh6MPM4XrP5dQi8Acg2+gG/LWnlq4EAqbdjx9YfRVrb0j5LpJ5n+0tSg Pwr3jDPoW4LLPJOZwybeuLmIGdfIN9auQlBTeyrVkgq3AvNX77nz7I5eCqrdS7KQ qf20zimNXhvUvJZxumctQfUUOwfTq5kcDLwHeq75j+NHIF3FqGzAR9RNFKpMWEAl EEqxJlG1eE2sXNgoFTFA8bfcaLjCfMu91YmCRtUw1oCgT+i2/wPZmqzbxzCjcYKT ub7SHwxnFQwRIqx+p5J5 =P2ts -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--