From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28755 invoked by alias); 11 Jun 2015 10:06:13 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 28745 invoked by uid 89); 11 Jun 2015 10:06:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: calimero.vinschen.de Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jun 2015 10:06:11 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id C880FA80522; Thu, 11 Jun 2015 12:06:07 +0200 (CEST) Date: Thu, 11 Jun 2015 10:06:00 -0000 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: setup Message-ID: <20150611100607.GA14763@calimero.vinschen.de> Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <20150608132823.GN3416@calimero.vinschen.de> <87oakqnkfi.fsf@Rainer.invalid> <20150608193154.GU3416@calimero.vinschen.de> <878ubtor9g.fsf@Rainer.invalid> <20150609095604.GA4993@calimero.vinschen.de> <874mmghlf8.fsf@Rainer.invalid> <20150610080526.GC31537@calimero.vinschen.de> <871thjtq0m.fsf@Rainer.invalid> <20150610185417.GL31537@calimero.vinschen.de> <87wpzbs2yj.fsf@Rainer.invalid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZGiS0Q5IWpPtfppv" Content-Disposition: inline In-Reply-To: <87wpzbs2yj.fsf@Rainer.invalid> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-06/txt/msg00082.txt.bz2 --ZGiS0Q5IWpPtfppv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2137 On Jun 10 22:50, Achim Gratz wrote: > Corinna Vinschen writes: > >> > Either way, please go ahead and apply your patch. While you're at i= t, >=20 > Done. >=20 > >> > would you mind to change YY_READ_BUF_SIZE as above and raise the buf= fer > >> > size in io_stream::copy to 64K as well? > >> > >> Yes, but I'll probably put each of those in a separate commit. > > > > Sure, thank you. >=20 > I'll do that later since I have to re-shuffle some local commits and > then test everything again first. >=20 >=20 > If you're so inclined you could perhaps have a look at the next commit > on my local branch: >=20 > http://repo.or.cz/w/cygwin-setup/local.git/commitdiff/5b4e8b928c7fe16b281= 3b5f1bdbf27b49c8e0d57 >=20 > This implements xz compressed setup.xz files over network in addition to > setup.bz2. The difference between bz2 and xz is pretty consistently > about 10% smaller files for xz, but the main envisioned advantage some > time down the road (years, most likely) would be to get rid of the > additional compression libraries in setup once everything is compressed > with xz. The best compression setting with the setup files I have > looked at is "-6e". I've also checked that setup can deal correctly > with different checksums for the xz blocks (standard is crc64, but > sha256 works). Ok, I took a look. Basically it looks fine, but it seems there's a bug in terms of sig_fail. You're giving sig_fail as argument to fetch_remote_ini. Inside fetch_remote_ini, you're setting sig_fail, but you never test it. However, since sig_fail has been given to fetch_remote_ini by value, not by reference, the caller will never see the change to sig_fail. So in the expression if (!ini_file && !sig_fail) sig_fail is always false. I'm also wondering of the new logic at this point. If you fix the above call by value of sig_fail, the new logic will only continue if there was no sig test fail. It will not continue if there was no ini file, as it did before. Why? Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --ZGiS0Q5IWpPtfppv Content-Type: application/pgp-signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVeV2PAAoJEPU2Bp2uRE+gbBUP+QFzwySsqAtoC3LizqeqWwQb +UdvVPjVE5qTW7SBkDeO/P7agID2rQGg3p9rJjOay3buibcEH5i4plJfxhmX2lR3 T387pRsdfYr9K2LVuNFi9O5NikydQ1FJPZe6Od0T2x/pFo7GjKBNTBw5AnZgyotG uZS2GllmWiOYMeUaPxUeZSFKb2Qb/0CT/hmdwgm3crA1uwMoZY4Fc6cP0h5QRhiw O0j4c1ng0lZgmFCAdmOwTzKsQcEpXioccRFDj7EYLXRBEVGxtkL07bL8QskeCjC/ 4G2DGVNBDU7RNSfYrzKbWEax/PkjMIwtm7M9Wa1Vq3xe+ESZEuzKX8t8wiqpEiqk Cne34sqzXVXSwoHxSltgmrufcUugXAaEjehf+E0G9mqqG0au+T6S2YaEBhPwTSe8 n/xpb6I1UbTlVYEB7JNPr8aIV139RcrMIk1fdh+2juGRCdEObZ8uYyCHdDvDQKFj ZyxiYTnC/Vefu9O5rl+UwflDw33vVgC2M4UeLzDj1+zV5u6OO01HNV+71GvhyGBm dGFIv/C1hQnxKHD+t8djlTOt2X9R+oxsd11e22wb/UHWLBshBfEnCGai6Lca89X0 VyzjJuZa5VspRf059co5OqhpMwdUJIikbWPi1opzyyQOsqcC+VuNxRBpDUjJ1x4H PHXWINPck5RmvzlMopUf =HkmB -----END PGP SIGNATURE----- --ZGiS0Q5IWpPtfppv--