From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52930 invoked by alias); 11 Jun 2015 10:11:43 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 52917 invoked by uid 89); 11 Jun 2015 10:11:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: calimero.vinschen.de Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jun 2015 10:11:41 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 20CD5A80522; Thu, 11 Jun 2015 12:11:38 +0200 (CEST) Date: Thu, 11 Jun 2015 10:11:00 -0000 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: setup Message-ID: <20150611101138.GO31537@calimero.vinschen.de> Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <87oakqnkfi.fsf@Rainer.invalid> <20150608193154.GU3416@calimero.vinschen.de> <878ubtor9g.fsf@Rainer.invalid> <20150609095604.GA4993@calimero.vinschen.de> <874mmghlf8.fsf@Rainer.invalid> <20150610080526.GC31537@calimero.vinschen.de> <871thjtq0m.fsf@Rainer.invalid> <20150610185417.GL31537@calimero.vinschen.de> <87wpzbs2yj.fsf@Rainer.invalid> <20150611100607.GA14763@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ed/6oDxOLijJh8b0" Content-Disposition: inline In-Reply-To: <20150611100607.GA14763@calimero.vinschen.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-06/txt/msg00083.txt.bz2 --ed/6oDxOLijJh8b0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2550 On Jun 11 12:06, Corinna Vinschen wrote: > On Jun 10 22:50, Achim Gratz wrote: > > Corinna Vinschen writes: > > >> > Either way, please go ahead and apply your patch. While you're at= it, > >=20 > > Done. > >=20 > > >> > would you mind to change YY_READ_BUF_SIZE as above and raise the b= uffer > > >> > size in io_stream::copy to 64K as well? > > >> > > >> Yes, but I'll probably put each of those in a separate commit. > > > > > > Sure, thank you. > >=20 > > I'll do that later since I have to re-shuffle some local commits and > > then test everything again first. > >=20 > >=20 > > If you're so inclined you could perhaps have a look at the next commit > > on my local branch: > >=20 > > http://repo.or.cz/w/cygwin-setup/local.git/commitdiff/5b4e8b928c7fe16b2= 813b5f1bdbf27b49c8e0d57 > >=20 > > This implements xz compressed setup.xz files over network in addition to > > setup.bz2. The difference between bz2 and xz is pretty consistently > > about 10% smaller files for xz, but the main envisioned advantage some > > time down the road (years, most likely) would be to get rid of the > > additional compression libraries in setup once everything is compressed > > with xz. The best compression setting with the setup files I have > > looked at is "-6e". I've also checked that setup can deal correctly > > with different checksums for the xz blocks (standard is crc64, but > > sha256 works). >=20 > Ok, I took a look. Basically it looks fine, but it seems there's a bug > in terms of sig_fail. >=20 > You're giving sig_fail as argument to fetch_remote_ini. Inside > fetch_remote_ini, you're setting sig_fail, but you never test it. > However, since sig_fail has been given to fetch_remote_ini by value, > not by reference, the caller will never see the change to sig_fail. > So in the expression >=20 > if (!ini_file && !sig_fail) >=20 > sig_fail is always false. >=20 > I'm also wondering of the new logic at this point. If you fix the above > call by value of sig_fail, the new logic will only continue if there > was no sig test fail. It will not continue if there was no ini file, ^^^^^^^^^^^^^^^^^^^^^^^^ Doh. Make that "if there was a signature test fail" > as it did before. Why? Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --ed/6oDxOLijJh8b0 Content-Type: application/pgp-signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVeV7aAAoJEPU2Bp2uRE+gfDYQAJ9pJXiFeganxr3U36XnzfSV TSGSy3nZ7+jtVWFYVVib0RQ4EWXQb0Zp5CNlp/ekkeJxCVh/Jgcrni0wFOz0DcQX 0TAiqjJC57FHe/Ulzt5T11W+KFvV7n4Zvek3UIYz6xj1QfH8HsOB7gP+ay5ZEJtH ZuYMLVwAEzX+0XRX4fBGHSckz0jn5428thRAHpBVEMr3vVAcpCUZAT84xrJ6+/+V Upv/Cl5IKJQ7DDIGcqGkHBP7K5xg6b46GW++R5bXdmE66AskoNdY6ZWwzVjkiDpO HRe3A2kRwEbTs5at99YDzOvnEyxZLLXwJPLJw5+i8f1ZPB+meqBnb1U3xlISKpzj D8it80vNMux4BYjzYnrRaS+LkA0UR2A8B68Y+xU1teHS+cXyG84pPRNPTUmQwVN7 1yclAWTnAX0aCG7rzhe36VcIczln3R29uzRLbCWIxlIo05FhfITJMDIIt4vzfMcO cATydgRFE8KQe6qlEhvhHkPYgPHN3uU2MVX525f2Tnzl+fYypuooAsxBSFCL4c9v 7/+3w/EspzJXneip1nWOZ9sMu4bRbJp3s2Wvnnqpwb5LA7hqk/x4wsJ6e/HBxLYh z2iiQ33kCSFXQCb7udOXAC/uBR4m3m1aFa1Uq7X9Z6OSWvCJfspX8gxJ7FEe14qS cHr/RXlVjGuh36ihhb6Y =1n1E -----END PGP SIGNATURE----- --ed/6oDxOLijJh8b0--