From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87447 invoked by alias); 3 Jul 2015 10:14:58 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 87436 invoked by uid 89); 3 Jul 2015 10:14:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: calimero.vinschen.de Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 03 Jul 2015 10:14:56 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id AF8F7A80969; Fri, 3 Jul 2015 12:14:53 +0200 (CEST) Date: Fri, 03 Jul 2015 10:14:00 -0000 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: setup Message-ID: <20150703101453.GW2918@calimero.vinschen.de> Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <87mw060xg3.fsf@Rainer.invalid> <20150612102945.GS31537@calimero.vinschen.de> <87bngkzwki.fsf@Rainer.invalid> <87ioa8t0ha.fsf@Rainer.invalid> <20150629134154.GA2918@calimero.vinschen.de> <873819okox.fsf@Rainer.invalid> <20150630164052.GE2918@calimero.vinschen.de> <87vbe3ehrb.fsf@Rainer.invalid> <20150702091018.GA21212@calimero.vinschen.de> <87bnfu2rxs.fsf@Rainer.invalid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vzUQzca511KWT6Hk" Content-Disposition: inline In-Reply-To: <87bnfu2rxs.fsf@Rainer.invalid> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-07/txt/msg00006.txt.bz2 --vzUQzca511KWT6Hk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1586 On Jul 2 23:03, Achim Gratz wrote: > Corinna Vinschen writes: > > (*) This puzzles me a bit. You're keeping arrays and lists in terms of > > the file suffix (setup_ext, setup_ext_list), but you don't use the > > information here and elsewhere. >=20 > THat vector is a relatively late addition to the code when the rest was > already using literals as before. It's something that I want to clean > up, but not necessarily right now. As you noted, I'd probably need to > use a more structured data type. >=20 > > I'd prefer /* */ for multiline comments, but that's used pretty > > inconsistently anyway, so, never mind. >=20 > If you insist=E2=80=A6 but setup is C++ and not C anyway. Not so much insisting, just a wish. > > The existing code is inconsistently formatted, but for new code it would > > be nice if we could try to be more consistent. Always prepend a space > > to a left parenthesis, please. >=20 > I'll check that. >=20 > > Sorry if that's a lot. It just occured to me while reading your code. > > I'm not adamant about the structural change I outlined above, but to > > me it seems better to do it that way. What do you think? >=20 > It will just have to wait a bit, I think. But yes, these are all good > suggestions. Cool. If you want to check in the current state (plus formatting tweaks), feel free. It would just be nice if you would consider to make the structural changes at one point. Thanks, Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --vzUQzca511KWT6Hk Content-Type: application/pgp-signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVlmCdAAoJEPU2Bp2uRE+guwsQAIDu397OUU2Wc7NbUhf4R9b4 zOyKsbP922PV0acIM/PX2YzoCta0951coKqd1rDaszR2BCf1Smh7wU171Gy9o69L c3G0/PYfd/Zrr7ZqN5euwNKQzdMk676WxCYj6UB8m7mA8OTMmgyODIs5DrX1yF7K fUkD7Orp5pSLjCG9GGYy38z+q2UZT4wESbjUUtor77Et9lOnKEugoHMi+eeA8IA3 U8SidktPdA7V03xjNGBXZy0JvfEHCrvei97mU3SsRxoI8gyzw6DoEGMUvrGcMAuc lPGQfcw+dDiQNuJWGYvC7rYy6WWCT8zCcLcRGg2QueUNbgr1BlHAFwQz25HoDgyV JiujIQR+7U1gQC5VqLlgVvdKJW6z/r2RUCv9WxGAvFz/IkWqpftNBCEHiuiKPBEt UX9dV5q2QrV96Lr4c6FogSGNVnYUerANGtgAz20JTcXZju7VOehcx02PE1RPCrA+ +eDeaZFjBYINFznmMQXGJeyo2IG1ckkRhJVdbZvAT4SspYpiTvsXI9LKajcwlgtd XFKEd32ZM0p3B8TETDfO6+LwiAYuWTEt5bqpCWphRaEDiczpxuwt1HfKXbJp32d5 7NKtvjew/qjQ8plyNKbj3KVO5ugJhmsgQ5ZWPtJ24lWfkWXWa3wO49zcdSxmcoQG 7a3s6qrOhkAo+yvbxhKo =tHT+ -----END PGP SIGNATURE----- --vzUQzca511KWT6Hk--