Re: [ITP] Inetutils 1.9.4

[Corinna Vinschen <corinna-cygwin@cygwin.com>]

[-- Attachment #1: Type: text/plain, Size: 4246 bytes --]

Hi Daniel,

On Feb 13 07:56, D. Boland wrote:
> Hi Corinna,
> 
> Corinna Vinschen wrote:
> >On Feb  7 18:55, D. Boland wrote:
> >>Some programs in the inetutils suite are packaged already:
> >>
> >>* hostname
> >>* whois
> >>* tftp
> >>* tftp-server
> >>
> >>So I added these on the 'required' lines.
> >
> >They are not actually *required* to run inetd, right?  Does it really
> >make sense to add them as require packages then?
> 
> They belong to the package. A user expects them in there and would have
> to piece the package back together. Why does it make sense to leave them
> out?

These tools are provided separately in many Linux distros for quite
some time, and while those tools can be started by inetd, inetd
doesn't require them and they don't require inetd (xinetd is perfectly
capable of replacing inetd).

> >>Also, the following include files are needed:
> >>
> >>* /usr/include/netinet/icmp6.h
> >>* /usr/include/netinet/ip_var.h
> >>
> >>There has been discussion on including the icmp6.h file in Cygwin 2.3.0.
> >
> >Can you check if icmp6.h from FreeBSD
> >https://svnweb.freebsd.org/base/head/sys/netinet/icmp6.h?revision=279531&view=co
> >does the trick when copied to /usr/include/netinet?  If so, I add this file
> >to the repo.
> 
> If I use the FreeBSD version I get:
> 
> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I..  -I../lib -I../lib -I../libinetutils
> -I../libicmp    -O2 -pipe -Wimplicit-function-declaration -MT ping6.o -MD
> -MP -MF .deps/ping6.Tpo -c -o ping6.o ping6.c
> ping6.c: In function 'ping_init':
> ping6.c:844:37: error: 'ICMP6_FILTER' undeclared (first use in this
> function)
>      setsockopt (fd, IPPROTO_ICMPV6, ICMP6_FILTER, &filter, sizeof
> (filter));

That won't work.  Ever.  Using RAW sockets requires administrator
privileges.  Apart from that, WinSock setsockopt does not at all support
settings for the IPPROTO_ICMPV6 protocol family.  That's what the
32 bit ping package

I took a (not so) quick glance over the binary packages and there are
some problems:

- etc/defaults/etc/init.src.sh has 000 perms.

- etc/defaults/etc/shells collides with the already provided file from
  the base-files package.

- usr/bin/inetutils-server-config installs inetd and syslogd in one
  go.  That's a no no.  There should be two installation scripts since
  you can't expect that a user who wants one service also wants the
  other one.  Some people would probably like to stick to the Windows
  logging, or install syslog-ng.

- Apropos syslog-ng: syslogd potentially collides with syslog-ng.
  However, instead of reusing the existing /usr/bin/syslogd-config
  script, your new scripts don't check for an existing syslog-ng
  installation at all.

- You removed the etc/defaults/etc/xinetd.d files.

- You removed the /usr/bin/iu-config file, which was specificially
  created to allow running under the cyg_server account for the known
  reasons of being able to switch the user context(*).  Your scripts
  enforce file ownership and service start under the SYSTEM account.
  That's why the csih package exists for service installation scripts to
  use for stuff like that.  Please have a look into the old
  /usr/bin/iu-config file.

- usr/bin/ping collides with the ping package.

- sbin/ifconfig is mostly non-functional since Cygwin doesn't support
  most of the functionality.  Do you really want to maintain it?

- usr/bin/traceroute is non-functional:

    $ traceroute.exe www.wdr.de
    traceroute to e2636.g.akamaiedge.net (104.90.150.230), 64 hops max
    traceroute: socket: Operation not permitted

- What also irritates me is that almost none of the patches from the
  former package made it into your version.  Did you actually check the
  patches from the current 1.9.1 source package and made sure that they
  are really not required anymore, especially concerning O_BINARY/O_TEXT
  mode, authentication, exception handling, and, generally, backward
  compatibility?


Corinna

(*) https://cygwin.com/cygwin-ug-net/ntsec.html

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]