From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH setup 03/10] Rename category "Misc" to "Orphaned"
Date: Tue, 23 May 2017 16:47:00 -0000 [thread overview]
Message-ID: <20170523164558.50320-4-jon.turney@dronecode.org.uk> (raw)
In-Reply-To: <20170523164558.50320-1-jon.turney@dronecode.org.uk>
Packages which have no category are placed into this category. Since a
category is mandatory for all packages in setup.ini, this effectively means
packages which are "orphaned" in the sense that they are installed, but
don't appear in any setup.ini.
Usually it's safe to uninstall such packages (with --delete-orphans), unless
you are actually using them, or have locally built packages which rely on
them.
---
choose.cc | 2 +-
package_db.cc | 2 +-
package_meta.cc | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/choose.cc b/choose.cc
index 2016caa..4ac5aae 100644
--- a/choose.cc
+++ b/choose.cc
@@ -260,7 +260,7 @@ ChooserPage::OnInit ()
bool wanted = pkg.isManuallyWanted();
bool deleted = pkg.isManuallyDeleted();
bool basemisc = (pkg.categories.find ("Base") != pkg.categories.end ()
- || pkg.categories.find ("Misc") != pkg.categories.end ());
+ || pkg.categories.find ("Orphaned") != pkg.categories.end ());
bool upgrade = wanted || (!pkg.installed && basemisc)
|| UpgradeAlsoOption || !hasManualSelections;
bool install = wanted && !deleted && !pkg.installed;
diff --git a/package_db.cc b/package_db.cc
index 3978421..dbec17e 100644
--- a/package_db.cc
+++ b/package_db.cc
@@ -435,7 +435,7 @@ packagedb::defaultTrust (trusts trust)
packagemeta & pkg = *(i->second);
if (pkg.installed
|| pkg.categories.find ("Base") != pkg.categories.end ()
- || pkg.categories.find ("Misc") != pkg.categories.end ())
+ || pkg.categories.find ("Orphaned") != pkg.categories.end ())
{
pkg.desired = pkg.trustp (true, trust);
if (pkg.desired)
diff --git a/package_meta.cc b/package_meta.cc
index b1db191..208b948 100644
--- a/package_meta.cc
+++ b/package_meta.cc
@@ -464,7 +464,7 @@ packagemeta::set_action (_actions action, packageversion const &default_version)
{
if (installed
|| categories.find ("Base") != categories.end ()
- || categories.find ("Misc") != categories.end ())
+ || categories.find ("Orphaned") != categories.end ())
{
desired = default_version;
if (desired)
@@ -688,7 +688,7 @@ packagemeta::hasNoCategories() const
void
packagemeta::setDefaultCategories()
{
- add_category ("Misc");
+ add_category ("Orphaned");
}
void
--
2.12.3
next prev parent reply other threads:[~2017-05-23 16:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 16:46 [PATCH setup 00/10] Various setup patches Jon Turney
2017-05-23 16:47 ` [PATCH setup 02/10] Correctly calculate total data to checksum when using IncludeSource Jon Turney
2017-05-23 16:47 ` [PATCH setup 05/10] Move and rename dumpAndList() Jon Turney
2017-05-23 16:47 ` [PATCH setup 04/10] Make PrereqChecker::setTrust() a static method Jon Turney
2017-05-23 16:47 ` [PATCH setup 07/10] Fold build(Install|Source)(MD5|SHA512) into buildPackage(Install|Source) Jon Turney
2017-05-23 16:47 ` Jon Turney [this message]
2017-05-23 16:47 ` [PATCH setup 06/10] Fold IniDBBuilderPackage::buildInstallSize() into buildPackageInstall() Jon Turney
2017-05-23 16:47 ` [PATCH setup 01/10] isBinary() should return true for orphaned packages Jon Turney
2017-05-23 16:59 ` [PATCH setup 08/10] Fix infinite recursion in grammar for depends Jon Turney
2017-05-23 16:59 ` [PATCH setup 09/10] Improve error recovery in setup.ini parsing Jon Turney
2017-05-23 16:59 ` [PATCH setup 10/10] Remove OR from grammar Jon Turney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523164558.50320-4-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).