From: Jon Turney <jon.turney@dronecode.org.uk>
To: cygwin-apps@cygwin.com
Cc: Jon Turney <jon.turney@dronecode.org.uk>
Subject: [PATCH setup 13/14] Download/checksum/install/uninstall what transaction wants
Date: Wed, 31 May 2017 11:05:00 -0000 [thread overview]
Message-ID: <20170531110509.241220-3-jon.turney@dronecode.org.uk> (raw)
In-Reply-To: <20170531110509.241220-1-jon.turney@dronecode.org.uk>
Some of this goes rather around the houses to avoid lots of churm: In lots
of cases, we're looking up packagemeta for a given packageversion just so we
can use the pacakgemeta to access the name, which we could do via
packageversion just as easily.
We do actually need packagmeta for a couple of things: To note the package
as installed/uninstalled, and to note postinstalls scripts.
If IncludeSource is on source packages installs will have been added to the
task list in post-processing, so we don't need to handle that specially
anymore.
Source packages to be installed are kept in a separate queue as they are
installed differently to binary packages (root is /usr/src, install isn't
recorded, etc.)
---
download.cc | 71 ++++++++++++++----------------------------
install.cc | 102 ++++++++++++++++++++++++------------------------------------
2 files changed, 64 insertions(+), 109 deletions(-)
diff --git a/download.cc b/download.cc
index fda175f..4b2fb6f 100644
--- a/download.cc
+++ b/download.cc
@@ -44,14 +44,10 @@
#include "Exception.h"
-#include "getopt++/BoolOption.h"
-
using namespace std;
extern ThreeBarProgressPage Progress;
-BoolOption IncludeSource (false, 'I', "include-source", "Automatically include source download");
-
static bool
validateCachedPackage (const std::string& fullname, packagesource & pkgsource)
{
@@ -202,59 +198,38 @@ do_download_thread (HINSTANCE h, HWND owner)
Progress.SetText3 ("");
packagedb db;
- /* calculate the amount needed */
- for (packagedb::packagecollection::iterator i = db.packages.begin ();
- i != db.packages.end (); ++i)
+ const SolverTransactionList &t = db.solution.transactions();
+
+ /* calculate the total size of the download */
+ for (SolverTransactionList::const_iterator i = t.begin (); i != t.end (); ++i)
{
- packagemeta & pkg = *(i->second);
- if (pkg.picked () || pkg.srcpicked ())
- {
- packageversion version = pkg.desired;
- packageversion sourceversion = version.sourcePackage();
- try
- {
- if (pkg.picked())
- {
- if (!check_for_cached (*version.source()))
- total_download_bytes += version.source()->size;
- }
- if (pkg.srcpicked () || IncludeSource)
- {
- if (!check_for_cached (*sourceversion.source()))
- total_download_bytes += sourceversion.source()->size;
- }
- }
- catch (Exception * e)
- {
- // We know what to do with these..
- if (e->errNo() == APPERR_CORRUPT_PACKAGE)
- fatal (owner, IDS_CORRUPT_PACKAGE, pkg.name.c_str());
- // Unexpected exception.
- throw e;
- }
- }
+ packageversion version = i->version;
+
+ try
+ {
+ if (!check_for_cached (*version.source()))
+ total_download_bytes += version.source()->size;
+ }
+ catch (Exception * e)
+ {
+ // We know what to do with these..
+ if (e->errNo() == APPERR_CORRUPT_PACKAGE)
+ fatal (owner, IDS_CORRUPT_PACKAGE, version.Name().c_str());
+ // Unexpected exception.
+ throw e;
+ }
}
/* and do the download. FIXME: This here we assign a new name for the cached version
* and check that above.
*/
- for (packagedb::packagecollection::iterator i = db.packages.begin ();
- i != db.packages.end (); ++i)
+ for (SolverTransactionList::const_iterator i = t.begin (); i != t.end (); ++i)
{
- packagemeta & pkg = *(i->second);
- if (pkg.picked () || pkg.srcpicked ())
+ packageversion version = i->version;
+
{
int e = 0;
- packageversion version = pkg.desired;
- packageversion sourceversion = version.sourcePackage();
- if (pkg.picked())
- {
- e += download_one (*version.source(), owner);
- }
- if (sourceversion && (pkg.srcpicked() || IncludeSource))
- {
- e += download_one (*sourceversion.source (), owner);
- }
+ e += download_one (*version.source(), owner);
errors += e;
#if 0
if (e)
diff --git a/install.cc b/install.cc
index 9c4c01b..94c2b16 100644
--- a/install.cc
+++ b/install.cc
@@ -69,7 +69,6 @@ static long long int total_bytes = 0;
static long long int total_bytes_sofar = 0;
static int package_bytes = 0;
-extern BoolOption IncludeSource;
static BoolOption NoReplaceOnReboot (false, 'r', "no-replaceonreboot",
"Disable replacing in-use files on next "
"reboot.");
@@ -799,84 +798,61 @@ do_install_thread (HINSTANCE h, HWND owner)
/* Writes Cygwin/setup/rootdir registry value */
create_install_root ();
- vector <packagemeta *> install_q, uninstall_q, sourceinstall_q;
+ vector <packageversion> install_q, uninstall_q, sourceinstall_q;
packagedb db;
+ const SolverTransactionList &t = db.solution.transactions();
/* Calculate the amount of data to md5sum */
Progress.SetText1("Calculating...");
long long int md5sum_total_bytes = 0;
- for (packagedb::packagecollection::iterator i = db.packages.begin ();
- i != db.packages.end (); ++i)
+ for (SolverTransactionList::const_iterator i = t.begin (); i != t.end (); ++i)
{
- packagemeta & pkg = *(i->second);
+ packageversion version = i->version;
- if (pkg.picked())
+ if (i->type == SolverTransaction::transInstall)
{
- md5sum_total_bytes += pkg.desired.source()->size;
- }
-
- if (pkg.srcpicked() || IncludeSource)
- {
- md5sum_total_bytes += pkg.desired.sourcePackage ().source()->size;
+ md5sum_total_bytes += version.source()->size;
}
}
/* md5sum the packages, build lists of packages to install and uninstall
and calculate the total amount of data to install */
long long int md5sum_total_bytes_sofar = 0;
- for (packagedb::packagecollection::iterator i = db.packages.begin ();
- i != db.packages.end (); ++i)
+ for (SolverTransactionList::const_iterator i = t.begin (); i != t.end (); ++i)
{
- packagemeta & pkg = *(i->second);
+ packageversion version = i->version;
+ packagemeta *pkgm = db.findBinary (PackageSpecification(version.Name()));
+ if (!pkgm)
+ pkgm = db.findSource (PackageSpecification(version.Name()));
- if (pkg.picked())
+ if (i->type == SolverTransaction::transInstall)
{
try
{
- chksum_one (pkg, *pkg.desired.source ());
+ chksum_one (*pkgm, *version.source ());
}
catch (Exception *e)
{
- if (yesno (owner, IDS_SKIP_PACKAGE, e->what()) == IDYES)
- pkg.pick (false);
+ yesno (owner, IDS_SKIP_PACKAGE, e->what());
}
- if (pkg.picked())
{
- md5sum_total_bytes_sofar += pkg.desired.source()->size;
- total_bytes += pkg.desired.source()->size;
- install_q.push_back (&pkg);
+ md5sum_total_bytes_sofar += version.source()->size;
+ total_bytes += version.source()->size;
+
+ // source packages are kept in a separate queue as they are installed
+ // differently: root is /usr/src, install isn't recorded, etc.
+ if (version.Type() == package_source)
+ sourceinstall_q.push_back (version);
+ else
+ install_q.push_back (version);
}
}
- if (pkg.srcpicked() || IncludeSource)
+ /* Uninstall, upgrade or reinstall */
+ if (i->type == SolverTransaction::transErase)
{
- bool skiprequested = false ;
- try
- {
- chksum_one (pkg, *pkg.desired.sourcePackage ().source ());
- }
- catch (Exception *e)
- {
- if (yesno (owner, IDS_SKIP_PACKAGE, e->what()) == IDYES)
- {
- skiprequested = true ; //(err occurred,) skip pkg desired
- pkg.srcpick (false);
- }
- }
- if (pkg.srcpicked() || (IncludeSource && !skiprequested))
- {
- md5sum_total_bytes_sofar += pkg.desired.sourcePackage ().source()->size;
- total_bytes += pkg.desired.sourcePackage ().source()->size;
- sourceinstall_q.push_back (&pkg);
- }
- }
-
- /* Upgrade or reinstall */
- if ((pkg.installed && pkg.desired != pkg.installed)
- || pkg.picked ())
- {
- uninstall_q.push_back (&pkg);
+ uninstall_q.push_back (version);
}
if (md5sum_total_bytes > 0)
@@ -885,27 +861,31 @@ do_install_thread (HINSTANCE h, HWND owner)
/* start with uninstalls - remove files that new packages may replace */
Progress.SetBar2(0);
- for (vector <packagemeta *>::iterator i = uninstall_q.begin ();
+ for (vector <packageversion>::iterator i = uninstall_q.begin ();
i != uninstall_q.end (); ++i)
{
- myInstaller.preremoveOne (**i);
+ packagemeta *pkgm = db.findBinary (PackageSpecification(i->Name()));
+ myInstaller.preremoveOne (*pkgm);
Progress.SetBar2(std::distance(uninstall_q.begin(), i) + 1, uninstall_q.size());
}
Progress.SetBar2(0);
- for (vector <packagemeta *>::iterator i = uninstall_q.begin ();
+ for (vector <packageversion>::iterator i = uninstall_q.begin ();
i != uninstall_q.end (); ++i)
{
- myInstaller.uninstallOne (**i);
+ packagemeta *pkgm = db.findBinary (PackageSpecification(i->Name()));
+ myInstaller.uninstallOne (*pkgm);
Progress.SetBar2(std::distance(uninstall_q.begin(), i) + 1, uninstall_q.size());
}
- for (vector <packagemeta *>::iterator i = install_q.begin ();
+ for (vector <packageversion>::iterator i = install_q.begin ();
i != install_q.end (); ++i)
{
- packagemeta & pkg = **i;
+ packageversion & pkg = *i;
+ packagemeta *pkgm = db.findBinary (PackageSpecification(i->Name()));
+
try {
- myInstaller.installOne (pkg, pkg.desired, *pkg.desired.source(),
+ myInstaller.installOne (*pkgm, pkg, *pkg.source(),
"cygfile://", "/", owner);
}
catch (exception *e)
@@ -920,12 +900,12 @@ do_install_thread (HINSTANCE h, HWND owner)
}
}
- for (vector <packagemeta *>::iterator i = sourceinstall_q.begin ();
+ for (vector <packageversion>::iterator i = sourceinstall_q.begin ();
i != sourceinstall_q.end (); ++i)
{
- packagemeta & pkg = **i;
- myInstaller.installOne (pkg, pkg.desired.sourcePackage(),
- *pkg.desired.sourcePackage().source(),
+ packagemeta *pkgm = db.findSource (PackageSpecification(i->Name()));
+ packageversion & pkg = *i;
+ myInstaller.installOne (*pkgm, pkg, *pkg.source(),
"cygfile://", "/usr/src/", owner);
}
--
2.12.3
next prev parent reply other threads:[~2017-05-31 11:05 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 10:53 [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP) Jon Turney
2017-05-31 10:53 ` [PATCH setup 02/14] Factor out reading installed.db Jon Turney
2017-05-31 10:53 ` [PATCH setup 01/14] Opaque how PackageDepends is stored Jon Turney
2017-05-31 10:53 ` [PATCH setup 03/14] Hoist addScript() etc. up from packageversion to packagemeta Jon Turney
2017-05-31 10:53 ` [PATCH setup 05/14] Hoist uninstall up to Installer::uninstallOne() Jon Turney
2017-05-31 10:53 ` [PATCH setup 04/14] Hoist pick() up to packagemeta Jon Turney
2017-05-31 10:57 ` [PATCH setup 07/14] Store package stability in class packageversion Jon Turney
2017-05-31 10:57 ` [PATCH setup 06/14] Hoist scan() up from packageversion to packagemeta Jon Turney
2017-05-31 10:57 ` [PATCH setup 08/14] Change to using a libsolv pool for storing package information Jon Turney
2017-05-31 10:57 ` [PATCH setup 09/14] Remove cygpackage class Jon Turney
2017-05-31 10:57 ` [PATCH setup 10/14] Remove packageversion class Jon Turney
2017-05-31 11:05 ` [PATCH setup 11/14] Drop in SolvableVersion as a replacement for packageversion Jon Turney
2017-05-31 11:05 ` Jon Turney [this message]
2017-05-31 11:05 ` [PATCH setup 12/14] Use solver to check for problems and produce a list of package transactions Jon Turney
2017-05-31 11:05 ` [PATCH setup 14/14] Add obsoletes: support Jon Turney
2017-08-29 13:37 ` [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP) Ken Brown
2017-08-30 21:47 ` Ken Brown
2017-09-01 15:01 ` Ken Brown
2017-09-02 16:57 ` Ken Brown
2017-09-05 13:34 ` Jon Turney
2017-09-05 18:40 ` Achim Gratz
2017-09-06 2:52 ` Ken Brown
2017-11-23 18:10 ` Jon Turney
2017-11-23 20:32 ` Ken Brown
2017-11-23 20:54 ` Achim Gratz
2017-09-08 18:54 ` Ken Brown
2017-09-11 20:40 ` Ken Brown
2017-09-13 19:17 ` Achim Gratz
2017-09-13 21:16 ` Ken Brown
2017-09-14 17:26 ` Achim Gratz
2017-09-14 20:46 ` Ken Brown
2017-09-15 19:24 ` Jon Turney
2017-09-16 16:21 ` Ken Brown
2017-09-19 12:24 ` Ken Brown
2017-09-19 16:46 ` Jon Turney
2017-09-19 16:58 ` Ken Brown
2017-12-05 14:32 ` Jon Turney
2017-12-05 17:36 ` Ken Brown
2017-12-13 17:31 ` Ken Brown
2017-12-13 18:06 ` Achim Gratz
2017-12-13 22:31 ` Ken Brown
2017-12-14 14:12 ` Ken Brown
2017-12-24 15:00 ` Ken Brown
2018-01-09 13:25 ` Jon Turney
2018-01-09 15:37 ` Ken Brown
2018-01-09 15:49 ` Ken Brown
2018-01-13 14:14 ` Jon Turney
2018-01-13 19:56 ` Ken Brown
2018-01-13 21:29 ` Brian Inglis
2018-01-13 22:55 ` Ken Brown
2018-01-14 0:00 ` Ken Brown
2018-01-14 1:52 ` Brian Inglis
2018-01-14 2:37 ` Ken Brown
2018-01-15 19:02 ` Jon Turney
2018-01-15 21:50 ` Ken Brown
2018-01-18 19:14 ` Jon Turney
2017-09-15 15:15 ` Jon Turney
2017-09-15 16:53 ` Ken Brown
2017-09-15 20:56 ` cyg Simple
2017-09-17 16:02 ` Ken Brown
2017-09-26 14:50 ` Jon Turney
2017-09-26 16:07 ` Ken Brown
2017-09-27 19:14 ` Jon Turney
2017-09-27 20:33 ` Ken Brown
2017-09-29 17:38 ` Jon Turney
2017-09-29 20:34 ` Ken Brown
2017-10-02 14:07 ` Jon Turney
2017-10-02 15:17 ` Marco Atzeri
2017-10-04 14:43 ` Jon Turney
2017-10-10 11:18 ` Ken Brown
2017-10-10 15:49 ` Jon Turney
2017-10-17 12:45 ` Ken Brown
2017-10-17 18:47 ` Jon Turney
2017-10-18 15:28 ` Ken Brown
2017-10-18 15:57 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531110509.241220-3-jon.turney@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).