public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
* Re: setup complains about cygwin-doc package update
       [not found] ` <20170705142723.GH30902@calimero.vinschen.de>
@ 2017-07-05 17:20   ` Brian Inglis
  2017-07-05 17:27     ` Corinna Vinschen
  0 siblings, 1 reply; 9+ messages in thread
From: Brian Inglis @ 2017-07-05 17:20 UTC (permalink / raw)
  To: cygwin-apps

On 2017-07-05 08:27, Corinna Vinschen wrote:
> On Jul  5 13:32, Nellis, Kenneth wrote:
>> Curious about an error that setup.exe reported today related to upgrading 
>> package cygwin-doc to 2.8.1-1, saying:
>>
>> Postinstall script errors
>> 	These do not necessarily mean that affected packages will fail to function
>> 	properly, but please check /var/log/setup.log.full and report any problems.
>>
>> Package: _/cygwin-doc
>> 	cygwin-doc.sh exit code 2
>>
>> A subsequent setup.exe run with nothing pending gave a different message:
>>
>> Package: _/Unknown package
>> 	cygwin-doc.sh exit code 2
>>
>> Looking in setup.log.full I see:
>>
>> 2017/07/05 09:13:33 running: C:\cygwin64\bin\bash.exe --norc --noprofile "/etc/postinstall/cygwin-doc.sh"
>> Can't find directory '/proc/cygdrive/c/ProgramData/Microsoft/Windows/Start Menu/Programs/Cygwin'
>> 2017/07/05 09:13:34 abnormal exit: exit code=2
>>
>> Indeed, there is no Cygwin directory in existing directory 
>> '/proc/cygdrive/c/ProgramData/Microsoft/Windows/Start Menu/Programs'.
>>
>> Looking at cygwin-doc.sh, it seems that the script is trying to put some things in that directory.
>>
>> So, I manually created the directory and reran setup. This time no errors reported, 
>> and the newly created directory contains the following files:
>>
>> $ ls -l
>> total 24
>> -rwxr-xr-x+ 1 knellis Domain Users 1233 Jul  5 09:30 'API (HTML).lnk'
>> -rwxr-xr-x+ 1 knellis Domain Users 1041 Jul  5 09:30 'API (PDF).lnk'
>> -rwxr-xr-x+ 1 knellis Domain Users 1248 Jul  5 09:30  FAQ.lnk
>> -rwxr-xr-x+ 1 knellis Domain Users 1224 Jul  5 09:30 'Home Page.lnk'
>> -rwxr-xr-x+ 1 knellis Domain Users 1242 Jul  5 09:30 'User Guide (HTML).lnk'
>> -rwxr-xr-x+ 1 knellis Domain Users 1050 Jul  5 09:30 'User Guide (PDF).lnk'
>> $
>>
>> So, these are handy links to have, I guess, but is it appropriate for
>> cygwin-doc.sh to presume that the directory exists? Maybe it should create it
>> rather than simply bail out and complain if it doesn't exist.
> 
> In theory, the script should only create the files if the directory
> exists.  Brian?

Okay - assumed the directory would always be created by setup - presumably not
true - but do not check that assumption in pi, although thought about it -
should I check and skip creating shortcuts, rather than create dir and shorcuts?
Should I also check and skip rm in prerm? And provide patches?

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: setup complains about cygwin-doc package update
  2017-07-05 17:20   ` setup complains about cygwin-doc package update Brian Inglis
@ 2017-07-05 17:27     ` Corinna Vinschen
  2017-07-05 17:44       ` Ken Brown
  0 siblings, 1 reply; 9+ messages in thread
From: Corinna Vinschen @ 2017-07-05 17:27 UTC (permalink / raw)
  To: cygwin-apps

[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]

On Jul  5 11:20, Brian Inglis wrote:
> On 2017-07-05 08:27, Corinna Vinschen wrote:
> > On Jul  5 13:32, Nellis, Kenneth wrote:
> >> So, these are handy links to have, I guess, but is it appropriate for
> >> cygwin-doc.sh to presume that the directory exists? Maybe it should create it
> >> rather than simply bail out and complain if it doesn't exist.
> > 
> > In theory, the script should only create the files if the directory
> > exists.  Brian?
> 
> Okay - assumed the directory would always be created by setup -
> presumably not true - but do not check that assumption in pi, although
> thought about it -

User's can decline creating shortcuts in setup.

> should I check and skip creating shortcuts, rather than create dir and
> shorcuts?  Should I also check and skip rm in prerm? And provide
> patches?

Skipping goes hand in hand with the fact that the user declined the
Start Menu shortcut creation.  Patches are always good :)


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: setup complains about cygwin-doc package update
  2017-07-05 17:27     ` Corinna Vinschen
@ 2017-07-05 17:44       ` Ken Brown
  2017-07-05 18:01         ` Corinna Vinschen
  0 siblings, 1 reply; 9+ messages in thread
From: Ken Brown @ 2017-07-05 17:44 UTC (permalink / raw)
  To: cygwin-apps

On 7/5/2017 1:27 PM, Corinna Vinschen wrote:
> On Jul  5 11:20, Brian Inglis wrote:
>> On 2017-07-05 08:27, Corinna Vinschen wrote:
>>> On Jul  5 13:32, Nellis, Kenneth wrote:
>>>> So, these are handy links to have, I guess, but is it appropriate for
>>>> cygwin-doc.sh to presume that the directory exists? Maybe it should create it
>>>> rather than simply bail out and complain if it doesn't exist.
>>>
>>> In theory, the script should only create the files if the directory
>>> exists.  Brian?
>>
>> Okay - assumed the directory would always be created by setup -
>> presumably not true - but do not check that assumption in pi, although
>> thought about it -
> 
> User's can decline creating shortcuts in setup.
> 
>> should I check and skip creating shortcuts, rather than create dir and
>> shorcuts?  Should I also check and skip rm in prerm? And provide
>> patches?
> 
> Skipping goes hand in hand with the fact that the user declined the
> Start Menu shortcut creation.

The script already does check and skip.  The only issue is that it skips 
by calling 'exit 2' instead of 'exit 0', which is what led to the 
original post.

Ken

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: setup complains about cygwin-doc package update
  2017-07-05 17:44       ` Ken Brown
@ 2017-07-05 18:01         ` Corinna Vinschen
  2017-07-05 18:35           ` Brian Inglis
  0 siblings, 1 reply; 9+ messages in thread
From: Corinna Vinschen @ 2017-07-05 18:01 UTC (permalink / raw)
  To: cygwin-apps

[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]

On Jul  5 13:44, Ken Brown wrote:
> On 7/5/2017 1:27 PM, Corinna Vinschen wrote:
> > On Jul  5 11:20, Brian Inglis wrote:
> > > On 2017-07-05 08:27, Corinna Vinschen wrote:
> > > > On Jul  5 13:32, Nellis, Kenneth wrote:
> > > > > So, these are handy links to have, I guess, but is it appropriate for
> > > > > cygwin-doc.sh to presume that the directory exists? Maybe it should create it
> > > > > rather than simply bail out and complain if it doesn't exist.
> > > > 
> > > > In theory, the script should only create the files if the directory
> > > > exists.  Brian?
> > > 
> > > Okay - assumed the directory would always be created by setup -
> > > presumably not true - but do not check that assumption in pi, although
> > > thought about it -
> > 
> > User's can decline creating shortcuts in setup.
> > 
> > > should I check and skip creating shortcuts, rather than create dir and
> > > shorcuts?  Should I also check and skip rm in prerm? And provide
> > > patches?
> > 
> > Skipping goes hand in hand with the fact that the user declined the
> > Start Menu shortcut creation.
> 
> The script already does check and skip.  The only issue is that it skips by
> calling 'exit 2' instead of 'exit 0', which is what led to the original
> post.

Note to myself: read source before talking about it.


:}
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: setup complains about cygwin-doc package update
  2017-07-05 18:01         ` Corinna Vinschen
@ 2017-07-05 18:35           ` Brian Inglis
  2017-07-06  8:02             ` Corinna Vinschen
  0 siblings, 1 reply; 9+ messages in thread
From: Brian Inglis @ 2017-07-05 18:35 UTC (permalink / raw)
  To: cygwin-apps

[-- Attachment #1: Type: text/plain, Size: 1612 bytes --]

On 2017-07-05 12:01, Corinna Vinschen wrote:
> On Jul  5 13:44, Ken Brown wrote:
>> On 7/5/2017 1:27 PM, Corinna Vinschen wrote:
>>> On Jul  5 11:20, Brian Inglis wrote:
>>>> On 2017-07-05 08:27, Corinna Vinschen wrote:
>>>>> On Jul  5 13:32, Nellis, Kenneth wrote:
>>>>>> So, these are handy links to have, I guess, but is it appropriate for
>>>>>> cygwin-doc.sh to presume that the directory exists? Maybe it should create it
>>>>>> rather than simply bail out and complain if it doesn't exist.
>>>>>
>>>>> In theory, the script should only create the files if the directory
>>>>> exists.  Brian?
>>>>
>>>> Okay - assumed the directory would always be created by setup -
>>>> presumably not true - but do not check that assumption in pi, although
>>>> thought about it -
>>>
>>> User's can decline creating shortcuts in setup.
>>>
>>>> should I check and skip creating shortcuts, rather than create dir and
>>>> shorcuts?  Should I also check and skip rm in prerm? And provide
>>>> patches?
>>>
>>> Skipping goes hand in hand with the fact that the user declined the
>>> Start Menu shortcut creation.
>>
>> The script already does check and skip.  The only issue is that it skips by
>> calling 'exit 2' instead of 'exit 0', which is what led to the original
>> post.
> 
> Note to myself: read source before talking about it.

Patch(es) attached - shuffled the order of a few things to fail quietly in
postinstall - changed preremove to look and take a similar approach to
postinstall for consistency - format-patch should apply cleanly this time.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

[-- Attachment #2: 0001-fix-cygwin-doc-postinstall-preremove-no-SMPrograms-C.patch --]
[-- Type: text/plain, Size: 4060 bytes --]

From 92a3dd37dc9f0da65f958707d93d9e11b6047bd8 Mon Sep 17 00:00:00 2001
From: Brian Inglis <Brian.Inglis@SystematicSW.ab.ca>
Date: Wed, 5 Jul 2017 12:28:54 -0600
Subject: [PATCH] fix cygwin-doc postinstall/preremove no SMPrograms/Cygwin dir

---
 winsup/doc/etc.postinstall.cygwin-doc.sh | 35 +++++++++++++++----------
 winsup/doc/etc.preremove.cygwin-doc.sh   | 45 +++++++++++++++++++++++++++++---
 2 files changed, 63 insertions(+), 17 deletions(-)

diff --git a/winsup/doc/etc.postinstall.cygwin-doc.sh b/winsup/doc/etc.postinstall.cygwin-doc.sh
index 3a9457fbb..1d41ef0c1 100755
--- a/winsup/doc/etc.postinstall.cygwin-doc.sh
+++ b/winsup/doc/etc.postinstall.cygwin-doc.sh
@@ -6,35 +6,42 @@
 # CYGWINFORALL=-A if install for All Users
 # installs local shortcuts for All Users or Current User in
 # {ProgramData,~/Appdata/Roaming}/Microsoft/Windows/Start Menu/Programs/Cygwin/
+# exits quietly if directory does not exist as presumably no shortcuts desired
 
+doc=/usr/share/doc/cygwin-doc
+site=https://cygwin.com
 cygp=/bin/cygpath
 mks=/bin/mkshortcut
-un=/bin/uname
-site=https://cygwin.com
 
-# check for programs
-for p in $un $cygp $mks
+html=$doc/html
+
+# check source directories created
+for d in $doc $html
 do
-	if [ ! -x $p ]
+	if [ ! -d "$d/" ]
 	then
-		echo "Can't find program '$p'"
+		echo "Can't find directory '$d'"
 		exit 2
 	fi
 done
 
-doc=/usr/share/doc/cygwin-doc
-html=$doc/html
-smpc_dir="$($cygp $CYGWINFORALL -P -U)/Cygwin"
-
-for d in $doc $html "$smpc_dir"
+# check for programs
+for p in $cygp $mks
 do
-	if [ ! -d "$d/" ]
+	if [ ! -x $p ]
 	then
-		echo "Can't find directory '$d'"
+		echo "Can't find program '$p'"
 		exit 2
 	fi
 done
 
+# Cygwin Start Menu directory
+smpc_dir="$($cygp $CYGWINFORALL -P -U --)/Cygwin"
+
+# check Cygwin Start Menu directory still exists
+[ -d "$smpc_dir/" ] || exit 0
+
+# check Cygwin Start Menu directory writable
 if [ ! -w "$smpc_dir/" ]
 then
 	echo "Can't write to directory '$smpc_dir'"
@@ -42,7 +49,7 @@ then
 fi
 
 # mkshortcut works only in current directory - change to Cygwin Start Menu
-cd "$smpc_dir" || exit 2	# quit if not found
+cd "$smpc_dir/" || exit 0	# quit if not found
 
 # create User Guide and API PDF and HTML shortcuts
 while read target name desc
diff --git a/winsup/doc/etc.preremove.cygwin-doc.sh b/winsup/doc/etc.preremove.cygwin-doc.sh
index 817d6d68e..09e0c9efc 100755
--- a/winsup/doc/etc.preremove.cygwin-doc.sh
+++ b/winsup/doc/etc.preremove.cygwin-doc.sh
@@ -6,9 +6,48 @@
 # CYGWINFORALL=-A if remove for All Users
 # remove local shortcuts for All Users or Current User in
 # {ProgramData,~/Appdata/Roaming}/Microsoft/Windows/Start Menu/Programs/Cygwin/
+# exits quietly if directory does not exist as presumably no shortcuts desired
 
-cd "$(/bin/cygpath $CYGWINFORALL -P -U)/Cygwin" || exit 2
+doc=/usr/share/doc/cygwin-doc
+cygp=/bin/cygpath
+rm=/bin/rm
 
-/bin/rm -f -- "User Guide (PDF).lnk" "User Guide (HTML).lnk" \
-	"API (PDF).lnk" "API (HTML).lnk" "Home Page.lnk" "FAQ.lnk"
+html=$doc/html
+
+# check for programs
+for p in $cygp $rm
+do
+	if [ ! -x $p ]
+	then
+		echo "Can't find program '$p'"
+		exit 2
+	fi
+done
+
+# Cygwin Start Menu directory
+smpc_dir="$($cygp $CYGWINFORALL -P -U --)/Cygwin"
+
+# check Cygwin Start Menu directory still exists
+[ -d "$smpc_dir/" ] || exit 0
+
+# check Cygwin Start Menu directory writable
+if [ ! -w "$smpc_dir/" ]
+then
+	echo "Can't write to directory '$smpc_dir'"
+	exit 1
+fi
+
+# remove User Guide and API PDF and HTML, Home Page and FAQ URL link shortcuts
+while read target name desc
+do
+	lnk="$smpc_dir/$name.lnk"
+	[ -f "$lnk" ] && $rm -f -- "$lnk"
+done <<EOF
+$doc/cygwin-ug-net.pdf		User\ Guide\ \(PDF\)  Cygwin\ User\ Guide\ PDF
+$html/cygwin-ug-net/index.html	User\ Guide\ \(HTML\) Cygwin\ User\ Guide\ HTML
+$doc/cygwin-api.pdf		API\ \(PDF\)	Cygwin\ API\ Reference\ PDF
+$html/cygwin-api/index.html	API\ \(HTML\)	Cygwin\ API\ Reference\ HTML
+$site/index.html	Home\ Page	Cygwin\ Home\ Page\ Link
+$site/faq.html		FAQ	Cygwin\ Frequently\ Asked\ Questions\ Link
+EOF
 
-- 
2.12.3


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: setup complains about cygwin-doc package update
  2017-07-05 18:35           ` Brian Inglis
@ 2017-07-06  8:02             ` Corinna Vinschen
  2017-07-06 14:53               ` Brian Inglis
  0 siblings, 1 reply; 9+ messages in thread
From: Corinna Vinschen @ 2017-07-06  8:02 UTC (permalink / raw)
  To: cygwin-apps

[-- Attachment #1: Type: text/plain, Size: 2201 bytes --]

On Jul  5 12:35, Brian Inglis wrote:
> On 2017-07-05 12:01, Corinna Vinschen wrote:
> > On Jul  5 13:44, Ken Brown wrote:
> >> On 7/5/2017 1:27 PM, Corinna Vinschen wrote:
> >>> On Jul  5 11:20, Brian Inglis wrote:
> >>>> On 2017-07-05 08:27, Corinna Vinschen wrote:
> >>>>> On Jul  5 13:32, Nellis, Kenneth wrote:
> >>>>>> So, these are handy links to have, I guess, but is it appropriate for
> >>>>>> cygwin-doc.sh to presume that the directory exists? Maybe it should create it
> >>>>>> rather than simply bail out and complain if it doesn't exist.
> >>>>>
> >>>>> In theory, the script should only create the files if the directory
> >>>>> exists.  Brian?
> >>>>
> >>>> Okay - assumed the directory would always be created by setup -
> >>>> presumably not true - but do not check that assumption in pi, although
> >>>> thought about it -
> >>>
> >>> User's can decline creating shortcuts in setup.
> >>>
> >>>> should I check and skip creating shortcuts, rather than create dir and
> >>>> shorcuts?  Should I also check and skip rm in prerm? And provide
> >>>> patches?
> >>>
> >>> Skipping goes hand in hand with the fact that the user declined the
> >>> Start Menu shortcut creation.
> >>
> >> The script already does check and skip.  The only issue is that it skips by
> >> calling 'exit 2' instead of 'exit 0', which is what led to the original
> >> post.
> > 
> > Note to myself: read source before talking about it.
> 
> Patch(es) attached - shuffled the order of a few things to fail quietly in
> postinstall - changed preremove to look and take a similar approach to
> postinstall for consistency - format-patch should apply cleanly this time.
> 
> -- 
> Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

> From 92a3dd37dc9f0da65f958707d93d9e11b6047bd8 Mon Sep 17 00:00:00 2001
> From: Brian Inglis <Brian.Inglis@SystematicSW.ab.ca>
> Date: Wed, 5 Jul 2017 12:28:54 -0600
> Subject: [PATCH] fix cygwin-doc postinstall/preremove no SMPrograms/Cygwin dir

Pushed.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: setup complains about cygwin-doc package update
  2017-07-06  8:02             ` Corinna Vinschen
@ 2017-07-06 14:53               ` Brian Inglis
  2017-07-06 16:47                 ` Corinna Vinschen
  0 siblings, 1 reply; 9+ messages in thread
From: Brian Inglis @ 2017-07-06 14:53 UTC (permalink / raw)
  To: cygwin-apps

[-- Attachment #1: Type: text/plain, Size: 2407 bytes --]

On 2017-07-06 02:02, Corinna Vinschen wrote:
> On Jul  5 12:35, Brian Inglis wrote:
>> On 2017-07-05 12:01, Corinna Vinschen wrote:
>>> On Jul  5 13:44, Ken Brown wrote:
>>>> On 7/5/2017 1:27 PM, Corinna Vinschen wrote:
>>>>> On Jul  5 11:20, Brian Inglis wrote:
>>>>>> On 2017-07-05 08:27, Corinna Vinschen wrote:
>>>>>>> On Jul  5 13:32, Nellis, Kenneth wrote:
>>>>>>>> So, these are handy links to have, I guess, but is it appropriate for
>>>>>>>> cygwin-doc.sh to presume that the directory exists? Maybe it should create it
>>>>>>>> rather than simply bail out and complain if it doesn't exist.
>>>>>>>
>>>>>>> In theory, the script should only create the files if the directory
>>>>>>> exists.  Brian?
>>>>>>
>>>>>> Okay - assumed the directory would always be created by setup -
>>>>>> presumably not true - but do not check that assumption in pi, although
>>>>>> thought about it -
>>>>>
>>>>> User's can decline creating shortcuts in setup.
>>>>>
>>>>>> should I check and skip creating shortcuts, rather than create dir and
>>>>>> shorcuts?  Should I also check and skip rm in prerm? And provide
>>>>>> patches?
>>>>>
>>>>> Skipping goes hand in hand with the fact that the user declined the
>>>>> Start Menu shortcut creation.
>>>>
>>>> The script already does check and skip.  The only issue is that it skips by
>>>> calling 'exit 2' instead of 'exit 0', which is what led to the original
>>>> post.
>>>
>>> Note to myself: read source before talking about it.
>>
>> Patch(es) attached - shuffled the order of a few things to fail quietly in
>> postinstall - changed preremove to look and take a similar approach to
>> postinstall for consistency - format-patch should apply cleanly this time.

>> From 92a3dd37dc9f0da65f958707d93d9e11b6047bd8 Mon Sep 17 00:00:00 2001
>> From: Brian Inglis <Brian.Inglis@SystematicSW.ab.ca>
>> Date: Wed, 5 Jul 2017 12:28:54 -0600
>> Subject: [PATCH] fix cygwin-doc postinstall/preremove no SMPrograms/Cygwin dir
> 
> Pushed.

Thanks - sorry but this needs another fix - aargh!
Testing reveals problems with URL shortcuts to cygwin.com.

Don't know which shortcuts I was testing?
Maybe others created manually in $APPDATA/SM/Programs/Cygwin?

Attached format-patch fix to launch URLs with cygstart to make these work.
Added mkshortcut options to create directly in SM/Programs/Cygwin, dropping cd.

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

[-- Attachment #2: 0001-fix-URL-shortcuts-launch-with-cygstart-create-shortc.patch --]
[-- Type: text/plain, Size: 2068 bytes --]

From 959be4b67fbf6c654ab58a2417338ccede731288 Mon Sep 17 00:00:00 2001
From: Brian Inglis <Brian.Inglis@SystematicSW.ab.ca>
Date: Thu, 6 Jul 2017 03:35:34 -0600
Subject: [PATCH] fix URL shortcuts launch with cygstart, create shortcuts
 directly in SM/Programs/Cygwin

---
 winsup/doc/etc.postinstall.cygwin-doc.sh | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/winsup/doc/etc.postinstall.cygwin-doc.sh b/winsup/doc/etc.postinstall.cygwin-doc.sh
index 1d41ef0c1..2873d9395 100755
--- a/winsup/doc/etc.postinstall.cygwin-doc.sh
+++ b/winsup/doc/etc.postinstall.cygwin-doc.sh
@@ -12,6 +12,7 @@ doc=/usr/share/doc/cygwin-doc
 site=https://cygwin.com
 cygp=/bin/cygpath
 mks=/bin/mkshortcut
+launch=/bin/cygstart
 
 html=$doc/html
 
@@ -26,7 +27,7 @@ do
 done
 
 # check for programs
-for p in $cygp $mks
+for p in $cygp $mks $launch
 do
 	if [ ! -x $p ]
 	then
@@ -38,7 +39,7 @@ done
 # Cygwin Start Menu directory
 smpc_dir="$($cygp $CYGWINFORALL -P -U --)/Cygwin"
 
-# check Cygwin Start Menu directory still exists
+# check Cygwin Start Menu directory exists
 [ -d "$smpc_dir/" ] || exit 0
 
 # check Cygwin Start Menu directory writable
@@ -48,13 +49,10 @@ then
 	exit 1
 fi
 
-# mkshortcut works only in current directory - change to Cygwin Start Menu
-cd "$smpc_dir/" || exit 0	# quit if not found
-
 # create User Guide and API PDF and HTML shortcuts
 while read target name desc
 do
-	[ -r $t ] && $mks -n "$name" -d "$desc" $target
+	[ -r $t ] && $mks $CYGWINFORALL -P -n "Cygwin/$name" -d "$desc" -- $target
 done <<EOF
 $doc/cygwin-ug-net.pdf		User\ Guide\ \(PDF\)  Cygwin\ User\ Guide\ PDF
 $html/cygwin-ug-net/index.html	User\ Guide\ \(HTML\) Cygwin\ User\ Guide\ HTML
@@ -65,7 +63,7 @@ EOF
 # create Home Page and FAQ URL link shortcuts
 while read target name desc
 do
-	$mks -n "$name" -d "$desc" $target
+	$mks $CYGWINFORALL -P -n "Cygwin/$name" -d "$desc" -a $target -- $launch
 done <<EOF
 $site/index.html	Home\ Page	Cygwin\ Home\ Page\ Link
 $site/faq.html		FAQ	Cygwin\ Frequently\ Asked\ Questions\ Link
-- 
2.13.2


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: setup complains about cygwin-doc package update
  2017-07-06 14:53               ` Brian Inglis
@ 2017-07-06 16:47                 ` Corinna Vinschen
  2017-07-07  4:49                   ` Brian Inglis
  0 siblings, 1 reply; 9+ messages in thread
From: Corinna Vinschen @ 2017-07-06 16:47 UTC (permalink / raw)
  To: cygwin-apps

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

On Jul  6 08:53, Brian Inglis wrote:
> Thanks - sorry but this needs another fix - aargh!
> Testing reveals problems with URL shortcuts to cygwin.com.
> 
> Don't know which shortcuts I was testing?
> Maybe others created manually in $APPDATA/SM/Programs/Cygwin?
> 
> Attached format-patch fix to launch URLs with cygstart to make these work.
> Added mkshortcut options to create directly in SM/Programs/Cygwin, dropping cd.

Pushed.

Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: setup complains about cygwin-doc package update
  2017-07-06 16:47                 ` Corinna Vinschen
@ 2017-07-07  4:49                   ` Brian Inglis
  0 siblings, 0 replies; 9+ messages in thread
From: Brian Inglis @ 2017-07-07  4:49 UTC (permalink / raw)
  To: cygwin-apps

On 2017-07-06 10:47, Corinna Vinschen wrote:
> On Jul  6 08:53, Brian Inglis wrote:
>> Thanks - sorry but this needs another fix - aargh!
>> Testing reveals problems with URL shortcuts to cygwin.com.
>>
>> Don't know which shortcuts I was testing?
>> Maybe others created manually in $APPDATA/SM/Programs/Cygwin?
>>
>> Attached format-patch fix to launch URLs with cygstart to make these work.
>> Added mkshortcut options to create directly in SM/Programs/Cygwin, dropping cd.
> 
> Pushed.

Cheers!

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-07-07  4:49 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <BN6PR2001MB10741D95D8FAAD06783E1C63F1D40@BN6PR2001MB1074.namprd20.prod.outlook.com>
     [not found] ` <20170705142723.GH30902@calimero.vinschen.de>
2017-07-05 17:20   ` setup complains about cygwin-doc package update Brian Inglis
2017-07-05 17:27     ` Corinna Vinschen
2017-07-05 17:44       ` Ken Brown
2017-07-05 18:01         ` Corinna Vinschen
2017-07-05 18:35           ` Brian Inglis
2017-07-06  8:02             ` Corinna Vinschen
2017-07-06 14:53               ` Brian Inglis
2017-07-06 16:47                 ` Corinna Vinschen
2017-07-07  4:49                   ` Brian Inglis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).