From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37253 invoked by alias); 19 Jul 2017 17:03:21 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 36201 invoked by uid 89); 19 Jul 2017 17:03:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-101.9 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*c:application X-HELO: drew.franken.de Received: from mail-n.franken.de (HELO drew.franken.de) (193.175.24.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Jul 2017 17:03:17 +0000 Received: from aqua.hirmke.de (aquarius.franken.de [193.175.24.89]) (Authenticated sender: aquarius) by mail-n.franken.de (Postfix) with ESMTPSA id 0567B721E280D for ; Wed, 19 Jul 2017 19:03:15 +0200 (CEST) Received: from calimero.vinschen.de (calimero.vinschen.de [192.168.129.6]) by aqua.hirmke.de (Postfix) with ESMTP id 0F5385E04D2 for ; Wed, 19 Jul 2017 19:03:14 +0200 (CEST) Received: by calimero.vinschen.de (Postfix, from userid 500) id E482EA80637; Wed, 19 Jul 2017 19:03:13 +0200 (CEST) Date: Wed, 19 Jul 2017 17:03:00 -0000 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: [GOLDSTAR] Re: fflush(NULL) clobbers input streams Message-ID: <20170719170313.GC10516@calimero.vinschen.de> Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <87k2376jck.fsf@Rainer.invalid> <20170718095456.GC26902@calimero.vinschen.de> <20170718105109.GD26902@calimero.vinschen.de> <87fudtlfen.fsf@Rainer.invalid> <8daea64f-4f36-72cc-13f2-75c64ab06ad6@cornell.edu> <20170719084556.GA13494@calimero.vinschen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline In-Reply-To: <20170719084556.GA13494@calimero.vinschen.de> User-Agent: Mutt/1.8.3 (2017-05-23) X-SW-Source: 2017-07/txt/msg00049.txt.bz2 --jI8keyz6grp/JLjh Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1663 On Jul 19 10:45, Corinna Vinschen wrote: > On Jul 18 22:16, Ken Brown wrote: > > On 7/18/2017 6:41 PM, Ken Brown wrote: > > > On 7/18/2017 3:21 PM, Achim Gratz wrote: > > > > Corinna Vinschen writes: > > > > > Oh, and a plain C testcase, of course... > > > >=20 > > > > Call that fflush.c: > > > > [...] > > > > Then run: > > > >=20 > > > > gcc fflush.c -o fflush > > > > cat fflush.c | ./fflush 2>/dev/null > fflush.out > > > > diff fflush.c fflush.out > > > >=20 > > > > If things are working, fflush.c and fflush.out should be identical. > > > > Currently only the first line makes it into fflush.out on Cygwin. > > >=20 > > > I've checked that the 2017-03-08 snapshot is good and the 2017-03-10 > > > snapshot is bad. I'll bisect further when I get a chance > >=20 > > Done: > >=20 > > 44b1746a41921533d27aca414a9188314cb725b6 is the first bad commit > > commit 44b1746a41921533d27aca414a9188314cb725b6 > > Author: Corinna Vinschen > > Date: Fri Mar 10 20:21:09 2017 +0100 > >=20 > > errno: Stop using _impure_ptr->_errno completely > >=20 > > We use errno AKA _REENT->_errno since the last century and only set > > _impure_ptr->_errno for backward compat. Stop that. Also, remove > > the last check for _impure_ptr->_errno in Cygwin code. > >=20 > > Ken >=20 > Achim, thanks for the testcase. Ken, thanks for bisecting. You're > my hero! >=20 > I reverted the patch and created new developer snapshots. I forgot the gold star. Thanks again, Ken!=20=20 Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJZb5DRAAoJEPU2Bp2uRE+gZq8QAJEBbCErPcq4ygT2ERl1rtqx ceYHe7r5AgSTy2LWVkfKlu3Ev5KNPiBODON23NFEkFBz1CJBG3jYdKC3NPl15Y/H eRNfv5QnnEqdPpNXCjxBrjt3FViM9Jvc2i/M4B8mdW25uqvQM0/snmfeba1YSGyY brnDsZjOeklhBeu16i+uhmkkr+EymqXwBv9M122SNiFcksOVDTWDmNmz7XO9NxTt ZQJFcoX7gFDYsh3y/R4dhGOAA5RNFyukFkpxFsKY/SQbhZvn3yAFNDk6nrhuZLKh atNMyL5lJOJOGxxmq5AumN61TogtQRSszTKHymLbCcS98Un0clJoVMfvpYQm9Cno LntsNbLBCH27FQ9bS3sLCQYZkgQq9Ut9VuMbpLiN508Iu+iafwDQmRjA1XHFrriM Zi30f6d3O1T4InDr+9lPPKjDAlFfy4WkYDNYewi/a7Y5c8T1U5uMgK/AwoGCPoxR 9lGOzvzQieeJT17OxEUGecl/EYAHSyK8XjAAkeN2HSyFcWReB/ztmDmpPSPsWBEc qnE7TGnd4Sm9ysoq0G0cLvjVbXxxRtuWGM4tBJvYgatnMNTtsbRIRvcwTlqC/0JP XVWBIqIGfhmcnPl226Q6gTz2fHk8OsmGkL4tmj0hy4ZmPLpjpqi7gEmOo4hr+3eM Z407ed9hhmoWq/1uiWSE =Wj6Z -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh--