public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Yaakov Selkowitz <yselkowi@redhat.com>
To: cygwin-apps@cygwin.com
Subject: [PATCH crypt 5/8] Disable blowfish cipher
Date: Fri, 04 Aug 2017 03:01:00 -0000	[thread overview]
Message-ID: <20170804025258.19248-6-yselkowi@redhat.com> (raw)
In-Reply-To: <20170804025258.19248-1-yselkowi@redhat.com>

This didn't work properly when tested, and is not found in glibc.
---
 crypt_r.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/crypt_r.c b/crypt_r.c
index 75ba60b..f30d41d 100644
--- a/crypt_r.c
+++ b/crypt_r.c
@@ -18,8 +18,10 @@ char *__crypt_r(const char *key, const char *salt, struct crypt_data *data)
 	if (salt[0] == '$' && salt[1] && salt[2]) {
 		if (salt[1] == '1' && salt[2] == '$')
 			return __crypt_md5(key, salt, output);
+#if 0 /* doesn't work, not found in glibc */
 		if (salt[1] == '2' && salt[3] == '$')
 			return __crypt_blowfish(key, salt, output);
+#endif
 		if (salt[1] == '5' && salt[2] == '$')
 			return __crypt_sha256(key, salt, output);
 		if (salt[1] == '6' && salt[2] == '$')
-- 
2.13.2

  parent reply	other threads:[~2017-08-04  3:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-04  2:53 [PATCH crypt 0/8] Use musl implementation Yaakov Selkowitz
2017-08-04  2:53 ` [PATCH crypt 3/8] Export crypt_r Yaakov Selkowitz
2017-08-04  2:53 ` [PATCH crypt 2/8] Port sources to Cygwin Yaakov Selkowitz
2017-08-04  2:53 ` [PATCH crypt 1/8] Import musl sources Yaakov Selkowitz
2017-08-04  2:58 ` [PATCH crypt 8/8] Add .gitignore Yaakov Selkowitz
2017-08-04  2:58 ` [PATCH crypt 7/8] Update README Yaakov Selkowitz
2017-08-04  2:58 ` [PATCH crypt 4/8] Guard GNU extensions in header, declare other functions Yaakov Selkowitz
2017-08-04  3:01 ` Yaakov Selkowitz [this message]
2017-08-04  7:46   ` [PATCH crypt 5/8] Disable blowfish cipher Corinna Vinschen
2017-08-04  8:32     ` Yaakov Selkowitz
2017-09-01  1:38       ` Yaakov Selkowitz
2017-08-04  3:02 ` [PATCH crypt 6/8] Update Makefile Yaakov Selkowitz
2017-09-01  1:40   ` [PATCH v2 " Yaakov Selkowitz
2017-09-01  9:03     ` Corinna Vinschen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170804025258.19248-6-yselkowi@redhat.com \
    --to=yselkowi@redhat.com \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).