From: Ken Brown <kbrown@cornell.edu>
To: cygwin-apps@cygwin.com
Subject: [[PATCH setup topic/libsolv] 2/2] Avoid clobbering installed.db when no setup.ini is found
Date: Sat, 28 Oct 2017 12:29:00 -0000 [thread overview]
Message-ID: <20171028122932.3024-2-kbrown@cornell.edu> (raw)
In-Reply-To: <20171028122932.3024-1-kbrown@cornell.edu>
Move the calls to packagedb::read and other packagedb functions from
do_ini_thread to ChooserPage::OnInit. If no setup.ini is found,
do_ini_thread is never called. But we need to ensure that
packagedb::read is called, or else installed.db gets emptied.
---
choose.cc | 5 +++++
ini.cc | 7 -------
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/choose.cc b/choose.cc
index 619d7db..013a30a 100644
--- a/choose.cc
+++ b/choose.cc
@@ -268,6 +268,11 @@ ChooserPage::OnInit ()
packagemeta::ScanDownloadedFiles (MirrorOption);
packagedb db;
+ db.makeBase();
+ db.read();
+ db.upgrade();
+ db.fixup_source_package_ids();
+ db.removeEmptyCategories();
db.setExistence ();
db.fillMissingCategory ();
diff --git a/ini.cc b/ini.cc
index 5089e8b..0f8b927 100644
--- a/ini.cc
+++ b/ini.cc
@@ -352,13 +352,6 @@ do_ini_thread (HINSTANCE h, HWND owner)
else
ini_count = do_remote_ini (owner);
- packagedb db;
- db.makeBase();
- db.read();
- db.upgrade();
- db.fixup_source_package_ids();
- db.removeEmptyCategories();
-
if (ini_count == 0)
return false;
--
2.14.2
next prev parent reply other threads:[~2017-10-28 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 12:29 [[PATCH setup topic/libsolv] 1/2] packagedb::removeEmptyCategories: Don't remove "Base" Ken Brown
2017-10-28 12:29 ` Ken Brown [this message]
2017-10-28 17:29 ` [[PATCH setup topic/libsolv] 2/2] Avoid clobbering installed.db when no setup.ini is found Ken Brown
2017-10-29 17:24 ` [[PATCH setup topic/libsolv] 1/2] packagedb::removeEmptyCategories: Don't remove "Base" Jon Turney
2017-10-29 21:18 ` Ken Brown
2017-10-30 15:59 ` Jon Turney
2017-10-30 16:32 ` Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171028122932.3024-2-kbrown@cornell.edu \
--to=kbrown@cornell.edu \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).