From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75281 invoked by alias); 10 Nov 2017 14:43:51 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 75100 invoked by uid 89); 10 Nov 2017 14:43:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=downloaded, reinstall, uninstalled X-HELO: limerock04.mail.cornell.edu Received: from limerock04.mail.cornell.edu (HELO limerock04.mail.cornell.edu) (128.84.13.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 Nov 2017 14:43:49 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id vAAEhlEQ029501; Fri, 10 Nov 2017 09:43:47 -0500 Received: from nothing.nyroc.rr.com (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id vAAEheGR015853 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 10 Nov 2017 09:43:46 -0500 From: Ken Brown To: cygwin-apps@cygwin.com Subject: [PATCH setup 0/5] Improve behavior after download error, v2 Date: Fri, 10 Nov 2017 14:43:00 -0000 Message-Id: <20171110144339.12616-1-kbrown@cornell.edu> X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00038.txt.bz2 Currently setup goes back to the mirror selection page after a download error if the user answers "Yes" to "Download incomplete. Try again?". The same happens in unattended mode until the retries have been exhausted. And if the user answers "No", then installation continues, even though this can damage the user's installation. For example, if a package is selected for reinstall but cannot be downloaded, it will be uninstalled. This series of patches changes the behavior as follows: - In unattended mode, simply retry the download. - In interactive mode, pop up a dialog showing which packages had download errors and giving the user the following options: - Retry (retries download) - Back (return to the package selection page) - Continue, with a warning - Cancel (exit) Ken Brown (5): Just retry download after error in unattended mode Fix off-by-one error in download retry report Remove "Try again?" from exit message. Query user after download error in interactive mode Limit the number of packages shown in the IDD_DOWNLOAD_ERROR listbox download.cc | 99 ++++++++++++++++++++++++++++++++++++++++++++++++++++--------- res.rc | 23 ++++++++++++++ resource.h | 3 ++ 3 files changed, 111 insertions(+), 14 deletions(-) -- 2.15.0