From: Corinna Vinschen <corinna-cygwin@cygwin.com>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH 2/2] Fix some errors which cause unnecessary rebases
Date: Fri, 09 Feb 2018 19:52:00 -0000 [thread overview]
Message-ID: <20180209195200.GV30794@calimero.vinschen.de> (raw)
In-Reply-To: <20180209115941.512448-3-jon.turney@dronecode.org.uk>
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
On Feb 9 11:59, Jon Turney wrote:
> Also add some parentheses for clarity
I'm not a friend of excessive bracketing, especially when the evaluation
order is unambiguous. This also covers what this patch is *really* meant
to fix, so I'd prefer a patch with only the fix.
Thanks,
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Maintainer cygwin AT cygwin DOT com
Red Hat
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-09 19:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 12:00 [PATCH rebase 0/2] Avoid unncessary rebases Jon Turney
2018-02-09 12:01 ` [PATCH 1/2] Make verbose give a reason why a rebase is needed Jon Turney
2018-02-09 20:02 ` Corinna Vinschen
2018-02-09 12:01 ` [PATCH 2/2] Fix some errors which cause unnecessary rebases Jon Turney
2018-02-09 19:52 ` Corinna Vinschen [this message]
2018-02-13 12:48 ` [PATCH rebase 0/2] Avoid unncessary rebases Jon Turney
2018-02-13 18:32 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180209195200.GV30794@calimero.vinschen.de \
--to=corinna-cygwin@cygwin.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).