From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7446 invoked by alias); 9 Feb 2018 19:52:05 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 7037 invoked by uid 89); 9 Feb 2018 19:52:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-101.8 required=5.0 tests=AWL,BAYES_00,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=friend X-HELO: drew.franken.de Received: from mail-n.franken.de (HELO drew.franken.de) (193.175.24.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Feb 2018 19:52:03 +0000 Received: from aqua.hirmke.de (aquarius.franken.de [193.175.24.89]) (Authenticated sender: aquarius) by mail-n.franken.de (Postfix) with ESMTPSA id EEC47721E281A for ; Fri, 9 Feb 2018 20:52:00 +0100 (CET) Received: from calimero.vinschen.de (calimero.vinschen.de [192.168.129.6]) by aqua.hirmke.de (Postfix) with ESMTP id 92D805E01A4 for ; Fri, 9 Feb 2018 20:52:00 +0100 (CET) Received: by calimero.vinschen.de (Postfix, from userid 500) id 7DC5DA80865; Fri, 9 Feb 2018 20:52:00 +0100 (CET) Date: Fri, 09 Feb 2018 19:52:00 -0000 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: [PATCH 2/2] Fix some errors which cause unnecessary rebases Message-ID: <20180209195200.GV30794@calimero.vinschen.de> Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <20180209115941.512448-1-jon.turney@dronecode.org.uk> <20180209115941.512448-3-jon.turney@dronecode.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/Ocr+Jy+jPJR1APa" Content-Disposition: inline In-Reply-To: <20180209115941.512448-3-jon.turney@dronecode.org.uk> User-Agent: Mutt/1.9.1 (2017-09-22) X-SW-Source: 2018-02/txt/msg00020.txt.bz2 --/Ocr+Jy+jPJR1APa Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 437 On Feb 9 11:59, Jon Turney wrote: > Also add some parentheses for clarity I'm not a friend of excessive bracketing, especially when the evaluation order is unambiguous. This also covers what this patch is *really* meant to fix, so I'd prefer a patch with only the fix. Thanks, Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --/Ocr+Jy+jPJR1APa Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlp9++AACgkQ9TYGna5E T6CBLxAAnfLo4qLm8tWWbto/P9MgGsYrfuLIbQVrPbWKY66lm3ZtsGyvIxzEGkGU FBL0S5IuOY7PgR436CiTNXDb4QGxtjElvAANVX1RKmPCz/KUzqwXwXB2Xj8lybJs +SrIqMu3jQrIox/M3MpY2hyfeGswFEMMMVduEANi+nue6Bc2sCKx978B+PUvldBi zfEBF10kROZSeYS7B5x06w5miX9xQhL+mkOSTNFUC9smmQu6pto7XKljEVRdZCR6 x09llD8cCmzhhWsYYqLJaC3Dp/jrFCeE3GSbOLL2HDe5+ggFDzNCASwEw3FFCLKY sGnGJGP1A1aCZwD+kl8Pka13ztK0jhSDbco7skvdQfgH0NvaB6DFYV43FptXM5B2 51ByeQc2GCuIjXkcQ8VOzaveuN2JKlMOO5Qf4hotnMUM7E32NSXtfkMBzH5GSapt MMEFtUcPciJcZmO40Nbkb97BCnYO7fFST6prWHXyWlKY0Q4MMPMMRlh7L8OavYHN vie8e0fRgSb+MAPi381KFxwZ/IArqMUNHutkvNTOidsBu0QKBZp1FPPTTp9JJK0S iNPexBt2jeJl+SXpz89cqq/uvjp68iBMXI3b0fZg+Vc6phBbnPMXlpj4KKAe9Roy IUKKFWjCKHxuwcr29c122lMUp26slQLwkJFGwsxRwZT2zGObXms= =fqgc -----END PGP SIGNATURE----- --/Ocr+Jy+jPJR1APa--