From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106862 invoked by alias); 9 Feb 2018 20:02:25 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 105092 invoked by uid 89); 9 Feb 2018 20:02:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-124.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,GOOD_FROM_CORINNA_CYGWIN,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: drew.franken.de Received: from mail-n.franken.de (HELO drew.franken.de) (193.175.24.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Feb 2018 20:02:23 +0000 Received: from aqua.hirmke.de (aquarius.franken.de [193.175.24.89]) (Authenticated sender: aquarius) by mail-n.franken.de (Postfix) with ESMTPSA id DF234721E281A for ; Fri, 9 Feb 2018 21:02:20 +0100 (CET) Received: from calimero.vinschen.de (calimero.vinschen.de [192.168.129.6]) by aqua.hirmke.de (Postfix) with ESMTP id 95B185E01A4 for ; Fri, 9 Feb 2018 21:02:20 +0100 (CET) Received: by calimero.vinschen.de (Postfix, from userid 500) id 80805A80865; Fri, 9 Feb 2018 21:02:20 +0100 (CET) Date: Fri, 09 Feb 2018 20:02:00 -0000 From: Corinna Vinschen To: cygwin-apps@cygwin.com Subject: Re: [PATCH 1/2] Make verbose give a reason why a rebase is needed Message-ID: <20180209200220.GW30794@calimero.vinschen.de> Reply-To: cygwin-apps@cygwin.com Mail-Followup-To: cygwin-apps@cygwin.com References: <20180209115941.512448-1-jon.turney@dronecode.org.uk> <20180209115941.512448-2-jon.turney@dronecode.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e7jIye1Ygp5H0AIi" Content-Disposition: inline In-Reply-To: <20180209115941.512448-2-jon.turney@dronecode.org.uk> User-Agent: Mutt/1.9.1 (2017-09-22) X-SW-Source: 2018-02/txt/msg00021.txt.bz2 --e7jIye1Ygp5H0AIi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1463 On Feb 9 11:59, Jon Turney wrote: > --- > rebase.c | 47 ++++++++++++++++++++++++++++++++++++++++------- > 1 file changed, 40 insertions(+), 7 deletions(-) >=20 > diff --git a/rebase.c b/rebase.c > index 6f98d37..0aad1b2 100644 > --- a/rebase.c > +++ b/rebase.c > @@ -649,7 +649,16 @@ merge_image_info () > { > /* Reuse the old address if possible. */ > if (match->slot_size < img_info_list[i].slot_size) > - match->base =3D 0; > + { > + if (verbose) > + fprintf (stderr, "rebasing %s because it won't fit in it's old= slot size\n", img_info_list[i].name); > + match->base =3D 0; > + } > + else > + { > + if (verbose) This would ideally be an=20 else if (verbose) fprintf (); > - img_info_list[i].base =3D 0; > + { > + /* Not in database yet. Set base to 0 to choose a new one. */ > + img_info_list[i].base =3D 0; > + if (verbose) > + fprintf (stderr, "rebasing %s because not in database yet\n", img_info= _list[i].name); In the "reuse old address" case you have if (verbose) printf set var =3D 0 here and in later cases you have set var =3D 0; if (verbose) printf I'd prefer to have these in the same order. With this minor tweak patch is ok. Thanks, Corinna --=20 Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat --e7jIye1Ygp5H0AIi Content-Type: application/pgp-signature; name="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoVYPmneWZnwT6kwF9TYGna5ET6AFAlp9/kwACgkQ9TYGna5E T6DNeQ//WJ8sAgVadBY4roRBnm5S0a66wK1fXjw5ICwa6HSxHN2JRTJYWfUSoL0P mO1cUbS46avQJfzf3SEJFPBhU8oY6/r2VkAVgpiC5J0nx3OdQj6/11bPshcBRA1r BCJnTVogBE5T0BFpMwYwyc3pq9PT1GEk+k66JJ1oH7+CYv8Y2eb7EcB32BmIcf8z q+c/rstzrpCfrtVXUIOUPy4alfhmtAXsbV4GI0Bk1J2kgt/d5/MECkdRNU0fDp5i GDauHkw//MKHtnns2qu1Qi/7RrYW+02jzJLW2mpwAv9WisE8/ezbCzxMr36cXm1s Tb0nP99VtHa+82X+3lusjKd9WyUxAafPN5P5BOD5SeYuE30wyduE2kR4WQBjOQ9Q /BMN4fE8ojnlmyOi61f8ZwnwLXMtpaLI2FgYOCR7p8lgXsGXGGZmxjENoWbF4Unc mUpSZJmQC15TuvVXKWYss3b8VinFtwTvG5cBglMeMuFXdpGjUicFrjofRDYHpNqJ cB1PjFgLcMv78w/SQGl59OPnC0qG8N0DoCjncFwVzV/XQgETrj0axTereK4PojM/ B2dTKaYTptrdYShoHylZs7Q+EMwnLDTjwOkmlTCI6NnvWKleBt8445mOA0tqi0Hx uPMSinJ3O1bNcNjUW0OTfsqH/TUQzQESPOPDYvN6Q7ACNlSxi1A= =o3yz -----END PGP SIGNATURE----- --e7jIye1Ygp5H0AIi--