From: Lemures Lemniscati <lemures.lemniscati@gmail.com>
To: cygwin-apps@cygwin.com
Subject: Re: [ITA] libjpeg-turbo-2.0.6
Date: Mon, 14 Dec 2020 07:00:37 +0900 [thread overview]
Message-ID: <20201214070034.E4C6.50F79699@gmail.com> (raw)
In-Reply-To: <25b65e9d-0802-6029-22b8-821aa534a4e3@gmail.com>
On Sun, 13 Dec 2020 15:32:23 +0100, Marco Atzeri via Cygwin-apps
> On 13.12.2020 06:58, Lemures Lemniscati via Cygwin-apps wrote:
> > Hi!
> >
> > ITA for libjpeg-turbo, which have been maintained by Yaakov [1].
> >
> > Now, the latest stable upstream version of libjpeg-turbo is 2.0.6 [2].
> >
> > A new candidate cygport file is placed at [3] (but it is not tested
> > on Cygwin AppVeyor CI, yet).
> >
> > Generated package files are placed at [4] and [5]:
> >
> it builds fine, but I would add a test section
> at least as simple as
>
> $ ./tjunittest.exe
> RGB Top-Down -> 4:4:4 Q100 ... Done.
> Result in test_enc_RGB_TD_444_Q100.jpg
> JPEG -> RGB Top-Down 2/1 ... Passed.
> JPEG -> RGB Top-Down 15/8 ... Passed.
> JPEG -> RGB Top-Down 7/4 ... Passed.
> ...
> JPEG -> ARGB Bottom-Up 3/8 ... Passed.
> JPEG -> ARGB Bottom-Up 1/4 ... Passed.
> JPEG -> ARGB Bottom-Up 1/8 ... Passed.
>
> --------------------
>
> Buffer size regression test
> Done.
>
> > Regards,
> >
> > Lem
>
> Changed maintainer, so when you want you can upload.
>
> Thanks and Regards
> Marco
>
Thank you for reviewing, Marco.
Now, I've added a test section as follows:
========
src_test() {
cd ${B}
ctest
}
========
And, I guess it would be useful if we add the following code
to usr/share/cygport/cygclass/cmake.cygclass .
(But this subject should be in another mail, later.)
=======
cygctest() {
if (( ${#@} > 0 )); then
ctest "$@"
elif [ -f CTestTestfile.cmake ]; then
ctest
else
inform "cygctest: No testsuite detected."
fi
}
readonly -f cygctest
src_test() {
cd ${B}
cygctest
}
=======
Regards,
Lem
prev parent reply other threads:[~2020-12-13 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 5:58 Lemures Lemniscati
2020-12-13 14:32 ` Marco Atzeri
2020-12-13 22:00 ` Lemures Lemniscati [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214070034.E4C6.50F79699@gmail.com \
--to=lemures.lemniscati@gmail.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).