From: Lemures Lemniscati <lemures.lemniscati@gmail.com>
To: cygwin-apps@cygwin.com
Subject: Re: cmake-3.19.2-1 and related packages
Date: Sun, 28 Mar 2021 09:12:22 +0900 [thread overview]
Message-ID: <20210328091220.DE52.50F79699@gmail.com> (raw)
In-Reply-To: <872e9498-67be-276a-5931-61a605dd2956@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
On Sat, 27 Mar 2021 16:58:48 +0100, Marco Atzeri
> I used your cygport as base for 3.20.0-1, plus an additional patch
> https://sourceware.org/pipermail/cygwin-patches/2021q1/011303.html
I've found another confusion between _WIN32 and __CYGWIN__ in 3.20.0 [1].
[1]: https://gitlab.kitware.com/cmake/cmake/-/blob/v3.20.0/Source/kwsys/SystemTools.cxx#L3930-3961
A patch attached will resolve it.
Regards,
Lem
[-- Attachment #2: 3.20.0-kwsys-SystemTools.patch --]
[-- Type: application/octet-stream, Size: 371 bytes --]
--- origsrc/cmake-3.20.0/Source/kwsys/SystemTools.cxx
+++ src/cmake-3.20.0/Source/kwsys/SystemTools.cxx
@@ -3929,7 +3929,7 @@
bool SystemToolsStatic::FileIsFullPath(const char* in_name, size_t len)
{
-#if defined(_WIN32) || defined(__CYGWIN__)
+#if defined(_WIN32)
// On Windows, the name must be at least two characters long.
if (len < 2) {
return false;
next prev parent reply other threads:[~2021-03-28 0:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 20:14 [ITA] cmake-3.18.0-1 " Lemures Lemniscati
2020-07-17 21:13 ` Marco Atzeri
2020-07-18 1:00 ` Lemures Lemniscati
2020-07-18 6:12 ` Achim Gratz
2020-07-18 6:29 ` Marco Atzeri
2020-07-18 7:01 ` Achim Gratz
2020-07-18 8:13 ` Achim Gratz
2020-07-18 10:09 ` Lemures Lemniscati
2020-08-07 16:06 ` cmake upstream has merged cygwin patches Lemures Lemniscati
2020-08-07 19:51 ` Marco Atzeri
2020-08-08 0:47 ` Lemures Lemniscati
2020-08-10 8:17 ` Marco Atzeri
2020-08-10 13:12 ` Lemures Lemniscati
2020-11-19 22:45 ` cmake-3.19.0-1 and related packages Lemures Lemniscati
2020-11-25 22:11 ` cmake-3.19.1-1 " Lemures Lemniscati
2020-12-17 21:30 ` cmake-3.19.2-1 " Lemures Lemniscati
2021-03-27 15:58 ` Marco Atzeri
2021-03-27 22:02 ` Lemures Lemniscati
2021-03-28 2:45 ` Lemures Lemniscati
2021-03-28 7:00 ` Marco Atzeri
2021-03-28 0:12 ` Lemures Lemniscati [this message]
2021-03-28 7:02 ` Marco Atzeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210328091220.DE52.50F79699@gmail.com \
--to=lemures.lemniscati@gmail.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).