From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-043.btinternet.com (mailomta14-re.btinternet.com [213.120.69.107]) by sourceware.org (Postfix) with ESMTPS id 4AF5D385DC06 for ; Tue, 1 Feb 2022 17:26:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AF5D385DC06 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from re-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.54.5]) by re-prd-fep-043.btinternet.com with ESMTP id <20220201172606.XAAX14987.re-prd-fep-043.btinternet.com@re-prd-rgout-002.btmx-prd.synchronoss.net>; Tue, 1 Feb 2022 17:26:06 +0000 Authentication-Results: btinternet.com; none X-SNCR-Rigid: 613A8DE812D6C0E3 X-Originating-IP: [213.120.30.10] X-OWM-Source-IP: 213.120.30.10 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvvddrgeefgddutddtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuueftkffvkffujffvgffngfevqffopdfqfgfvnecuuegrihhlohhuthemuceftddunecunecujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpedtheevuefhgfegtdfhueekjeehfeekfefhvdduveejhfelhfelhedvjeekudfgtdenucffohhmrghinhepshhouhhrtggvfigrrhgvrdhorhhgnecukfhppedvudefrdduvddtrdeftddruddtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplhhotggrlhhhohhsthdrlhhotggrlhguohhmrghinhdpihhnvghtpedvudefrdduvddtrdeftddruddtpdhmrghilhhfrhhomhepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdpnhgspghrtghpthhtohepvddprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomhdprhgtphhtthhopehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhk X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from localhost.localdomain (213.120.30.10) by re-prd-rgout-002.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 613A8DE812D6C0E3; Tue, 1 Feb 2022 17:26:06 +0000 From: Jon Turney To: cygwin-apps@cygwin.com Cc: Jon Turney Subject: [PATCH cygport 2/2] Don't use llvm-objdump Date: Tue, 1 Feb 2022 17:25:19 +0000 Message-Id: <20220201172519.14881-3-jon.turney@dronecode.org.uk> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220201172519.14881-1-jon.turney@dronecode.org.uk> References: <20220201172519.14881-1-jon.turney@dronecode.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3578.1 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Feb 2022 17:26:08 -0000 This partially reverts commit e06359bca705624b9712fd16f4ec9945935fd608 This partially reverts commit 6f788165848084d2fb1597689b31faba7d4c483e The polynomially bad runtime of 'objdump' (which made 'llvm-objdump' the only practically usable tool on larger binaries) has been fixed since [1]. Meanwhile, 'llvm-objdump' now appears to have bugs which interfere with the correct operation of cygport. [1] https://sourceware.org/bugzilla/show_bug.cgi?id=18025#c16 --- lib/pkg_info.cygpart | 8 -------- lib/src_postinst.cygpart | 7 +------ 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/lib/pkg_info.cygpart b/lib/pkg_info.cygpart index 4b18993..08ddd69 100644 --- a/lib/pkg_info.cygpart +++ b/lib/pkg_info.cygpart @@ -95,14 +95,6 @@ __list_deps() { dlltool="${CTARGET}-dlltool" fi - case ${CHOST} in - i?86-*|x86_64-*) - if check_prog llvm-objdump - then - objdump="llvm-objdump" - fi ;; - esac - pushd ${D} #****v* Information/DEPS_PATH diff --git a/lib/src_postinst.cygpart b/lib/src_postinst.cygpart index e29b2cb..4b51325 100644 --- a/lib/src_postinst.cygpart +++ b/lib/src_postinst.cygpart @@ -951,12 +951,7 @@ __prepstrip() { continue fi - if check_prog llvm-objdump && llvm-size "${exe}" &>/dev/null - then - objdump="llvm-objdump" - else - objdump=${objcopy/copy/dump} - fi + objdump=${objcopy/copy/dump} # Static libraries should not be fully stripped, but we can # still provide split debuginfo if desired -- 2.34.1