From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <adam@dinwoodie.org>
Received: from lucy.dinwoodie.org
 (b.8.0.0.8.9.b.0.2.f.0.9.2.a.d.b.d.a.0.2.5.1.e.d.0.b.8.0.1.0.0.2.ip6.arpa
 [IPv6:2001:8b0:de15:20ad:bda2:90f2:b98:8b])
 by sourceware.org (Postfix) with ESMTPS id DD4783858C27
 for <cygwin-apps@cygwin.com>; Sun, 13 Mar 2022 20:31:25 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DD4783858C27
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=dinwoodie.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dinwoodie.org
Received: from adam by lucy.dinwoodie.org with local (Exim 4.94.2)
 (envelope-from <adam@dinwoodie.org>) id 1nTUs7-0038dc-Kf
 for cygwin-apps@cygwin.com; Sun, 13 Mar 2022 20:31:23 +0000
Date: Sun, 13 Mar 2022 20:31:23 +0000
From: Adam Dinwoodie <adam@dinwoodie.org>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH cygport] autotools.cygclass: correctly detect Autoconf
 2.70+
Message-ID: <20220313203123.2g5uimv76n7rm3en@lucy.dinwoodie.org>
References: <20220311090520.5ztk6ybc6fv7oyvd@lucy.dinwoodie.org>
 <20220311224005.12377-1-adam@dinwoodie.org>
 <70a9c487-e302-5342-61ce-5b917d089ec6@dronecode.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <70a9c487-e302-5342-61ce-5b917d089ec6@dronecode.org.uk>
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RDNS_DYNAMIC, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: cygwin-apps@cygwin.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Cygwin package maintainer discussion list <cygwin-apps.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin-apps>,
 <mailto:cygwin-apps-request@cygwin.com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin-apps/>
List-Post: <mailto:cygwin-apps@cygwin.com>
List-Help: <mailto:cygwin-apps-request@cygwin.com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin-apps>,
 <mailto:cygwin-apps-request@cygwin.com?subject=subscribe>
X-List-Received-Date: Sun, 13 Mar 2022 20:31:30 -0000

On Sat, Mar 12, 2022 at 01:02:39PM +0000, Jon Turney wrote:
> On 11/03/2022 22:40, Adam Dinwoodie wrote:
> > -	case "x${confver}" in
> > -		x2.6[0-9]*)
> > -			confargs+=" --docdir=/usr/share/doc/${PN} --htmldir=/usr/share/doc/${PN}/html"
> > -			;;
> > -		*)
> > -			confargs+=" --infodir=${prefix}/share/info --mandir=${prefix}/share/man"
> > -			;;
> > -	esac
> > +	if [ $confver_maj -ge 2 -a $confver_min -ge 60 ] || [ $confver_maj -ge 3 ]
> 
> Great. Thanks.
> 
> I think it would be acceptable to error on autoconf >=3.0, rather than
> assuming it's going to be autoconf 2.6+ compatible.

No problem, I'll respin now.  I'd thought about doing exactly that, but
the current code looked like it was designed to assume things would be
fine unless there was a specific reason to bail out, so I tried to
follow that paradigm rather than bail out when there was no known reason
for doing so.