From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id AAFC638560A0 for ; Mon, 30 May 2022 03:30:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AAFC638560A0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x536.google.com with SMTP id 137so9031471pgb.5 for ; Sun, 29 May 2022 20:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:in-reply-to:references:message-id:mime-version :content-transfer-encoding; bh=zoMpkVsbYsh6T3OqQ5jwFQtXDHy6nwgp7ecSmPxeWcU=; b=lsD4BeMAMhjH4g3j95y21Z9YJ7l7ISl/aNsKwTFoWHJdGP6SW6x4I/B7h7kmZUxQ4i U9gSQov/rbn8/K1w6a8VyOdmzlK3el28ZrS+0TqqViKSZIEzjYweQ2dkebEF+pT1jASG fZZ+viUflQFWbxngLhUJxWjEdV32KxF8JwQ8rXhWJ6U1mAxv4Z/H1ImXsjrXH48CfWUi OsD6cGr9J2KtWTm2zevD3RU2e4daECkj6DK6J4CXzVQ9ddS624SGE/fpYvf455PEyiUE sQhRwiH0yni6tXnblbD2Sp24ruqQSftJCaO2eCaVJF8wNeLJhcKLhFc3KcNCSZivX/XO Wd4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:in-reply-to:references :message-id:mime-version:content-transfer-encoding; bh=zoMpkVsbYsh6T3OqQ5jwFQtXDHy6nwgp7ecSmPxeWcU=; b=bPTn3JFxQkZBdgzKIdXFP6uW2+NaYAov9bWw/VI/YFT0c4FDQzjp0B07Shk625SoO5 eQoQSUY2dqRYyjXoVlNRTRbDKGYtO9UoucPJcCBkT0265WVuELdMQBdiG9DRK/uEOQPs QKXkFUzZ14LWXmG6QKPiTE7rTWebkwOutJaXu1rRQdPFIRt6xxZLy4W5FA3nnRZg0J8e RkV8lq0QexVjaxirs6EBjONAl1wQl/Ngy9i49xJbvF4UapKvQnE8FynIAlqLBoUwK0e6 HmMk5nwMHR/723N1CMGqHNb5KMej2eVIYDgPS5B4PYov+OauyuFfd9TWGj5hFn+mLmV3 JauA== X-Gm-Message-State: AOAM533noRLk8Edk44vfoX1VrQD+fJyykGbjxQMgty51DTbZ4ci2/xb8 TPljWQDxJPRwybQ11TXvnRic+xrWc60= X-Google-Smtp-Source: ABdhPJzDA354WiQR2PkpmI/Rxd6DxW+Im4sZpwpu2VMG2EkdLJq7fWPRgeLUOLkaYwoICswhZkWazw== X-Received: by 2002:a63:10a:0:b0:3fb:882b:db59 with SMTP id 10-20020a63010a000000b003fb882bdb59mr14683185pgb.427.1653881410121; Sun, 29 May 2022 20:30:10 -0700 (PDT) Received: from [192.168.3.3] ([2400:2411:aa20:4300:c942:172e:314f:ace1]) by smtp.gmail.com with ESMTPSA id bx20-20020a056a00429400b0050dc76281bdsm7553468pfb.151.2022.05.29.20.30.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 May 2022 20:30:09 -0700 (PDT) Date: Mon, 30 May 2022 12:30:08 +0900 From: Lemures Lemniscati To: cygwin-apps@cygwin.com Subject: Re: [ITA] giflib In-Reply-To: <63bea768-4503-3a7f-813c-545036d2ce32@dronecode.org.uk> References: <20220529204549.D6BB.50F79699@gmail.com> <63bea768-4503-3a7f-813c-545036d2ce32@dronecode.org.uk> Message-Id: <20220530123005.5DEB.50F79699@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Mailer: Becky! ver. 2.75.04 [ja] X-Antivirus: Avast (VPS 220529-2, 2022/5/29), Outbound message X-Antivirus-Status: Clean X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2022 03:30:13 -0000 On Sun, 29 May 2022 17:12:03 +0100, Jon Turney > On 29/05/2022 12:45, Lemures Lemniscati wrote: > > ITA for giflib, which has been maintained by Yaakov [1]. > > Thanks. I added this to your authorized packages. Thank you! > Small comments on the .cygport: > > > # Patch files whose names are in a default style of 'git format-patch' > > PATCH_URI+=$(\ > > find -maxdepth 1 -type f -name '[0-9][0-9][0-9][0-9]-*.patch' \ > > | sort \ > > ) > > Hmm... there's probably a case to be made that this is something that cygport should be doing automatically. > > It would certainly help with noticing when patches are removed from PATCH_URI but not from the source package repo... This is an adhoc code. I'm apt to be lazy to edit PATCH_URI for locally prepared patches... :). In this case, I locally prepared patches because I didn't know how to get the patches from the upstream URIs. > > BUILD_REQUIRES="\ > > cmake\ > > ninja\ > > " > > I don't think these need to be listed because they are implied by the respective inherits. > > Certainly, if things are working as intended, scallywag can infer that. I confirmed that it works without BUILD_REQUIRES (https://cygwin.com/cgi-bin2/jobs.cgi?id=4261). I'll remove it. Thank you. Lem