From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id BF5CE3856279 for ; Tue, 28 Jun 2022 17:41:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BF5CE3856279 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dinwoodie.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dinwoodie.org Received: by mail-wm1-x32d.google.com with SMTP id bi22-20020a05600c3d9600b003a04de22ab6so3121976wmb.1 for ; Tue, 28 Jun 2022 10:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dinwoodie.org; s=google; h=date:from:to:subject:message-id:reply-to:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=DjQ9CryrbGaUKmpoG5RHpU/JY23jCEyF2GrlOctesTw=; b=dGLbtk0KDAwloN8pyG+0iztMyDVeYeA/gD4JtxXZd/bHn9ArUku7hJlqgbMgKL6n/Q D1kJJPD6wW663nnoXNuZ4beeCxzGIesqQ+ChEutjbLUAdUauDhXUMFO87nA504q7u4FV M3T189xugHiycX0EP9XrJJv8gDUyYjhOClAYA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:reply-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=DjQ9CryrbGaUKmpoG5RHpU/JY23jCEyF2GrlOctesTw=; b=mewOfb6/JbmMjm2z9tGckQCzSbOdbIFCJ26PDA80RU0LjDFYF65HSgP21xsji3SKFQ 9l+soP/2jrdBQGKhvRpCTh7zPV0VELCQcWkuPLxTSeLX8bBMqfQF/BY2KN+oDNKdEtxs cjN2ADoDK16/r/Tr+BYV07sRRhaQuc041nYe4wiuCs0o/pZ429ObhOJ7ViyN3CxxbyJ4 a4m/oTJhByusy/4hy26hR3akHP0sQmQhPmB54BFWmnzOPo57k4JlReBHmwIlQM0ZMkUk vuhp6ADAPimlJB7s5Gos0k494cCJzmPPzsPLWARN1TlUvxZI6CqRZS9vEwVYcbO+F7vD uGbw== X-Gm-Message-State: AJIora+EtF2uNvzzgGX72tZnL4AlnbyazfpPCgNqTmrVsWiSReyMTe98 7pVL0bPjq+92RSfewUfr6uQt9z7drsdhbg== X-Google-Smtp-Source: AGRyM1vXlOtQpJAxu9Es1vEYCdGZkGTazw96OikimDF56Jn2M4JebUpLbSu2hL7kpdfqKP7p7+zMUA== X-Received: by 2002:a05:600c:4e49:b0:3a0:4c17:c67f with SMTP id e9-20020a05600c4e4900b003a04c17c67fmr867056wmq.1.1656438084355; Tue, 28 Jun 2022 10:41:24 -0700 (PDT) Received: from lucy.dinwoodie.org (b.8.0.0.8.9.b.0.2.f.0.9.2.a.d.b.d.a.0.2.5.1.e.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:de15:20ad:bda2:90f2:b98:8b]) by smtp.gmail.com with ESMTPSA id e12-20020a5d530c000000b002185d79dc7fsm14309338wrv.75.2022.06.28.10.41.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jun 2022 10:41:23 -0700 (PDT) Received: from adam by lucy.dinwoodie.org with local (Exim 4.94.2) (envelope-from ) id 1o6FDG-00D9q6-Ck for cygwin-apps@cygwin.com; Tue, 28 Jun 2022 18:41:22 +0100 Date: Tue, 28 Jun 2022 18:41:22 +0100 From: Adam Dinwoodie To: cygwin-apps@cygwin.com Subject: Re: [ITP] etckeeper 1.18.17-1 Message-ID: <20220628174122.arrqtskqzt6gzhxc@lucy.dinwoodie.org> Reply-To: cygwin-apps@cygwin.com References: <36cc4e85-d20c-0f52-214d-88262f704efa@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <36cc4e85-d20c-0f52-214d-88262f704efa@t-online.de> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 17:41:30 -0000 On Tue, Jun 28, 2022 at 12:58:23PM +0200, Christian Franke wrote: > I would like to contribute etckeeper. > > https://etckeeper.branchable.com/ > https://repology.org/project/etckeeper/versions > > etckeeper-1.18.17-1.hint: > category: Utils > requires: bash coreutils grep sed > sdesc: "Store /etc in git or mercurial" > ldesc: "Etckeeper is a tool to let /etc be stored in git or > mercurial.  It hooks into Cygwin Setup to automatically commit changes > made to /etc during package upgrades.  It tracks file metadata > (permissions, owner, group) that version control systems do not > normally support." > > Package for review: > wget -r -nH --cut-dirs=2 \ > https://chrfranke.de/cygwin/noarch/etckeeper/etckeeper-1.18.17-1.hint \ > https://chrfranke.de/cygwin/noarch/etckeeper/etckeeper-1.18.17-1-src.hint \ > https://chrfranke.de/cygwin/noarch/etckeeper/etckeeper-1.18.17-1-src.tar.xz > \ > https://chrfranke.de/cygwin/noarch/etckeeper/etckeeper-1.18.17-1.tar.xz \ > https://chrfranke.de/cygwin/noarch/etckeeper/etckeeper-1.18.17-1.sha256 > > Tested with git. Only a few tests were done with hg. LGTM! I've not tested the actual function, but the packaging looks sound, and I trust etckeeper enough that if the packaging is sound I'm happy the rest will follow :) I do wonder if it's worth trying to submit your patches upstream; they seem like the sort of thing the upstream project might be interested in taking, and it minimises the amount of work you have to do as a maintainer. I'm also vaguely pondering whether it's worth adding git as a dependency. That's not strictly right, since etckeeper doesn't *need* git, but it's going to be the use case for 99.9% of users, and in the absence of Cygwin having a "recommends" style dependency, just adding git seems like it might be sensible. But I'm far from convinced there. Adam