From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 7B20A385AE5D for ; Wed, 29 Jun 2022 08:12:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7B20A385AE5D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dinwoodie.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dinwoodie.org Received: by mail-wr1-x431.google.com with SMTP id o16so21218208wra.4 for ; Wed, 29 Jun 2022 01:12:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dinwoodie.org; s=google; h=date:from:to:subject:message-id:reply-to:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=x8EC3faUiPSsNTrl7OdLAsJsHDaVv6YW4RJwAoZVsr4=; b=lzcqFcsLr64uIuiVRJrTqWrOQeUv3Hd/isEV6T/O1MkSYrxiyO4lmd6I5SJnv2tc/d fALRX887pzkw6bQv0CnMxSl7LbIuUWI4HTrRqCs0ud3wTxUEbphLiC4Y8Qp5dEY3L2jw wuitsphJCsMumJ3jKYCGWWgjOGZW8n1MNsrvg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:reply-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=x8EC3faUiPSsNTrl7OdLAsJsHDaVv6YW4RJwAoZVsr4=; b=YpXGpX26mCIWa1zxS5zFgoB6JiS3/U6QXXJ3cLT4z/k8aEGtzMmwVNWOo+3/E6NsDd tmSMg7sMoBPmNqd/1ia2Mdo/dc7Ym2KmzTVhUQBNx2A8RzjHy66gKH0SjApTMNXmpLuU c501byaov7TRNdqmPjKHCEvDbMGPwzR9y8rq3BaPa8AAb7RCqN3mzp9hlIKxDgWf+8s5 nnSgvxMNjTwYeqJ9mWmCqcydM+b/DLgFvWwZzlfmRziQZgN5nkgmcUYY1Eak3dFJuEvt 5DCCKrqvkbK4YmuI5IBceNmxNNVY3VFMQiIxEOR+1AFRFuziJJPe4aga1GmiSgdUNLOV 365g== X-Gm-Message-State: AJIora91iWqRrjgVoZ30YYiwWFBn0c5qiTppo1mTe8SHxZr63iNrk7KE t+bkopALydqimqvTZm929K4iPFv6G4SUhg== X-Google-Smtp-Source: AGRyM1vLk68ViftYtIZvKOMMKHkSxdAGvUQy1DNPL5e8bc6rrwOA5XED1qfEKvsBK904kHWBMyP/xg== X-Received: by 2002:adf:fd88:0:b0:21a:a547:38b3 with SMTP id d8-20020adffd88000000b0021aa54738b3mr1845338wrr.431.1656490337119; Wed, 29 Jun 2022 01:12:17 -0700 (PDT) Received: from lucy.dinwoodie.org (b.8.0.0.8.9.b.0.2.f.0.9.2.a.d.b.d.a.0.2.5.1.e.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:de15:20ad:bda2:90f2:b98:8b]) by smtp.gmail.com with ESMTPSA id l40-20020a05600c1d2800b003a04962ad3esm2306842wms.31.2022.06.29.01.12.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 01:12:16 -0700 (PDT) Received: from adam by lucy.dinwoodie.org with local (Exim 4.94.2) (envelope-from ) id 1o6So2-00DjdJ-Tv for cygwin-apps@cygwin.com; Wed, 29 Jun 2022 09:12:15 +0100 Date: Wed, 29 Jun 2022 09:12:14 +0100 From: Adam Dinwoodie To: cygwin-apps@cygwin.com Subject: Re: [ITP] etckeeper 1.18.17-1 Message-ID: <20220629081214.zdphk3m744nfftkv@lucy.dinwoodie.org> Reply-To: cygwin-apps@cygwin.com References: <36cc4e85-d20c-0f52-214d-88262f704efa@t-online.de> <20220628174122.arrqtskqzt6gzhxc@lucy.dinwoodie.org> <11b99205-0b36-a700-5a07-0ed35b3df641@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 08:12:20 -0000 On Wed, Jun 29, 2022 at 09:55:10AM +0200, Christian Franke wrote: > Christian Franke wrote: > > Adam Dinwoodie wrote: > > ... > > > > > I'm also vaguely pondering whether it's worth adding git as a > > > dependency.  That's not strictly right, since etckeeper doesn't *need* > > > git, but it's going to be the use case for 99.9% of users, and in the > > > absence of Cygwin having a "recommends" style dependency, just adding > > > git seems like it might be sensible.  But I'm far from convinced there. > > > > I'm also not sure and decided to add no git dependency. 99.8% of the > > users considering to install etckeeper may already have git installed > > :-) > > > > The Debian package does not use "rec" but "dep (git or hg or brz or > > darcs)" which defaults to git. > > If git is installed, the Debian postinst script runs 'etckeeper init && > > etckeeper commit' on fresh installs. I decided to leave this to the > > user. > > > > A possible simple extension which would allow the user to choose between > manual or automatic installation+initialization: > > Provide an optional package, for example "etckeeper-git-init", which depends > on etckeeper+git and only contains /etc/postinstall/etckeeper-git-init.sh > which triggers new initialization code in > /etc/postinstall/zp_zzz_etckeeper-postinstall.sh via some file in > /var/cache/etckeeper. This code performs 'etckeeper init && etckeeper > commit' if and only if VCS=git is selected and /etc/.git does not exist. Honestly, I suspect it's not worth the effort of doing things like that. As you say, 99.8% of users who might be interested in using etckeeper are going to be people who already have a good idea what they're doing and will be able to work it out for themselves. Thinking about it some more, I'm also mildly concerned about the small but non-trivial proportion of users who blithely install every package available on Cygwin, which I don't think is going to be an issue for more-or-less any other *nix distribution. I don't normally think it's worth doing much to actively catering for those users -- I'm generally of the opinion that they're making their own misery -- but in this case automatically starting etckeeper would be a potentially significant impact, and for the sake of both their lives and yours, I suspect it's best to just leave etckeeper as something that requires manual initiation. That said, if you're keen to set up that optional package, I definitely don't think it's a bad idea; "it wouldn't be worth the effort to me" doesn't mean you shouldn't do it!