Re: [ITP] rsync 3.2.6

[Adam Dinwoodie <adam@dinwoodie.org>]

On Wed, Oct 05, 2022 at 09:29:08PM -0400, Chad Dougherty wrote:
> Hello all,
> 
> I've been using cygwin for a long time but this is my first attempt at this
> process so please be gentle :)
> 
> I noticed that the current rsync package (3.2.3+20200903+git9f9240b-4) is
> trailing on security updates and also still using the g-b-s method. I pinged
> the listed maintainer directly last week asking if they were planning to do
> any updates but have not heard back.  I hope this was not a faux pas as I
> didn't read until later that it's best to raise the issue on the list first.

Definitely a faux pas, but it's done now.  I definitely made my fair
share of errors of etiquette when I first tried packaging things, so I
don't think it's worth worrying too much over.

Jari isn't very active on the lists these days, but I think he is still
active, so he might want to weigh in.

> I've attempted to update the port here:
> https://github.com/crd477/cygports/tree/main/rsync
> 
> The package files were built by doing:
> cygport rsync.cygport prep compile test install package-test
> 
> cygport test reported the following:
> ...
> <snip>
> 
> Here is the reported feature comparison between the existing and updated
> packages.  This is one area where some things might need to be fixed with
> the update.
> Existing pacakge:
> $ rsync --version
> rsync  version 3.2.4dev  protocol version 31
> Copyright (C) 1996-2020 by Andrew Tridgell, Wayne Davison, and others.
> Web site: https://rsync.samba.org/
> Capabilities:
>     64-bit files, 64-bit inums, 64-bit timestamps, 64-bit long ints,
>     socketpairs, hardlinks, no hardlink-specials, symlinks, IPv6, atimes,
>     batchfiles, inplace, append, ACLs, xattrs, optional protect-args, iconv,
>     symtimes, prealloc, stop-at, no crtimes
> Optimizations:
>     no SIMD, asm, openssl-crypto
> Checksum list:
>     xxh128 xxh3 xxh64 (xxhash) md5 md4 none
> Compress list:
>     zstd lz4 zlibx zlib none
> 
> rsync comes with ABSOLUTELY NO WARRANTY.  This is free software, and you
> are welcome to redistribute it under certain conditions.  See the GNU
> General Public Licence for details.
> 
> Updated package:
> $ rsync --version
> rsync  version 3.2.6  protocol version 31
> Copyright (C) 1996-2022 by Andrew Tridgell, Wayne Davison, and others.
> Web site: https://rsync.samba.org/
> Capabilities:
>     64-bit files, 64-bit inums, 64-bit timestamps, 64-bit long ints,
>     socketpairs, symlinks, symtimes, hardlinks, no hardlink-specials,
>     hardlink-symlinks, IPv6, atimes, batchfiles, inplace, append, ACLs,
>     xattrs, optional secluded-args, no iconv, prealloc, stop-at, crtimes
> Optimizations:
>     no SIMD-roll, no asm-roll, openssl-crypto, no asm-MD5
> Checksum list:
>     xxh128 xxh3 xxh64 (xxhash) md5 md4 none
> Compress list:
>     zstd lz4 zlibx zlib none
> 
> rsync comes with ABSOLUTELY NO WARRANTY.  This is free software, and you
> are welcome to redistribute it under certain conditions.  See the GNU
> General Public Licence for details.

"no iconv" concerns me; I'm not desperately familiar with how iconv
works, but I believe that'll potentially cause issues for rsync users
who aren't using ASCII.  I'd guess the issue is your build environment
is missing a relevant build-time dependency, probably libiconv or
libiconv-devel.

Otherwise this looks good to my relatively inexpert eyes, and I'd
definitely be grateful for this package getting an update!  I think we
need to give Jari a chance to respond on-list, and see what the folks
who have actual authority around maintainership and non-maintainer
uploads say.

Adam