From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-04.nifty.com (conssluserg-04.nifty.com [210.131.2.83]) by sourceware.org (Postfix) with ESMTPS id 8E5403858C39 for ; Fri, 13 Jan 2023 14:22:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E5403858C39 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from HP-Z230 (aj135041.dynamic.ppp.asahi-net.or.jp [220.150.135.41]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 30DELgBG013268 for ; Fri, 13 Jan 2023 23:21:43 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 30DELgBG013268 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1673619703; bh=uyyBbiiT2GU4EeTIOFr7Y/h36vX3YeRPetnI3Ann/mA=; h=Date:From:To:Subject:In-Reply-To:References:From; b=mS154cFuCo12dte6wI+6Fdkq5cDJvSuj0885z2eIfcBCDXNn5sXAq0Wvez0pUe1DN Ipgj13VlyaIrRMHxNuiRTIabMos8RcmQObY1DxbuFQsis7Ok0xTuvX/aB+trLAAt+e V5/0k6Tov+TQvPyeTYYXsZ7AVOSad6JZkKYi92DFqeyyCRVKgUCSMs0D3M/wvpBqC7 SVlwWHEbW3MM/WF619OegrcbKRoEz9VrTx1YHlFOy5Pg0j55fyPEiyKKMWM2jPxIXc XociQKPyJHn9W7JzAqj5xht47p8iAtR0A1sJfqDtjCWmQEH3jt9dy5T2oxdd5EPozi JbNxnm24VK4GQ== X-Nifty-SrcIP: [220.150.135.41] Date: Fri, 13 Jan 2023 23:21:42 +0900 From: Takashi Yano To: "cygwin-apps@cygwin.com" Subject: Re: Version string of package Message-Id: <20230113232142.fe8ce6fef4f83d397fd2b23b@nifty.ne.jp> In-Reply-To: References: <20230113205210.e23a2f47c2ffd6ea86d97541@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 13 Jan 2023 13:22:44 +0000 Jon Turney wrote: > On 13/01/2023 11:52, Takashi Yano via Cygwin-apps wrote: > > Hi, > > > > Is it allowed to include '-' in version string (e.g. '20230113-stable')? > > I'm asking because mksetupini warns: > > > > mksetupini: file 'xxx.tar.xz' in package yyy contains '-' in version > > > > though it works as expected. > > Short answer: > > It's a bug that this isn't a fatal error. Please don't do it! > > Long answer: > > Package naming in Cygwin has a long and tangled history. This isn't > explicitly precluded by the rules at [1], but probably should be. > > (Fedora, which we generally follow for packaging rules, now doesn't > allow '-' in versions, just digits, letters and '.') > > We need to be able to unambiguously separate a NVR string into the > package name, version and release. > > Underscores are allowed in package names, so the simple approach of > splitting on the rightmost two hyphens would work, if we don't allow > exceptions like this. > > (We can get it right in this case, because we have a piece of extra > information: the directory the package is in, which happens to always be > named N in the current scheme of things, but we might want to change that) > > [1] https://cygwin.com/packaging-package-files.html > > > In any case, you should be suspicious of using upstream version names of > this form. They may expect the 'stable' string to sort against other > strings based on meaning, rather than alphabetically (e.g. > '20230113-testing' is considered greater, which is probably not what's > wanted) Thanks for the answer. I'll use version 20230113 with release 1.g e.g. package-name-20230113-1.g123456789abc like cygwin test package. -- Takashi Yano