From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id EFE583858D37 for ; Sun, 15 Jan 2023 06:12:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EFE583858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1029.google.com with SMTP id u1-20020a17090a450100b0022936a63a21so4502802pjg.4 for ; Sat, 14 Jan 2023 22:12:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:to:from:date:from:to:cc:subject:date:message-id :reply-to; bh=GmwzxhLGiAjfgq0MN7dnTs4GS0ieWSXMm/29A2hIN/8=; b=YfaFWsb29/Dy7cprirsuRJzU36VrHMHcJzuVoao1X08O1kiBEW9rAJKwwL6tJY3hL3 NRxLw+c+zBEeTNzpMxNaj8qB3tMo2qEeJd3EvKAAhSKsTbDBTKAIDKPnH6bt/M6y1l2X +kz0Jq+e/L+EdLyDQT2aiooJJgHqJWRCciTzYiuVghzL/Ajtn/nSQLXLJfqwMbt984tN p6uR+yK1zff14tEyIyE490FDoiQGE7i7xN5UoGuzPbMcpBJsxl7mnJpP/xf7cOAJ88Om dMwyubbhRrL39/VwyjrP/o22a4sUFeFB2b2q75HSwwX6PzhKiRHmdHBsETG25iMosFd4 /dtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GmwzxhLGiAjfgq0MN7dnTs4GS0ieWSXMm/29A2hIN/8=; b=qw85JN0sMaBdTBCFyF97JADeEsZC8E+OpoF+9dy3ZnE+o+iKmJ0b8O0Knqu1H9TjbJ ylouMZBPHS18r/62VDXAwS9jl0qxZR5fNGTUkI96y+hOGBIlZF4UL1AKhBjyzwto5JHD D+DnPHWd0cOKbxnDNTRzwNIaYeWJE4333LoKpunn32+qtitiUq0AfGV+LQ1uUuVY4+w/ gQg9MZtU7S+QXbWOHiEFveQVeCW8lMWmxFjMlQ0+llD45Y7uNhlYC64mS7RObrSAh1Lo MJ2fVmQo4jUlnnAMVl4L018C2L0UHgEEbz/zvM3A9im7uoPAlrPIYOsyXV9uUTocLp72 xlVQ== X-Gm-Message-State: AFqh2kogN8xEA/QwlFU82YFGUwA/FlHF4AESElQv+F9HDZr+nyUae+6Q BPy5jukvDAhYnz66HIfAW21gq7ldnyw= X-Google-Smtp-Source: AMrXdXsOF4wD7+/8t4pbCw2GpvvIZSLRp2pNHGguBg7UA7pcsq3Q8zrzUFv4QDn3tRpZKVCUnFW0PA== X-Received: by 2002:a17:902:7806:b0:193:335a:98ac with SMTP id p6-20020a170902780600b00193335a98acmr22369016pll.68.1673763169867; Sat, 14 Jan 2023 22:12:49 -0800 (PST) Received: from [192.168.3.3] ([2400:2411:aa20:4300:c1ef:fd2e:519a:23c5]) by smtp.gmail.com with ESMTPSA id q9-20020a170902bd8900b00192b93a6cdesm16695536pls.212.2023.01.14.22.12.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Jan 2023 22:12:49 -0800 (PST) Date: Sun, 15 Jan 2023 15:12:50 +0900 From: Lemures Lemniscati To: cygwin-apps@cygwin.com Subject: Re: [ITP] libinih In-Reply-To: <95f61c82-c125-9b93-d7b4-58ba95ee2350@dronecode.org.uk> References: <20230111231637.dbjlug2kpb2oa47i@lucy.dinwoodie.org> <95f61c82-c125-9b93-d7b4-58ba95ee2350@dronecode.org.uk> Message-Id: <20230115151247.59FB.50F79699@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Mailer: Becky! ver. 2.81.03 [ja] X-Antivirus: Avast (VPS 230114-4, 2023/1/14), Outbound message X-Antivirus-Status: Clean X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 13 Jan 2023 14:27:46 +0000, Jon Turney via Cygwin-apps > On 11/01/2023 23:16, Adam Dinwoodie via Cygwin-apps wrote: > > On Wed 11 Jan 2023 at 03:14:20PM +0000, Jon Turney wrote: > >> On 09/01/2023 16:32, Adam Dinwoodie via Cygwin-apps wrote: > >>> As requested at [0], I've offered to package libinih for Cygwin. It has > >>> a BSD license[1] and is already packaged for a bunch of *nix distros, > >>> including Fedora, Debian and Arch[2]. > >>> > [...] > >> This looks good, except... > >> > >> I'd ask you to split this into libinih0 and libinih-devel packages. > [...] > > > > Makes sense! Here's a rebuild: > > > > https://github.com/me-and/Cygwin-inih/releases/tag/v56-1-rc2 > Thanks. > > I added this to your packages. > > > NAME=libinih > > Since the upstream name is just 'inih', the source package should probably be named that also. > > > libinih0_CONTENTS="\ > > usr/bin/*.dll\ > > usr/share/\ > > " > > You probably want to write this glob as '*-0.dll', so that when the soversion changes, packaging fails, rather than silently ploughing on to contain a libinit0 containing cyginit-1.dll... > > (Or factor out the soversion as variable, or something...) I guess, usr/share/ should go to the -devel package, in order to avoid a situation: Files under it would have same names between libinih0 and later soversions (e.g. libinih1). Their contents might be the same, but.... Assume that both of libinih0 and libinih1 are installed, and if we uninstall libinih0, and then files under usr/share will be removed unintentionally, and, moreover, we need reinstall libinih1 to recover the removed files. Regards, Lem