From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-06.nifty.com (conssluserg-06.nifty.com [210.131.2.91]) by sourceware.org (Postfix) with ESMTPS id 870203858D32 for ; Sun, 22 Jan 2023 12:06:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 870203858D32 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from HP-Z230 (aj135041.dynamic.ppp.asahi-net.or.jp [220.150.135.41]) (authenticated) by conssluserg-06.nifty.com with ESMTP id 30MC5oYx008747 for ; Sun, 22 Jan 2023 21:05:50 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com 30MC5oYx008747 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1674389150; bh=hYnqnQBaI+1ZSC+hrblC8/vpgR9L3w0Y0ZzeGKTcOWM=; h=Date:From:To:Subject:In-Reply-To:References:From; b=A8bejDvQ8W1vyhcdbDS73I/hwv3v/0NW4dM45BdQMjy4imwYI/sWF9vsbEMFSq08C A6G/DxF0/HmUi39Q4Yw7aJcERvCam3mhHnEYDBFhQNg87KZZVXmsIwgujbOS8x4FlX oUg8FyFZ5CkP3Y8JNiLW0SHb/WAJh8WF8foW2sldkl05tIm/uB+HB7n7h7vGvKoUoq aBYOprJAMf7I/4FXqyi3EgVjdW8LnRozeWth6oRdQHMfKFhNHviLd0sKl3ikerg51M qBCmJP6rVuAN4UobI97SStkI9Hp5li8dDBrUId1Kqrz74CS8YhxjulkZYHgDLdii77 QVnZ0iOjXUBvg== X-Nifty-SrcIP: [220.150.135.41] Date: Sun, 22 Jan 2023 21:05:50 +0900 From: Takashi Yano To: "cygwin-apps@cygwin.com" Subject: Re: [ITA] SDL2 (2.26.2) Message-Id: <20230122210550.0c7fa8aedaa8ebf7dc772dbc@nifty.ne.jp> In-Reply-To: References: <20230120193525.ff89fed0f8bf788405537af8@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,SUBJ_ALL_CAPS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, 21 Jan 2023 14:58:55 +0000 Jon Turney wrote: > You've made some changes in the configuration here (switching from > enabling pulseaudio to oss) > > I think you've also dropped the winmm patch. > > I don't understand enough to evaluate the correctness those changes, so > it would be nice if you could explain that to me. Thanks for reviewing. The reason why I turnd off pulseaudio is that the latency was unacceptably large, despite the fact that pulseaudio is preferred over other sound drivers. Due to this, ffplay missynchronized sound with video. Also, I guess OSS was previously disabled because it does not work as expected due to a bug of cygwin: https://cygwin.com/pipermail/cygwin-patches/2023q1/012134.html and winmm was enabled instead. Now, the bug has been fixed and SDL2 gets working with OSS. Therefore, we don't need winmm support anymore. I think it is better not to call winmm directly from cygwin apps. BTW, I tried to modify SDL2 code to minimize the latency of pulseaudio and it succeeded. So, I re-enabled the pulseaudio and updated the package. Could you please review the package again? -- Takashi Yano