From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-01.nifty.com (conssluserg-01.nifty.com [210.131.2.80]) by sourceware.org (Postfix) with ESMTPS id A7F463857B9B for ; Tue, 14 Feb 2023 09:12:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A7F463857B9B Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from HP-Z230 (aj135041.dynamic.ppp.asahi-net.or.jp [220.150.135.41]) (authenticated) by conssluserg-01.nifty.com with ESMTP id 31E9Bdxd027627; Tue, 14 Feb 2023 18:11:39 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com 31E9Bdxd027627 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1676365899; bh=CDR3Vp2+IXnJxNMPlcG3zrdC+7SzPljnhwU7hkcDTXk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=b5sCic6EapyJLzLMFfXNh8s2KAoP1bfOMdfrfi4dcyIYUhKSQnzP+kDecumEjWYia gEqZkcfzPpQURV1JTvPqhma8i4mNvcFO7b14CB7bNJ5ElWg7k2KaxvHaIBNxUg1Drq u0grlis+oCalIL8d/l/H3VZuHGh3vSyAEU+ijKIQXE5g2VlinTH5PQvUYYYyOWpWJf enzH90kFJpZYriDRHoqU/Kn8j8IEHnfZdKmJPiY1bKG9MKia5p3X9TtGciuTM0SAFf LCCGDxnWR0DaHeFiUfLXvVksanmkI4aZ80fHdAurEYifhLVVVou471TlOwpA0whw0a 2ALSreBbusEPw== X-Nifty-SrcIP: [220.150.135.41] Date: Tue, 14 Feb 2023 18:11:38 +0900 From: Takashi Yano To: cygwin-apps@cygwin.com Cc: Jon Turney Subject: Re: [ITP] openh264 (2.3.1) Message-Id: <20230214181138.b1ecbd47e2ed919ed49cc714@nifty.ne.jp> In-Reply-To: <846e51c3-f96b-348a-a6aa-2b12bb74376d@Shaw.ca> References: <20230205173745.cf6aa7153ce8eae1dfd52c4c@nifty.ne.jp> <61e8a80b73a2d431afa338bd274dac17c5c87e25.camel@cygwin.com> <20230206142523.23a3b4b02cf8a8c5ef54b9f0@nifty.ne.jp> <20230210140531.673c73c9e3c2f8682418e803@nifty.ne.jp> <20230210141850.bfb1fbe60f09ef83d7407374@nifty.ne.jp> <20230210142534.18683ad2cd9e61e21d8fa8ab@nifty.ne.jp> <0e72ab79-fa2b-71fb-c453-3e29590ea7e4@dronecode.org.uk> <846e51c3-f96b-348a-a6aa-2b12bb74376d@Shaw.ca> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Tue__14_Feb_2023_18_11_38_+0900_CfX3mjmuOY+b1wnT" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --Multipart=_Tue__14_Feb_2023_18_11_38_+0900_CfX3mjmuOY+b1wnT Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 13 Feb 2023 12:03:02 -0700 Brian Inglis wrote: > On 2023-02-13 11:30, Jon Turney via Cygwin-apps wrote: > > On 10/02/2023 05:25, Takashi Yano via Cygwin-apps wrote: > >>> > >>> Ah, I see. Fedora's ffmpeg source package includes > >>> https://src.fedoraproject.org/repo/pkgs/ffmpeg/ffmpeg-dlopen-headers.tar.xz > >>> wihch has wels/*.h. You meant this can be used. > >> > >> Jon, should we include these headers as a part of ffmpeg > >> source package? Or distribute as another package like > >> https://tyan0.yr32.net/cygwin/noarch/release/openh264/ ? > > > I don't know. > > > > How do other distros approach this problem? > > What's least effort for you? > > Debian downloads binaries directly from Cisco during pkg install. This seems great if acceptable. I have tried that in cygport file. The new cygport file does: - The header files are placed in libopenh264-headers. I think this makes the license of the header files clearer than fedora's approach. - The libopenh264 package includes only /etc/postinstall and /etc/preremove, which downloads/removes Cisco's dll (binary) as well as license file. Jon, could you please have a look? -- Takashi Yano --Multipart=_Tue__14_Feb_2023_18_11_38_+0900_CfX3mjmuOY+b1wnT Content-Type: text/plain; name="openh264.cygport" Content-Disposition: attachment; filename="openh264.cygport" Content-Transfer-Encoding: 7bit NAME="openh264" VERSION=2.3.1 RELEASE=1 CATEGORY="Video" SUMMARY="H.264 codec library by Cisco" DESCRIPTION="OpenH264 is a codec library which supports H.264 encoding and decoding. It is suitable for use in real time applications such as WebRTC. The binary library (runtime) itself will be downloaded from http://ciscobinary.openh264.org/" HOMEPAGE="https://www.openh264.org/" LICENSE="BSD-2-Clause" ARCH="noarch" # This is noarch because it's just header files and shell scrpits. SRC_URI="${NAME}-headers-${VERSION}.tar.xz" # Make dummy source file for prep if the cleaned one is not exist. if [ ! -f ${SRC_URI} ] then mkdir ${NAME}-${VERSION} touch ${NAME}-${VERSION}/dummy tar acf ${SRC_URI} ${NAME}-${VERSION} rm -rf ${NAME}-${VERSION} fi CYGPORT_USE_UNSTABLE_API=1 src_unpack_hook() { if [ $(tar tvf ../../../${SRC_URI} | wc -l) -eq 2 ] # Source file is dummy then NV=${NAME}-${VERSION} pushd .. rm -rf ${NV} # Remove dummy source file. # Download original source file. wget https://github.com/cisco/openh264/archive/refs/tags/v${VERSION}.tar.gz tar xf v${VERSION}.tar.gz rm -f v${VERSION}.tar.gz # Make source file which has only necessary header files. tar acf ../../${NAME}-headers-${VERSION}.tar.xz ${NV}/codec/api/wels/*.h # Update source directory. rm -rf ${NV} tar xf ../../${NAME}-headers-${VERSION}.tar.xz popd fi } PKG_NAMES="libopenh264 libopenh264-headers" libopenh264_CATEGORY="Video Libs" libopenh264_CONTENTS="etc/" libopenh264_REQUIRES="wget bzip2" libopenh264_SUMMARY="H.264 codec library runtime by Cisco" libopenh264_headers_CATEGORY="Video Devel" libopenh264_headers_CONTENTS="usr/include" libopenh264_headers_SUMMARY="H.264 codec library headers" src_compile() { : } src_install() { mkdir -p ${D}/usr/include ln -fs ${S}/codec/api/wels ${D}/usr/include/. mkdir -p ${D}/etc/postinstall if [ $(uname -m) = "x86_64" ] then POSTFIX="win64" else POSTFIX="win32" fi cat << _EOF_ > ${D}/etc/postinstall/lib${NAME}.sh #!/bin/sh wget -q http://ciscobinary.openh264.org/${NAME}-${VERSION}-${POSTFIX}.dll.bz2 -O - | bunzip2 > /usr/bin/libopenh264.dll chmod a+x /usr/bin/libopenh264.dll mkdir -p /usr/share/doc/lib${NAME} wget -q http://www.openh264.org/BINARY_LICENSE.txt -O - > /usr/share/doc/lib${NAME}/BINARY_LICENSE.txt _EOF_ chmod a+x ${D}/etc/postinstall/lib${NAME}.sh mkdir -p ${D}/etc/preremove cat << _EOF_ > ${D}/etc/preremove/lib${NAME}.sh #!/bin/sh rm -rf /usr/bin/libopenh264.dll /usr/share/doc/lib${NAME} _EOF_ chmod a+x ${D}/etc/preremove/lib${NAME}.sh } --Multipart=_Tue__14_Feb_2023_18_11_38_+0900_CfX3mjmuOY+b1wnT--