From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from condef-06.nifty.com (condef-06.nifty.com [202.248.20.71]) by sourceware.org (Postfix) with ESMTPS id F21B6385840A for ; Mon, 20 Feb 2023 09:46:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F21B6385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nifty.ne.jp Received: from conssluserg-03.nifty.com ([10.126.8.82])by condef-06.nifty.com with ESMTP id 31K8u6Lu022098 for ; Mon, 20 Feb 2023 17:56:06 +0900 Received: from HP-Z230 (aj135041.dynamic.ppp.asahi-net.or.jp [220.150.135.41]) (authenticated) by conssluserg-03.nifty.com with ESMTP id 31K8tE9t007278; Mon, 20 Feb 2023 17:55:15 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com 31K8tE9t007278 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1676883315; bh=DqAlvNv902uoilxf5H2G+hF9HlDLV84CbNwk+NOFoB4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fAi9FiZywiIC2Ecpoj7sn/NxljQ9Rs/nQ7SjPm3cb+6vAelgkqS1Uv7WrjVoM+P0J 96Y6xtDJrrVdgmIQlgBIiPE3WJEuzmeGqJfRq1S/fQZdUKkDQpkcOU1ZVAV87Aadii UMmwVYlqQWZK/fJoyoGX7uRE4rk3dcINCk+uJVOKQh1mKqtK4O0GWjVVL66f3wsk9M giM0F/kl+L2WdD0RyQBtdOhsxJDCbpVYP/EKusAPu8KBradqKcM5Fk2Wlw5WPxmqf3 ofIoQAaU1LVJlwUba5aPOLyuY+WrbxK7PrC4Vi9LFO9z03+W+T8LikczQFGlDgmrX9 2QyrWPSL8HscQ== X-Nifty-SrcIP: [220.150.135.41] Date: Mon, 20 Feb 2023 17:55:14 +0900 From: Takashi Yano To: "cygwin-apps@cygwin.com" Cc: Jon Turney Subject: Re: [ITP] openh264 (2.3.1) Message-Id: <20230220175514.5e7cd25af4eabfa7e0e4e1dd@nifty.ne.jp> In-Reply-To: <3fcd159f-3925-d541-8a91-ef7431608a00@dronecode.org.uk> References: <20230205173745.cf6aa7153ce8eae1dfd52c4c@nifty.ne.jp> <61e8a80b73a2d431afa338bd274dac17c5c87e25.camel@cygwin.com> <20230206142523.23a3b4b02cf8a8c5ef54b9f0@nifty.ne.jp> <20230210140531.673c73c9e3c2f8682418e803@nifty.ne.jp> <20230210141850.bfb1fbe60f09ef83d7407374@nifty.ne.jp> <20230210142534.18683ad2cd9e61e21d8fa8ab@nifty.ne.jp> <0e72ab79-fa2b-71fb-c453-3e29590ea7e4@dronecode.org.uk> <846e51c3-f96b-348a-a6aa-2b12bb74376d@Shaw.ca> <20230214181138.b1ecbd47e2ed919ed49cc714@nifty.ne.jp> <87cz6cwlv6.fsf@Otto.invalid> <20230214212801.83ead05c9df51b281e26baf4@nifty.ne.jp> <878rh0w66r.fsf@Otto.invalid> <20230215062152.474ad26d8c3b4a9bd0d2bb82@nifty.ne.jp> <20230217174959.c4172f9b903763dc58df4320@nifty.ne.jp> <3fcd159f-3925-d541-8a91-ef7431608a00@dronecode.org.uk> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 19 Feb 2023 15:37:47 +0000 Jon Turney wrote: > On 17/02/2023 08:49, Takashi Yano via Cygwin-apps wrote: > > So, how about this one? > > > > package contains: > > - the headers > > - the data files with the version and hash > > - postinstall and preremove scripts which fetch (using above data) > > and remove the DLL > > Great, thanks. I hope this means you think this is a better approach, > rather than just humouring me :) Absolutely yes :) > A few minor points: > > * It seems like the empty dummy archive could be made with something > like just: > > tar -Jcf ${SRC_URI} --files-from /dev/null Just doing this causes mismatch of SRC_DIR with actual source package. However, making ${NAME}-{$VERSION}/dummy file does not seem necessary. So, I modified the cygport file as follows. mkdir -p ${NAME}-${VERSION} tar acf ${SRC_URI} ${NAME}-${VERSION} rm -rf ${NAME}-${VERSION} > * If the postinstall failed somehow, the preremove script will fail > trying to remove a file which doesn't exist. It might be a good idea to > use 'rm -f' to ensure that doesn't happen. Indeed. Fixed. Thanks! > * I don't think you should need: > > > # Install postinstall/preremove scripts > > mkdir -p ${D}/etc/postinstall ${D}/etc/preremove > > cp ${C}/lib${NAME}.postinstall ${D}/etc/postinstall/lib${NAME}.sh > > cp ${C}/lib${NAME}.preremove ${D}/etc/preremove/lib${NAME}.sh > > > > This should happen automatically if the files are in $C (and you can > list them in CYGWIN_FILES or make them with cygwin.patch file to put > them there) That's what I understood from https://cygwin.github.io/cygport/masterindex.html, however, actually libopenh264.{postinstall,preremove} are not installed during install process by cygport 0.36.0 even though openh264-2.3.1-1.cygwin.patch exists. Could you please give me a hint how I can make it work? -- Takashi Yano