From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from conssluserg-04.nifty.com (conssluserg-04.nifty.com [210.131.2.83]) by sourceware.org (Postfix) with ESMTPS id 724C0385840F for ; Fri, 24 Feb 2023 09:17:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 724C0385840F Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp Received: from HP-Z230 (aj135041.dynamic.ppp.asahi-net.or.jp [220.150.135.41]) (authenticated) by conssluserg-04.nifty.com with ESMTP id 31O9Gvil014495 for ; Fri, 24 Feb 2023 18:16:57 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com 31O9Gvil014495 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.ne.jp; s=dec2015msa; t=1677230217; bh=eMzlKQrMc0YoGsB0LouGPHNCFZ0X6NvWNA3nGisOfY0=; h=Date:From:To:Subject:In-Reply-To:References:From; b=USXMvTatHpcE+BY+dW7oGrrsImHmPgsqPeToOS3WQ/qi8V4F1Y+Fbd9RkdQgbzlNq ldAaOl75Z47A6ytO457ozSXQ5ru/evaMEhkVp8V44ZDGcTE0k1vCWUTvnYytqnvVX+ h5Iq6kNNRPT2fD8QM5GGedKIfkNGXDcopviAbfFoA2TaqGmKREZnh28+WrGJXYhm6Q +QdIMyLH4H4D1RmB1p/vq1AqxvFaMQ3i1XOBkoEsvLCfY1C3d4y4F8MlN+RudRzNAf ykkj+ZzgmyLv8kDvRZ1LbVB8uMUHQRW7oejVYcy6F+839FH8LC0bV8Ds/7jwCRj8MO lacAaEeIIDegA== X-Nifty-SrcIP: [220.150.135.41] Date: Fri, 24 Feb 2023 18:16:57 +0900 From: Takashi Yano To: "cygwin-apps@cygwin.com" Subject: Re: [ITP] openh264 (2.3.1) Message-Id: <20230224181657.44f852872089e3e5d193b48e@nifty.ne.jp> In-Reply-To: References: <20230205173745.cf6aa7153ce8eae1dfd52c4c@nifty.ne.jp> <20230210140531.673c73c9e3c2f8682418e803@nifty.ne.jp> <20230210141850.bfb1fbe60f09ef83d7407374@nifty.ne.jp> <20230210142534.18683ad2cd9e61e21d8fa8ab@nifty.ne.jp> <0e72ab79-fa2b-71fb-c453-3e29590ea7e4@dronecode.org.uk> <846e51c3-f96b-348a-a6aa-2b12bb74376d@Shaw.ca> <20230214181138.b1ecbd47e2ed919ed49cc714@nifty.ne.jp> <87cz6cwlv6.fsf@Otto.invalid> <20230214212801.83ead05c9df51b281e26baf4@nifty.ne.jp> <878rh0w66r.fsf@Otto.invalid> <20230215062152.474ad26d8c3b4a9bd0d2bb82@nifty.ne.jp> <20230217174959.c4172f9b903763dc58df4320@nifty.ne.jp> <3fcd159f-3925-d541-8a91-ef7431608a00@dronecode.org.uk> <20230220175514.5e7cd25af4eabfa7e0e4e1dd@nifty.ne.jp> <907d2252-5372-c587-5d2c-aa8637b36e54@dronecode.org.uk> <20230222123308.5d171a96c957cc5be9eb2500@nifty.ne.jp> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 23 Feb 2023 12:54:04 +0000 Jon Turney wrote: > On 22/02/2023 03:33, Takashi Yano via Cygwin-apps wrote: > > On Tue, 21 Feb 2023 14:11:46 +0000 > > Jon Turney wrote: > >> On 20/02/2023 08:55, Takashi Yano via Cygwin-apps wrote: > >>> On Sun, 19 Feb 2023 15:37:47 +0000 > >>> Jon Turney wrote: > >> [...]>> * I don't think you should need: > >>>> > >>>>> # Install postinstall/preremove scripts > >>>>> mkdir -p ${D}/etc/postinstall ${D}/etc/preremove > >>>>> cp ${C}/lib${NAME}.postinstall ${D}/etc/postinstall/lib${NAME}.sh > >>>>> cp ${C}/lib${NAME}.preremove ${D}/etc/preremove/lib${NAME}.sh > >>>>> > >>>> > >>>> This should happen automatically if the files are in $C (and you can > >>>> list them in CYGWIN_FILES or make them with cygwin.patch file to put > >>>> them there) > >>> > >>> That's what I understood from > >>> https://cygwin.github.io/cygport/masterindex.html, > >>> however, actually libopenh264.{postinstall,preremove} are > >>> not installed during install process by cygport 0.36.0 > >>> even though openh264-2.3.1-1.cygwin.patch exists. > >>> > >>> Could you please give me a hint how I can make it work? > >> > >> Aha! This is a bug in cygport. > >> > >> (There's some code which skips over doing this for the first item in > >> PKG_NAMES, assuming that is always the same as PN, which has already > >> been done) > >> > >> Thanks for drawing that to my attention. I'll look into fixing it, but > >> for the moment it seems you can workaround the bug by ensuring that the > >> package with premove/postinstall scripts isn't first in that list, i.e.: > >> > >> - PKG_NAMES="libopenh264 libopenh264-headers" > >> + PKG_NAMES="libopenh264-headers libopenh264" > > > > Thanks! It works. > > > > I updated the cygport file and cygwin.patch. > > GTG. Thank you for reviewing all my proposed packages! -- Takashi Yano