From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Nf+X=JE=nifty.ne.jp=takashi.yano@sourceware.org>
Received: from dmta1005.nifty.com (mta-snd01010.nifty.com [106.153.227.42])
	by sourceware.org (Postfix) with ESMTPS id 631D13858D28
	for <cygwin-apps@cygwin.com>; Fri, 26 Jan 2024 03:31:43 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 631D13858D28
Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=nifty.ne.jp
Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=nifty.ne.jp
ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 631D13858D28
Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=106.153.227.42
ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706239906; cv=none;
	b=NKEPQB+33FShiAbW8pk6EKoeqLkZI6iFZsvOLsTA1AZUzIhVjRgT7tJMaVPmDik+XcoCTjLgTp16ghy3vv+6+telLwz2eiiFEnxQO7njhDsK8Eht4Iizp/z5Olc/7ffsZMNfafmOpiWQKzoNBXjqYPjAPNuJtv/9Rh17Auc671U=
ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key;
	t=1706239906; c=relaxed/simple;
	bh=AfcYYBZrabKvku6Crk8kt4ZVKqozh0u0nBC1ylXpOS0=;
	h=Date:From:To:Subject:Message-Id:Mime-Version; b=WkSmBv4V2LHOw1fmwSRo+Vxo53777MM30D7M1cH6IIyBbXKsaczBMPFlBsjn7IAVU/4wXUbG76W5k0nGtNAmmwosIAggoPsLP1LpQBAS8gF8EHV/ujzPrElsUC1QHJHYCxE7IpUDPyOXbmsKPbAXY1aG+6mUVrEnk0s3pSsHMy0=
ARC-Authentication-Results: i=1; server2.sourceware.org
Received: from HP-Z230 by dmta1005.nifty.com with ESMTP
          id <20240126033141134.DYQV.44550.HP-Z230@nifty.com>
          for <cygwin-apps@cygwin.com>; Fri, 26 Jan 2024 12:31:41 +0900
Date: Fri, 26 Jan 2024 12:31:40 +0900
From: Takashi Yano <takashi.yano@nifty.ne.jp>
To: cygwin-apps@cygwin.com
Subject: Re: [ITP] btop
Message-Id: <20240126123140.7fb3bf5bc23337957cf91548@nifty.ne.jp>
In-Reply-To: <995db097-a742-48fd-acec-74d8a0b31487@dronecode.org.uk>
References: <20240125002207.aee9cbe0810b0bfd9e928214@nifty.ne.jp>
	<995db097-a742-48fd-acec-74d8a0b31487@dronecode.org.uk>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <cygwin-apps.cygwin.com>

On Thu, 25 Jan 2024 15:11:12 +0000
Jon Turney wrote:
> On 24/01/2024 15:22, Takashi Yano via Cygwin-apps wrote:
> > +#ifdef __CYGWIN__
> > +#define _GNU_SOURCE 1
> > +#endif
> > +
> 
> I'd suggest adding -D_GNU_SOURCE=1 to CPPFLAGS, rather than patching 
> this in everywhere it's needed.
> 
> (Setting this unconditionally could be added to the build system 
> somewhere, which is theoretically upstreamable, since it's only not 
> needed on linux for :reasons:)

Sounds good! Thanks.
I'll add it to CMakeLists.txt and Makfile for CYGWIN for the time being.

> > +#ifdef __CYGWIN__
> > +typedef uint32_t DWORD
> 
> Is it not possible to just #include <windows.h> here?  If not, perhaps a 
> comment why the definitions are copied would nice.

When I included <windows.h> here, many conflicts occured between
posix headers and w32api headers.
However, now I have found that including w32api headers after all
the posix headers and typedef IN6_ADDR like:

#ifdef __CYGWIN__
#include <windows.h>
#include <pdh.h>
#include <tlhelp32.h>
typedef struct {
  union {
    u_char Byte[16];
    u_short Word[8];
  } u;
} IN6_ADDR;
#include <iphlpapi.h>
#endif

solves the conflicts. Thanks!

-- 
Takashi Yano <takashi.yano@nifty.ne.jp>