From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-042.btinternet.com (mailomta26-sa.btinternet.com [213.120.69.32]) by sourceware.org (Postfix) with ESMTPS id B30033858D33 for ; Tue, 6 Feb 2024 17:36:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B30033858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B30033858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=213.120.69.32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707240998; cv=none; b=GlLFVn8W4E0QvqdssGjSfP0bke1f48w8nu4jX+aaTaq4N1lvQvyBK//C44TF/u7Jwib80FLcuhEFW7KfCY8WpKfQev827AhZiBlZI3B+1TrNUS5Z7mCadxefZW1GqtDUT5FvlskGhgilucJTGOB0vhSzj+g5akJnjYFX6xP3EF8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707240998; c=relaxed/simple; bh=ydC5HzvbRmZ32dL5fDQsY6yANeqEw75p6/ZV8f1yKcc=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=htPwoZqB92hJ54iv+JGaTtushAR0BNSCaPtFajKkrAFkeWrYEe8bZqYPLGbYWhK5jKBhzIJsRr8iT9u5umVgsv64zsnGEAzO1ibgWn5hi+4ks9DPZ/svpChCXOUc27vg5pZX6pWvA5yx9ot0Rti+fAEYkUg05Wceu4lvqhgirqM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from sa-prd-rgout-005.btmx-prd.synchronoss.net ([10.2.38.8]) by sa-prd-fep-042.btinternet.com with ESMTP id <20240206173634.STTW10692.sa-prd-fep-042.btinternet.com@sa-prd-rgout-005.btmx-prd.synchronoss.net>; Tue, 6 Feb 2024 17:36:34 +0000 Authentication-Results: btinternet.com; auth=pass (LOGIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 65A5686F0306F670 X-Originating-IP: [86.140.193.68] X-OWM-Source-IP: 86.140.193.68 X-OWM-Env-Sender: jon.turney@dronecode.org.uk X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvledrtddtgdejfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeehuedutdehhfeutefgieefgfelieettdeigfdtfffhvdevgeegteejfeeftdehgfenucfkphepkeeirddugedtrdduleefrdeikeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopehlohgtrghlhhhoshhtrdhlohgtrghlughomhgrihhnpdhinhgvthepkeeirddugedtrdduleefrdeikedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhmpdhrtghpthhtohepjhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhdprhgvvhfkrfephhhoshhtkeeiqddugedtqdduleefqdeikedrrhgrnhhgvgekiedqudegtddrsghttggvnhhtrhgrlhhplhhushdrtghomhdprghuthhhpghushgvrhepjhhonhhtuhhrnhgvhiessghtihhnthgvrhhnvghtrdgtohhmpdhgvghokffrpefi uedpoffvtefjohhsthepshgrqdhprhguqdhrghhouhhtqddttdeh X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from localhost.localdomain (86.140.193.68) by sa-prd-rgout-005.btmx-prd.synchronoss.net (authenticated as jonturney@btinternet.com) id 65A5686F0306F670; Tue, 6 Feb 2024 17:36:34 +0000 From: Jon Turney To: cygwin-apps@cygwin.com Cc: Jon Turney Subject: [PATCH setup] Fix -Woverloaded-virtual warnings about Window::Create() Date: Tue, 6 Feb 2024 17:36:17 +0000 Message-ID: <20240206173618.12038-1-jon.turney@dronecode.org.uk> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In gcc 13, -Wall turns on -Woverloaded-virtual --- Notes: I think despite being marked virtual, these methods aren't actually callable on any derived object because they aren't declared for those sublasses. It seems that all calls to these in methods in derived objects use the method name qualified by an explcit classname. So we can simply fix this warning by removing the 'virtual' specifier. But someone double-checking my reasoning here is probably a good idea. Makefile.am | 2 +- proppage.h | 10 +++++----- window.h | 7 +++---- 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/Makefile.am b/Makefile.am index b459d16..22ad30c 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,7 +22,7 @@ SUBDIRS := @subdirs@ tests BASECXXFLAGS = -Werror -Wall -Wpointer-arith -Wcomments \ -Wcast-align -Wwrite-strings -fno-builtin-sscanf \ -Wno-attributes -AM_CXXFLAGS = $(BASECXXFLAGS) -std=gnu++11 ${$(*F)_CXXFLAGS} +AM_CXXFLAGS = $(BASECXXFLAGS) -Woverloaded-virtual -std=gnu++11 ${$(*F)_CXXFLAGS} AM_CFLAGS = $(BASECXXFLAGS) -Wmissing-declarations -Winline \ -Wstrict-prototypes -Wmissing-prototypes AM_YFLAGS = -d diff --git a/proppage.h b/proppage.h index 64f822b..9db1a90 100644 --- a/proppage.h +++ b/proppage.h @@ -115,11 +115,11 @@ public: IsLast = false; }; - virtual bool Create (int TemplateID); - virtual bool Create (DLGPROC dlgproc, int TemplateID); - virtual bool Create (DLGPROC dlgproc, - BOOL (*cmdproc) (HWND h, int id, HWND hwndctl, - UINT code), int TemplateID); + bool Create (int TemplateID); + bool Create (DLGPROC dlgproc, int TemplateID); + bool Create (DLGPROC dlgproc, + BOOL (*cmdproc) (HWND h, int id, HWND hwndctl, + UINT code), int TemplateID); virtual void OnInit () { diff --git a/window.h b/window.h index 1dfb2a9..dcc81c1 100644 --- a/window.h +++ b/window.h @@ -82,10 +82,9 @@ public: Window (); virtual ~ Window (); - virtual bool Create (Window * Parent = NULL, - DWORD Style = - WS_OVERLAPPEDWINDOW | WS_VISIBLE | WS_CLIPCHILDREN); - + bool Create (Window * Parent = NULL, + DWORD Style = WS_OVERLAPPEDWINDOW | WS_VISIBLE | WS_CLIPCHILDREN); + static void SetAppInstance (HINSTANCE h) { // This only has to be called once in the entire app, before -- 2.43.0