From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-043.btinternet.com (mailomta10-sa.btinternet.com [213.120.69.16]) by sourceware.org (Postfix) with ESMTPS id 884AF3858CD1 for ; Sun, 10 Mar 2024 14:38:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 884AF3858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dronecode.org.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 884AF3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=213.120.69.16 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710081485; cv=none; b=Emz/ib29zDCft5n2EoHHwcjT6Kukv+Csclt/uhGJC1C7tbXfSuhtdnRf6u9OzD+RuMsVJM7dBFM1OTcxTuIPp1mpAmy0ZGwa3YkWlgENov4/HZiBr3yKR4OeqEEpHCEHqqd+f7DwMXHEron2vEeVf+QANkNPenz7CaC4P7JJoVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710081485; c=relaxed/simple; bh=0wyV2BaxcJUknoRBx75xDBg65TXXkoSNJWmUfNpRap8=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=k92K0zxSyexRRvd9/4D2orRrZ3PJQOkUvY6W/jIfMzx/zQfKkIKbe4Z/CpBy819EPV3xrtR6Ek0/6dEDorfQ6px9M49V8lVVsNzbbF5HYoTW2SX2WVtxPTI/xFrf7hKM8GZunC+wCoy9Wo5DjxuFj4o1So5rctUeJOFRVX7OFYI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from sa-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.38.5]) by sa-prd-fep-043.btinternet.com with ESMTP id <20240310143802.XIEU1396.sa-prd-fep-043.btinternet.com@sa-prd-rgout-002.btmx-prd.synchronoss.net>; Sun, 10 Mar 2024 14:38:02 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 65A567CD06B62F59 X-Originating-IP: [81.153.98.185] X-OWM-Source-IP: 81.153.98.185 X-OWM-Env-Sender: jon.turney@dronecode.org.uk X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvledrieelgdeiiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvfhfhvegjtgfgsehtjeertddtvdejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeevvdekgfffteetueehgfdugefgkeevleejudduheevuedtveejfeevvdevvdfgvdenucfkphepkedurdduheefrdelkedrudekheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtlegnpdhinhgvthepkedurdduheefrdelkedrudekhedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepvehhrhhishhtihgrnhdrhfhrrghnkhgvsehtqdhonhhlihhnvgdruggvpdhrtghpthhtoheptgihghifihhnqdgrphhpshestgihghifihhnrdgtohhmpdhrvghvkffrpehhohhsthekuddqudehfedqleekqddukeehrdhrrghnghgvkeduqdduheefrdgsthgtvghnthhrrghlphhluhhsrdgtohhmpdgruhhthhgpuhhsvghrpehjohhnthhurhhnvgihsegsthhinhht vghrnhgvthdrtghomhdpghgvohfkrfepifeupdfovfetjfhoshhtpehsrgdqphhrugdqrhhgohhuthdqtddtvd X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.109] (81.153.98.185) by sa-prd-rgout-002.btmx-prd.synchronoss.net (authenticated as jonturney@btinternet.com) id 65A567CD06B62F59; Sun, 10 Mar 2024 14:38:02 +0000 Message-ID: <20d64930-9c17-4fb0-861e-3145b5d67601@dronecode.org.uk> Date: Sun, 10 Mar 2024 14:37:59 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH cygport] Add customization support for announce command Content-Language: en-US To: Christian Franke References: <2c21353b-f249-d03f-a9fa-68f0e56b9dcb@t-online.de> From: Jon Turney Cc: cygwin-apps@cygwin.com In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23/02/2024 11:23, Christian Franke via Cygwin-apps wrote: > Christian Franke wrote: >> The email generated by the cygport announce command is useful, but >> actual use cases are somewhat limited due to the hard-coded email >> submission. >> >> The attached patch adds more flexibility. The patch is on top of the >> "Use correct wording if only one package is announced" patch. > > Slightly changed patch attached. Also adjusted to new version of "Use > correct wording if only one package is announced" patch. > > [...] Thanks for this. > Possible (better?) alternative names for the new settings: > ANNOUNCEMENT_EDITOR > ANNOUNCEMENT_MAILER Hmmm... I think "ANNOUNCE_EDITOR" and "ANNOUNCE_MAILER" would be the best for clarity and conciseness. > -From: ${SMTP_SENDER} > -To: cygwin-announce@cygwin.com > +${SMTP_SENDER:+From: ${SMTP_SENDER} > +}To: cygwin-announce@cygwin.com > Date: $(date -R --date=${msgat}) > -Message-Id: <$(date "+%Y%m%d%H%M%S.$$" --date=${msgat})-1-$(echo ${SMTP_SENDER} | sed 's|.*<\(.*\)>.*|\1|')> > +Message-Id: <$(date "+%Y%m%d%H%M%S.$$" --date=${msgat})-1-$(echo ${SMTP_SENDER:-cygport} | sed 's|.*<\(.*\)>.*|\1|')> > Subject: ${NAME} ${PVR} Can you also explain what this is doing in the commit message, since it's not immediately apparent.