public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: Takashi Yano <takashi.yano@nifty.ne.jp>,
	"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: [ITP] AMF (1.4.29)
Date: Mon, 13 Feb 2023 18:05:44 +0000	[thread overview]
Message-ID: <20f1a9b6-178b-5499-d3da-19408e205de0@dronecode.org.uk> (raw)
In-Reply-To: <20230206212204.2b2d83eb29b67be6f005563f@nifty.ne.jp>

On 06/02/2023 12:22, Takashi Yano via Cygwin-apps wrote:
> On Sun, 5 Feb 2023 16:34:19 +0000
> Jon Turney wrote:
>> On 05/02/2023 08:38, Takashi Yano via Cygwin-apps wrote:
>>> I would like to propose new package AMF, which is
>>> codec-headers for AMD GPUs. This is needed by ffmpeg
>>> package I had proposed, and also provided for ffmpeg-free
>>> package in fedora.
>>>
>>> I already prepared the package at the following location.
>>>
>>> https://tyan0.yr32.net/cygwin/noarch/release/AMF/
>>
>> A comment in the cygport saying what the src_unpack_hook is doing, and
>> why would be helpful.
>>
>> A comment by the "noarch" saying "this is noarch because it's just
>> header files" would be helpful.
>>
>> Otherwise, looks good.
> 
> Thanks for the advice. I revised the cygport file
> as attached. Is this as you expected?
> 

# Remove unnecessary files.

I think the only reason for removing files is because they cannot be 
distributed by us.  If that's the case, that's what the comment should say.

Otherwise, approved.


  reply	other threads:[~2023-02-13 18:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-05  8:38 Takashi Yano
2023-02-05 16:34 ` Jon Turney
2023-02-06 12:22   ` Takashi Yano
2023-02-13 18:05     ` Jon Turney [this message]
2023-02-14  9:11       ` Takashi Yano
2023-02-16 18:48         ` Jon Turney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20f1a9b6-178b-5499-d3da-19408e205de0@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=cygwin-apps@cygwin.com \
    --cc=takashi.yano@nifty.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).