From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34497 invoked by alias); 12 Jul 2018 16:25:17 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 30437 invoked by uid 89); 12 Jul 2018 16:25:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=vista, H*r:may, H*r:forged, 20180213 X-HELO: limerock02.mail.cornell.edu Received: from limerock02.mail.cornell.edu (HELO limerock02.mail.cornell.edu) (128.84.13.242) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Jul 2018 16:24:59 +0000 Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w6CGOmwq026869 for ; Thu, 12 Jul 2018 12:24:48 -0400 Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w6CGOlQ6011706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Thu, 12 Jul 2018 12:24:48 -0400 To: cygwin-apps From: Ken Brown Subject: Use of Win32 API in harfbuzz Message-ID: <22165fae-2b9c-c872-e920-6d0983786c9e@cornell.edu> Date: Thu, 12 Jul 2018 16:25:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------91B05CD25D5D428C8A67D31B" X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00025.txt.bz2 This is a multi-part message in MIME format. --------------91B05CD25D5D428C8A67D31B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 522 Yaakov, A recent commit in upstream harfbuzz (ce17340) used the Win32 API on Cygwin. I was about to send a patch upstream to fix this, but I thought I should first check for such uses in the current Cygwin release (1.7.6-1). The attached patch removes the ones I found. Am I right in removing all of these, or should some be kept? I wasn't sure about the calls to setmode(), for example. And is it OK with you for me to send Cygwin patches upstream, or would you rather be the one communicating with them? Ken --------------91B05CD25D5D428C8A67D31B Content-Type: text/plain; charset=UTF-8; name="harfbuzz-1.7.6-1.src.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="harfbuzz-1.7.6-1.src.patch" Content-length: 3404 LS0tIG9yaWdzcmMvaGFyZmJ1enotMS43LjYvc3JjL2hiLW11dGV4LXByaXZh dGUuaGgJMjAxOC0wMi0xMyAxOToyNzoyMy4wMDAwMDAwMDAgLTA1MDAKKysr IHNyYy9oYXJmYnV6ei0xLjcuNi9zcmMvaGItbXV0ZXgtcHJpdmF0ZS5oaAky MDE4LTA3LTEyIDA5OjIwOjE1LjI1NjcwNjQwMCAtMDQwMApAQCAtNDgsNyAr NDgsNyBAQAogLyogRGVmaW5lZCBleHRlcm5hbGx5LCBpLmUuIGluIGNvbmZp Zy5oOyBtdXN0IGhhdmUgdHlwZWRlZidlZCBoYl9tdXRleF9pbXBsX3QgYXMg d2VsbC4gKi8KIAogCi0jZWxpZiAhZGVmaW5lZChIQl9OT19NVCkgJiYgKGRl ZmluZWQoX1dJTjMyKSB8fCBkZWZpbmVkKF9fQ1lHV0lOX18pKQorI2VsaWYg IWRlZmluZWQoSEJfTk9fTVQpICYmIGRlZmluZWQoX1dJTjMyKQogCiAjaW5j bHVkZSA8d2luZG93cy5oPgogdHlwZWRlZiBDUklUSUNBTF9TRUNUSU9OIGhi X211dGV4X2ltcGxfdDsKLS0tIG9yaWdzcmMvaGFyZmJ1enotMS43LjYvc3Jj L2hiLW90LXNoYXBlLWNvbXBsZXgtYXJhYmljLWZhbGxiYWNrLmhoCTIwMTgt MDItMTMgMTk6Mjc6MjMuMDAwMDAwMDAwIC0wNTAwCisrKyBzcmMvaGFyZmJ1 enotMS43LjYvc3JjL2hiLW90LXNoYXBlLWNvbXBsZXgtYXJhYmljLWZhbGxi YWNrLmhoCTIwMTgtMDctMTIgMDk6MjA6NDQuMDQwMjg1NjAwIC0wNDAwCkBA IC0yMDcsNyArMjA3LDcgQEAgc3RydWN0IGFyYWJpY19mYWxsYmFja19wbGFu X3QKIAogc3RhdGljIGNvbnN0IGFyYWJpY19mYWxsYmFja19wbGFuX3QgYXJh YmljX2ZhbGxiYWNrX3BsYW5fbmlsID0ge307CiAKLSNpZiAoZGVmaW5lZChf V0lOMzIpIHx8IGRlZmluZWQoX19DWUdXSU5fXykpICYmICFkZWZpbmVkKEhC X05PX1dJTjEyNTYpCisjaWYgZGVmaW5lZChfV0lOMzIpICYmICFkZWZpbmVk KEhCX05PX1dJTjEyNTYpCiAjZGVmaW5lIEhCX1dJVEhfV0lOMTI1NgogI2Vu ZGlmCiAKLS0tIG9yaWdzcmMvaGFyZmJ1enotMS43LjYvc3JjL2hiLXByaXZh dGUuaGgJMjAxOC0wMi0xOCAxNDozNjoxMi4wMDAwMDAwMDAgLTA1MDAKKysr IHNyYy9oYXJmYnV6ei0xLjcuNi9zcmMvaGItcHJpdmF0ZS5oaAkyMDE4LTA3 LTEyIDA5OjIxOjM0LjE2ODk0ODYwMCAtMDQwMApAQCAtMTc3LDcgKzE3Nyw3 IEBAIGV4dGVybiAiQyIgdm9pZCAgaGJfZnJlZV9pbXBsKHZvaWQgKnB0cikK ICMgIGRlZmluZSBIQl9GQUxMVEhST1VHSCAvKiBGQUxMVEhST1VHSCAqLwog I2VuZGlmCiAKLSNpZiBkZWZpbmVkKF9XSU4zMikgfHwgZGVmaW5lZChfX0NZ R1dJTl9fKQorI2lmZGVmIF9XSU4zMgogICAgLyogV2UgbmVlZCBXaW5kb3dz IFZpc3RhIGZvciBib3RoIFVuaXNjcmliZSBiYWNrZW5kIGFuZCBmb3IKICAg ICAqIE1lbW9yeUJhcnJpZXIuICBXZSBkb24ndCBzdXBwb3J0IGNvbXBpbGlu ZyBvbiBXaW5kb3dzIFhQLAogICAgICogdGhvdWdoIHdlIHJ1biBvbiBpdCBm aW5lLiAqLwotLS0gb3JpZ3NyYy9oYXJmYnV6ei0xLjcuNi91dGlsL29wdGlv bnMuY2MJMjAxOC0wMi0yNyAxMzo1MDozNi4wMDAwMDAwMDAgLTA1MDAKKysr IHNyYy9oYXJmYnV6ei0xLjcuNi91dGlsL29wdGlvbnMuY2MJMjAxOC0wNy0x MiAwOToyMjoyMi4yNjY4NzM0MDAgLTA0MDAKQEAgLTY0NCw3ICs2NDQsNyBA QCBmb250X29wdGlvbnNfdDo6Z2V0X2ZvbnQgKHZvaWQpIGNvbnN0CiAgICAg ICAvKiByZWFkIGl0ICovCiAgICAgICBHU3RyaW5nICpncyA9IGdfc3RyaW5n X25ldyAobnVsbHB0cik7CiAgICAgICBjaGFyIGJ1ZltCVUZTSVpdOwotI2lm IGRlZmluZWQoX1dJTjMyKSB8fCBkZWZpbmVkKF9fQ1lHV0lOX18pCisjaWZk ZWYgX1dJTjMyCiAgICAgICBzZXRtb2RlIChmaWxlbm8gKHN0ZGluKSwgT19C SU5BUlkpOwogI2VuZGlmCiAgICAgICB3aGlsZSAoIWZlb2YgKHN0ZGluKSkg ewpAQCAtODM3LDcgKzgzNyw3IEBAIG91dHB1dF9vcHRpb25zX3Q6OmdldF9m aWxlX2hhbmRsZSAodm9pZCkKICAgaWYgKG91dHB1dF9maWxlKQogICAgIGZw ID0gZm9wZW4gKG91dHB1dF9maWxlLCAid2IiKTsKICAgZWxzZSB7Ci0jaWYg ZGVmaW5lZChfV0lOMzIpIHx8IGRlZmluZWQoX19DWUdXSU5fXykKKyNpZmRl ZiBfV0lOMzIKICAgICBzZXRtb2RlIChmaWxlbm8gKHN0ZG91dCksIE9fQklO QVJZKTsKICNlbmRpZgogICAgIGZwID0gc3Rkb3V0OwotLS0gb3JpZ3NyYy9o YXJmYnV6ei0xLjcuNi91dGlsL29wdGlvbnMuaGgJMjAxOC0wMi0yNyAxMzo1 MDozNi4wMDAwMDAwMDAgLTA1MDAKKysrIHNyYy9oYXJmYnV6ei0xLjcuNi91 dGlsL29wdGlvbnMuaGgJMjAxOC0wNy0xMiAwOToyMjo1Mi41NjYzOTMyMDAg LTA0MDAKQEAgLTQxLDcgKzQxLDcgQEAKICNpZmRlZiBIQVZFX1VOSVNURF9I CiAjaW5jbHVkZSA8dW5pc3RkLmg+IC8qIGZvciBpc2F0dHkoKSAqLwogI2Vu ZGlmCi0jaWYgZGVmaW5lZChfV0lOMzIpIHx8IGRlZmluZWQoX19DWUdXSU5f XykKKyNpZmRlZiBfV0lOMzIKICNpbmNsdWRlIDxpby5oPiAvKiBmb3Igc2V0 bW9kZSgpIHVuZGVyIFdpbmRvd3MgKi8KICNlbmRpZgogCg== --------------91B05CD25D5D428C8A67D31B--