public inbox for cygwin-apps@cygwin.com
 help / color / mirror / Atom feed
From: David Allsopp <David.Allsopp@cl.cam.ac.uk>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: RE: [PATCH setup] Handle '--packages package=version'
Date: Tue, 20 Apr 2021 14:35:24 +0000	[thread overview]
Message-ID: <2224401c94a04a7d93e53669af4ed30f@metastack.com> (raw)
In-Reply-To: <20210418133444.1287-1-jon.turney@dronecode.org.uk>

Jon Turney wrote:
> Handle '--packages package=version' to allow specifing the version of a
> package to install on the command line.
> 
> isManuallyWanted() now returns the target packageversion (if specified),
> or an empty packageversion (which is translated into an instruction to
> the solver to choose the version).
> 
> In the 'upgrade' case, this changes from using the complex logic of
> packagemeta::trustp() to determine the target version, when unspecified
> on the command line, to allowing the solver to make that decision (which
> should be broadly the same i.e. not downgrading test versions, etc.).
> 
> This also subtly changes the behaviour when the package version is not
> specified.  Instead of forcing the current version, we allow the solver
> to choose the version, so it may not pick that version, if other
> constraints exist, which prevent a solution containing that version.
> 
> There's probably some future work which can be done to simplify the
> remaining uses packagemeta::trustp(), which are only related to the UI.

<snip>

This is really useful (tested locally for a couple of use-cases: one wanting
a downgrade from latest and the other to manually specify a test version).

Does libsolv give the ability to put more complex constraints? In opam, for
example, I can issue `opam install 'utop<2.7.0' and get the last version
before 2.7.0.

`--packages mingw64-x86_64-binutils=2.35.2-1` is already very useful but
`--packages mingw64-x86_64-binutils<2.36` is even more so.



David

  reply	other threads:[~2021-04-20 14:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18 13:34 Jon Turney
2021-04-20 14:35 ` David Allsopp [this message]
2021-04-20 20:30   ` Jon Turney
2021-04-20 18:24 ` ASSI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2224401c94a04a7d93e53669af4ed30f@metastack.com \
    --to=david.allsopp@cl.cam.ac.uk \
    --cc=cygwin-apps@cygwin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).