From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53864 invoked by alias); 30 Oct 2017 16:32:18 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 53852 invoked by uid 89); 30 Oct 2017 16:32:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=homemade, Cancel, risk, HContent-Transfer-Encoding:8bit X-HELO: limerock04.mail.cornell.edu Received: from limerock04.mail.cornell.edu (HELO limerock04.mail.cornell.edu) (128.84.13.244) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Oct 2017 16:32:17 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v9UGWEN5021807 for ; Mon, 30 Oct 2017 12:32:15 -0400 Received: from [172.16.255.77] (74-5-253-222.wan.centurylinkservices.net [74.5.253.222] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v9UGWDWt007124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Mon, 30 Oct 2017 12:32:14 -0400 Subject: Re: [[PATCH setup topic/libsolv] 1/2] packagedb::removeEmptyCategories: Don't remove "Base" To: cygwin-apps@cygwin.com References: <20171028122932.3024-1-kbrown@cornell.edu> <7df16382-7175-9b1a-d360-0edb1ed955c2@cornell.edu> <8b27fc05-4468-71a4-5db1-63c07224c57b@dronecode.org.uk> From: Ken Brown Message-ID: <226bae76-95f8-f32a-2b51-4367541a5943@cornell.edu> Date: Mon, 30 Oct 2017 16:32:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <8b27fc05-4468-71a4-5db1-63c07224c57b@dronecode.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-PMX-Cornell-Gauge: Gauge=X X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00169.txt.bz2 On 10/30/2017 11:59 AM, Jon Turney wrote: > This is all a bit broken though.  Because we've forgotten the categories > of installed packages, if we're run without a setup.ini, we'll merrily > let packages in the base category get uninstalled without complaint... Maybe we need to add something to the existing warning. It currently says, "You can still use setup-.exe to remove installed packages, but there will be nothing to install. Press OK if that's what you wanted or Cancel to choose a different directory." We could add that they risk uninstalling required packages if they proceed. Of course, the same thing applies even if one or more setup.ini files are found but don't include the base packages or the dependencies of installed packages. In this case, however, it means that the user has a homemade setup.ini, so we probably have to assume that they know what they're doing. Ken