From: Jon Turney <jon.turney@dronecode.org.uk>
To: "cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: Zstandard support for setup
Date: Wed, 29 Aug 2018 16:42:00 -0000 [thread overview]
Message-ID: <267037c7-7757-25ec-4b80-7ffcbc5768d6@dronecode.org.uk> (raw)
In-Reply-To: <874lg0d6l8.fsf@Rainer.invalid>
On 11/08/2018 20:52, Achim Gratz wrote:
[...]
>
> The current code is available here:
>
> http://repo.or.cz/w/cygwin-setup/local.git
Some comments:
This should check for ztd in configure.ac using PKG_CHECK_MODULES,
rather than just assuming -lzstd is going to work.
The setup executables are cross-built on Fedora, so a
mingw{32,64}-zstd-static package will need to become available.
compress_zstd.c:
+ using namespace std;
Please don't
compress_zstd.h:
+/* this is the parent class for all compress IO operations.
+ */
Comment is incorrect
I'd suggest removing all the 'virtual' since this class is final, but
since all the compress subclasses have it, don't bother.
> The debug output statements are still in the code (although commented),
> I'll let that sit a while and see if I find something else I want to
> clean up before I submit it for the upstream repo.
I'd suggest keeping potentially useful ones under #ifdef DEBUG/#endif
rather than just removing them all.
next prev parent reply other threads:[~2018-08-29 16:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 19:52 Achim Gratz
2018-08-12 13:28 ` Achim Gratz
2018-08-17 18:49 ` Achim Gratz
2018-08-20 18:11 ` Marco Atzeri
2018-08-20 19:54 ` Achim Gratz
2018-08-22 19:12 ` Achim Gratz
2018-08-23 20:40 ` Achim Gratz
2018-08-29 16:42 ` Jon Turney [this message]
2018-09-02 8:31 ` Achim Gratz
2018-09-02 17:03 ` Achim Gratz
2018-10-07 19:46 ` Jon Turney
2018-10-09 18:04 ` Achim Gratz
2018-10-07 22:09 ` Jon Turney
2018-10-09 18:05 ` Achim Gratz
2018-10-10 18:37 ` Achim Gratz
2018-10-13 17:19 ` Jon Turney
2018-10-14 11:29 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=267037c7-7757-25ec-4b80-7ffcbc5768d6@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).