From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-044.btinternet.com (mailomta31-sa.btinternet.com [213.120.69.37]) by sourceware.org (Postfix) with ESMTPS id 63AB83858C56 for ; Sun, 10 Apr 2022 18:45:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 63AB83858C56 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-002.btmx-prd.synchronoss.net ([10.2.38.5]) by sa-prd-fep-044.btinternet.com with ESMTP id <20220410184521.IUHO24689.sa-prd-fep-044.btinternet.com@sa-prd-rgout-002.btmx-prd.synchronoss.net>; Sun, 10 Apr 2022 19:45:21 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 6139417C1E88B1C9 X-Originating-IP: [86.139.167.41] X-OWM-Source-IP: 86.139.167.41 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvvddrudekgedguddviecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeffkeeigfdujeehteduiefgjeeltdelgeelteekudetfedtffefhfeufefgueettdenucfkphepkeeirddufeelrdduieejrdegudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddthegnpdhinhgvthepkeeirddufeelrdduieejrdeguddpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepufhtrhhomhgvkhhosehnvgigghhordguvgdprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomh X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.105] (86.139.167.41) by sa-prd-rgout-002.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 6139417C1E88B1C9; Sun, 10 Apr 2022 19:45:21 +0100 Message-ID: <269eb1ed-452c-5aa5-eb33-8b8ded108a1c@dronecode.org.uk> Date: Sun, 10 Apr 2022 19:44:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: cygport Content-Language: en-GB To: "cygwin-apps@cygwin.com" , Achim Gratz References: <87tueb8nry.fsf@Rainer.invalid> <331936f2-c001-d556-1dd8-00ba2cbc0517@dronecode.org.uk> <87ee2nttqt.fsf@Rainer.invalid> From: Jon Turney In-Reply-To: <87ee2nttqt.fsf@Rainer.invalid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1195.5 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Apr 2022 18:45:25 -0000 On 27/03/2022 14:22, Achim Gratz wrote: > Jon Turney writes: >> A few comments after looking at: >> >> lib/pkg_info.cygport: implement automatic determination of the >> appropriate perl5_0xy requirement >> 1. In __list_deps(), this should look at the files list in $@, not at >> files in $D, as that causes it to identify a perl5_0xy dependency for >> all subpackages, irrespective of which package (if any) contains the >> files in the vendor_perl directory. >> >> 2. This only identifies the perl5_0xy requirement for packages which >> own files in the vendor_perl directory, not for packages which contain >> executables or shared libraries dynamically linked with >> cygperl5_xy.dll. That should at least be mentioned in the patch >> commentary. > > I've fixed both of these on the to-upstream branch I think. Thanks. I tried testing this on rxvt-unicode. It correctly adds the perl5_032 dependency due to linkage But it also emits a bogus dependency on 'Carp'. > @@ -412,6 +413,7 @@ __list_deps() { > do > if [ -f ${d}/${pldep//:://}.pm ] > then > + case "${d##*/}" in 5.[0-9][0-9]) plver+="$pldep " ;; esac Is the mistake thinking pldep here is a pathname, not a module name? > alldeps+=" "${d}/${pldep//:://}.pm; > break; > fi > @@ -419,6 +421,17 @@ __list_deps() { > done > fi > > + plver=( $( echo "${plver}" | tr ' ' '\n' | sed -e 's/.*\///;s/5/perl5/;s/\./_0/' | sort -ru ) ) > + if [ "${#plver[@]}" -gt 1 ] > + then > + warning "More than one targeted Perl version: ${plver[*]}," > + warning "using only the latest as dependency: ${plver[0]}." > + fi > + if [ "${#plver[@]}" -gt 0 ] && [ "${PN}" != "perl_base" ] > + then > + echo "${plver[0]}" > + fi > + > if check_prog php-config > then > phpmoddir=$(php-config --extension-dir)