From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-eopbgr750108.outbound.protection.outlook.com [40.107.75.108]) by sourceware.org (Postfix) with ESMTPS id C12CD3857C5C for ; Fri, 14 Aug 2020 19:36:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C12CD3857C5C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f5pMYeiJCyLz1/7mRFS2ttqeVvHyl8bsGG4+TZKTQ/z8hLxHuiTEjvX2eQ/38UvLHh3bRm7r3iU4tSPprGOF0Bc1V2S2FwNcoFDBXnxN4swTmkHdBjrK26bw8McXML9SRDBsKLB5giY3D3Ij67rdky8h84F0HcS12gqrqpp0HdUiP4j8xa+1HRhnVFc8ZSaessQEWvs+FpqZuifdHPrftXyRtlHwTCJLehd4dxQRWV7ybW4LQB6HX2UtGCCZoEB6VK4nUhDyLEzD35JWH+N/LKmJ1pkC9BZ9XEjQFykUcIBRd6Sb6xppqrS3n4X1UFBMQil/NuiztQdxIcIXCGivog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QcYvS/ad1FV+VjfQKbOwtmZdKnnq52tUkT7HDlJ0RFQ=; b=R+fIU8EAWxP/V10V4eQUvQp1fOWUPigJGXeKsuaDnEXzSdWy3BCmVu4JymdgDHvs5tMI2weBlQHVgHD+fLAb0dZodDuI+Uii6O7C9EDoEZNtOWhHC06K+guXBZFEnWAHN4BkRi996ixJxR3xehTRJt5xx1dWYN0uxO5PD2BQ1RNNJSHvf8IjwsBao2tT1Cbd9zo/kcTIDKWxzbdpkcufKH4+GKykFHbIAldI/zobJkqOnIOnwyO9AWEYfl1IGSLerf8nGvbkpuD/yui+B1kHKtezodAFDLWacyEY6HKGYWk9gjecNwFLnK5hZhkOZQsLuBl6s9Ic9r61XYj2DJDPFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none Received: from MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) by MN2PR04MB5696.namprd04.prod.outlook.com (2603:10b6:208:fd::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.20; Fri, 14 Aug 2020 19:36:09 +0000 Received: from MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::184d:a265:1d48:499a]) by MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::184d:a265:1d48:499a%7]) with mapi id 15.20.3283.020; Fri, 14 Aug 2020 19:36:09 +0000 Subject: Re: [ANNOUNCEMENT] Updated: curl 7.71.1-1 To: cygwin-apps@cygwin.com References: <4f1d6241-c86b-f2f9-7b49-a9f5b998b0eb@SystematicSw.ab.ca> <53c7f2a7-3bd8-f90c-b574-969d6b31f300@cornell.edu> <71031f78-b1be-aec2-4e54-72ff49e07543@SystematicSw.ab.ca> <11d99d00-55fb-f6a2-893d-f5ebb6e7a14b@cornell.edu> <8c14a6d0-7c52-ee29-5026-a306166c2e87@SystematicSw.ab.ca> <09023890-2068-f323-14aa-df7848ddb681@SystematicSw.ab.ca> <87f28e0d-b815-2368-6c6b-335ccfa69f6f@SystematicSw.ab.ca> From: Ken Brown Message-ID: <26ba008f-fcb1-0953-6136-946abb12aa48@cornell.edu> Date: Fri, 14 Aug 2020 15:36:08 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 In-Reply-To: <87f28e0d-b815-2368-6c6b-335ccfa69f6f@SystematicSw.ab.ca> Content-Type: multipart/mixed; boundary="------------42B6A0381E01C06B5F9C24C4" Content-Language: en-US X-ClientProxiedBy: CH2PR05CA0049.namprd05.prod.outlook.com (2603:10b6:610:38::26) To MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2604:6000:b407:7f00:b49a:f5e2:e26b:f6b4] (2604:6000:b407:7f00:b49a:f5e2:e26b:f6b4) by CH2PR05CA0049.namprd05.prod.outlook.com (2603:10b6:610:38::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.16 via Frontend Transport; Fri, 14 Aug 2020 19:36:08 +0000 X-Originating-IP: [2604:6000:b407:7f00:b49a:f5e2:e26b:f6b4] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 220d4077-4665-44e4-6d72-08d840894b01 X-MS-TrafficTypeDiagnostic: MN2PR04MB5696: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pe8FoP4434xdvNR6janZSlFpXD8Dm0S6y7NCLm1HNOE20Bk/T9MkJEyXniZvVeNvNH3oKjgkkg0w/2qRWc2g1mvtzGLIh5dlPrl+u8ZfncV9/+FckTS6GtPe0ZxE/JuScZ++V1aJukQsXaZEy6PpewZrE1puQFzBIyssXPRuumSoDIJNLJwN4WEtHzHvMJpDPYN7alKGRqvUB01p2NI/ospqRQwLJ+st2IXZnTzuEKvFtX1xgW+8Bqdz/fntVQEg7vRk3f8RLgbWyvlK/tdPPxmWWNR7CUgKTXKIwCknI9Ur2sw+1m4QIRiY4Ap2JKzkYs4m3QFVvhnAEGpY/d9QnmWSY0yxkCLH7Q7V4lfgGHwADPJYQBpA3hWQ31PbBWAcmR80bUp4ennFrwj/do7cgAPoGLoKm8LpRA2yZaESbonJoCila1pGG6hRX9Kh7BXq82rGoTtKHT0Dr4oSM4rBug== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR04MB6176.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(136003)(376002)(366004)(396003)(6916009)(52116002)(478600001)(8676002)(966005)(66616009)(66946007)(66556008)(2906002)(316002)(66476007)(8936002)(31696002)(31686004)(786003)(75432002)(33964004)(2616005)(235185007)(5660300002)(36756003)(6486002)(86362001)(83380400001)(53546011)(16526019)(186003)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: RbzbuE3vt+7OPYlma0ZEOi33MWHnYpDJLgeytID1tjpjj4zyl2uK+Qvv/6gIHz1H+gQHEbAvPqyTImDrC4YeLl1v8Ab9eZhlBg1JddL1H1CWI2uQxoi7VHxxjE30MZ2aAi7/tCXUw2kt5+bOHal15PP3xmRKLVEMdX46UVfCSgETcdo6GC+Ct6fOcXPVtUU0tb7ofYC8yYU34vvjQ3itV69Mvu5DEuY7d35gqgpuOhRF+iBlPT8xo6do2SOQooNCromtctOy9NDwey2FC488rS9J8kIhrle7hbAZr87FZNVO+TLp2sLJtOBSHUoPnh9EA6rkjTbBXZdQr+QeVoFaSeb/Pm1+PITQaBUBOmiV12gYmPaOK2SAg0iIOKmvxbckZJU9GYbTOYP7LWMyYJvqs/61IMtQP+zKJWQV6RIMOnJTYEnTZheF1E4lOyn3FgiO7Q9icvnVXSCbNDgmVvWKEbs5Lv9CWeE/pKGfhVRWj6nLPO4M/eOL40+maOmZ+WfOOX4q2exahhIz2iHyUGY2LRCDjbF/N14PxfKeIMwIVNs5AZQiJlMA2BqwwCZONO2oPzAw9MqaQHAM2GW+FPxGU/vqytCmy8djEyMlu9VtslN+K00ms2V+5RaFwuJ/Qv/eONNn63fKL61CEWIksNUR3chsy7G6oSHO6FUznv9iuf+dY6b9d65Fyz61n/HNuvyyXIoIfLnknDtDY6O4PrNF9Q== X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 220d4077-4665-44e4-6d72-08d840894b01 X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6176.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Aug 2020 19:36:09.2993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1QadstgtBraRoraWeyEImYHYD0lk4x6xwa5ly1hCDoXwRFvMvxXAAMEbjW1yF5WUkuuFLNkfs0998Z+sgR7GKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5696 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Aug 2020 19:36:12 -0000 --------------42B6A0381E01C06B5F9C24C4 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 8/14/2020 2:45 PM, Brian Inglis wrote: > On 2020-08-14 12:19, Brian Inglis wrote: >> On 2020-08-11 16:00, Brian Inglis wrote: >>> On 2020-08-11 05:27, Adam Dinwoodie wrote: >>>> On Tue, 11 Aug 2020 at 12:14, Ken Brown via Cygwin wrote: >>>>>> In that case, it looks to me as if the generated curl-config --libs statements: >>>>>> >>>>>> if test "Xyes" = "Xno" -o "Xyes" = "Xyes"; then >>>>>> echo ${CURLLIBDIR}-lcurl -lnghttp2 -lidn2 -lssh -lpsl -lssl -lcrypto >>>>>> -lldap -llber -lbrotlidec -lbrotlidec -lz >>>>>> >>>>>> based on curl-config.in: >>>>>> >>>>>> if test "X@ENABLE_SHARED@" = "Xno" -o "X@REQUIRE_LIB_DEPS@" = "Xyes"; then >>>>>> echo ${CURLLIBDIR}-lcurl @LIBCURL_LIBS@ >>>>>> >>>>>> REQUIRE_LIB_DEPS should be no, derived from configure.ac: >>>>>> >>>>>> if test "X$enable_shared" = "Xyes" -a "X$link_all_deplibs" = "Xno" >>>>>> then >>>>>> REQUIRE_LIB_DEPS=no >>>>>> else >>>>>> REQUIRE_LIB_DEPS=yes >>>>>> fi >>>>>> AC_SUBST(REQUIRE_LIB_DEPS) >>>>>> AM_CONDITIONAL(USE_EXPLICIT_LIB_DEPS, test x$REQUIRE_LIB_DEPS = xyes) >>>>>> >>>>>> but for Cygwin link_all_deplibs remains defaulted to unknown, so either that >>>>>> variable should be set in configure, or that condition should perhaps be changed >>>>>> to: >>>>>> >>>>>> if test "X$enable_shared" = "Xyes" -a "X$link_all_deplibs" != "Xyes" >>>>>> >>>>>> with appropriate bug reports and changes to be made upstream if possible. >>>>> >>>>> If you want to look into ways of fixing curl-config different from what Yaakov >>>>> did, that's fine; you're the maintainer. All I did was look at Yaakov's patch >>>>> and port it to curl 7.71.1, that being a quick and easy way to fix the reported >>>>> problem. >>>> >>>> Someone else did raise this problem upstream at >>>> https://github.com/curl/curl/issues/5793, and the comments there imply >>>> they'd be interested in integrating patches Cygwin uses into the >>>> upstream code, although the upstream maintainers aren't going to do >>>> that without someone proactively submitting the patch to them. >>> >>> I'll copy these comments and suggestions and follow up there, as that appears to >>> be the official bug tracker, and they appear receptive to discussing and fixing >>> issues. >>> >>>> For my part, I'm not particularly fussed whether this is fixed with an >>>> upstream patch or a Cygwin patch; I just want my use cases to work, >>>> and as of 7.71.1-1 they don't. That said, my experience of being a >>>> package maintainer would lead me to want to submit patches upstream if >>>> at all possible, just to reduce the need to handle these sorts of >>>> problems. My inclination would be to restore the patched behaviour >>>> with Ken's new patch as a short-term fix, then get this submitted >>>> upstream so that in the long-term this patch can be retired. >>> >>> I did not see or get your original email, and could not reproduce your issue >>> using the current git source package, curl package, and cygport. >>> That could be due to two missing perl modules (solved in another sub-thread by >>> Achim). >>> Any suggestions as to what may be required to get curl-config to act up in a >>> build would be appreciated. >>> It is always easier to check if a problem is actually fixed when you can perform >>> an in situ regression test. >>> Running curl-config and reading the docs, it does not appear to me to be clearly >>> specified why and when dynamic and static library parameters are either built in >>> or generated, whereas the conditions for reproducing the output are well >>> specified for pkgconf/pkg-config. >>> That may become more apparent in follow ups on the bug tracker. >> >> [Followed up on Github curl bug tracker and may have patch, but subsequent >> problems building tests, which KB may know something about, so moving to >> cygwin-apps] > > Test build failures - tried adding to cygport: > > src_test() { > cd ${B} > cygtest LDFLAGS="${LDFLAGS} -no-undefined" > } > > but no change: > > Making all in libtest > make[2]: Entering directory > '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests/libtest' > CCLD libstubgss.la > libtool: error: can't build x86_64-pc-cygwin shared library unless > -no-undefined is specified > make[2]: *** [Makefile:2547: libstubgss.la] Error 1 > make[2]: Target 'all' not remade because of errors. > make[2]: Leaving directory > '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests/libtest' > Making all in unit > make[2]: Entering directory > '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests/unit' > make[2]: Nothing to be done for 'all'. > make[2]: Leaving directory > '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests/unit' > make[2]: Entering directory > '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests' > make[2]: Nothing to be done for 'all-am'. > make[2]: Leaving directory > '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests' > make[1]: *** [Makefile:513: all-recursive] Error 1 > make[1]: Target 'all' not remade because of errors. > make[1]: Target 'quiet-test' not remade because of errors. > make[1]: Leaving directory > '/home/$USER/src/cygwin/curl/curl-7.71.1-2.x86_64/build/tests' > make: *** [Makefile:1437: test] Error 2 The attached patch should fix it. I didn't take the trouble to write the patch in a way that's suitable for sending upstream. If you want to do that, you could imitate what's done for libhostname.la a little earlier in the same Makefile.am. But I recommend that you first get curl 7.71.1-2 released before spending time polishing the patch. Ken --------------42B6A0381E01C06B5F9C24C4 Content-Type: text/plain; charset=UTF-8; name="7.71.1-no_undefined.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="7.71.1-no_undefined.patch" --- origsrc/curl-7.71.1/tests/libtest/Makefile.am 2020-06-27 18:03:53.000000000 -0400 +++ src/curl-7.71.1/tests/libtest/Makefile.am 2020-08-14 14:33:04.434364600 -0400 @@ -118,7 +118,7 @@ if BUILD_STUB_GSS noinst_LTLIBRARIES += libstubgss.la libstubgss_la_CPPFLAGS = $(AM_CPPFLAGS) -libstubgss_la_LDFLAGS = $(AM_LDFLAGS) -avoid-version -rpath /nowhere +libstubgss_la_LDFLAGS = $(AM_LDFLAGS) -avoid-version -rpath /nowhere -no-undefined libstubgss_la_CFLAGS = $(AM_CFLAGS) -g libstubgss_la_SOURCES = stub_gssapi.c stub_gssapi.h --------------42B6A0381E01C06B5F9C24C4--