From: Eric Blake <eblake@redhat.com>
To: cygwin-apps@cygwin.com
Subject: Re: [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's
Date: Wed, 07 Feb 2018 15:38:00 -0000 [thread overview]
Message-ID: <29e2c298-107a-eb7e-31a9-0b937a7d95db@redhat.com> (raw)
In-Reply-To: <af20a08b-f826-d2ff-fe93-cf6a72677aa5@maxrnd.com>
On 02/07/2018 01:29 AM, Mark Geisert wrote:
> I don't have libtirpc in git so I'm submitting a text patch. Sorry for
> any inconvenience. This is Cygwin-specific and against
> src/bindresvport.c of libtirpc 1.0.1. Unsure if it ought to go
> upstream; appreciate input on that.
> Thanks much,
>
> ..mark
>
> --------8<--------
> 35a36,38
> > /* On Cygwin prefer Cygwin's bindresvport{,_sa}() to portable version
> here */
An ed-script diff is practically useless; without context, it is too
easy to misapply the patch if the file has been edited differently in
the meantime. ALWAYS use 'diff -u' (what git does by default) or 'diff
-c' when generating a patch, so that it has proper context.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-02-07 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <59D90AF8D70E9740907BACDE2BCB520836E4AA63@RESW102.resdom01.local>
[not found] ` <20180206142012.GB30794@calimero.vinschen.de>
[not found] ` <80645451-e2d6-56bf-87c4-c02ac801f201@maxrnd.com>
2018-02-07 7:29 ` Mark Geisert
2018-02-07 15:38 ` Eric Blake [this message]
2018-02-07 18:51 ` Brian Inglis
2018-02-07 21:03 ` Mark Geisert
2018-02-07 19:08 ` Yaakov Selkowitz
2018-02-07 21:04 ` Mark Geisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29e2c298-107a-eb7e-31a9-0b937a7d95db@redhat.com \
--to=eblake@redhat.com \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).