From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76427 invoked by alias); 7 Feb 2018 15:38:50 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 76410 invoked by uid 89); 7 Feb 2018 15:38:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=BAYES_00,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW,SPF_HELO_FAIL,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=ALWAYS, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Feb 2018 15:38:48 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 14150E44B5 for ; Wed, 7 Feb 2018 15:38:47 +0000 (UTC) Received: from [10.10.122.122] (ovpn-122-122.rdu2.redhat.com [10.10.122.122]) by smtp.corp.redhat.com (Postfix) with ESMTP id E013FD19CC for ; Wed, 7 Feb 2018 15:38:46 +0000 (UTC) Subject: Re: [PATCH libtirpc] Disable libtirpc's own bindresvport{,_sa}() in favor of Cygwin's To: cygwin-apps@cygwin.com References: <59D90AF8D70E9740907BACDE2BCB520836E4AA63@RESW102.resdom01.local> <20180206142012.GB30794@calimero.vinschen.de> <80645451-e2d6-56bf-87c4-c02ac801f201@maxrnd.com> From: Eric Blake Message-ID: <29e2c298-107a-eb7e-31a9-0b937a7d95db@redhat.com> Date: Wed, 07 Feb 2018 15:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00011.txt.bz2 On 02/07/2018 01:29 AM, Mark Geisert wrote: > I don't have libtirpc in git so I'm submitting a text patch.  Sorry for > any inconvenience.  This is Cygwin-specific and against > src/bindresvport.c of libtirpc 1.0.1.  Unsure if it ought to go > upstream; appreciate input on that. > Thanks much, > > ..mark > > --------8<-------- > 35a36,38 > > /* On Cygwin prefer Cygwin's bindresvport{,_sa}() to portable version > here */ An ed-script diff is practically useless; without context, it is too easy to misapply the patch if the file has been edited differently in the meantime. ALWAYS use 'diff -u' (what git does by default) or 'diff -c' when generating a patch, so that it has proper context. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org