From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31454 invoked by alias); 27 Nov 2017 22:20:02 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 31438 invoked by uid 89); 27 Nov 2017 22:20:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:520 X-HELO: limerock01.mail.cornell.edu Received: from limerock01.mail.cornell.edu (HELO limerock01.mail.cornell.edu) (128.84.13.241) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Nov 2017 22:20:01 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id vARMJwMQ006174 for ; Mon, 27 Nov 2017 17:19:58 -0500 Received: from [10.128.172.94] (dhcp-gs-11358.eduroam.cornell.edu [10.128.172.94]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id vARMJvT1015085 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Mon, 27 Nov 2017 17:19:58 -0500 Subject: Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting To: cygwin-apps@cygwin.com References: <20171127213547.10816-1-kbrown@cornell.edu> From: Ken Brown Message-ID: <2a2f84b2-98e0-ddf5-a443-405adcb0e4b1@cornell.edu> Date: Mon, 27 Nov 2017 22:20:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171127213547.10816-1-kbrown@cornell.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=X X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00115.txt.bz2 On 11/27/2017 4:35 PM, Ken Brown wrote: > The ExtraKeysSetting destructor called UserSettings::set() on a string > that was terminated by LF instead of NUL. This led to garbage at the > end of the "extrakeys" setting that was written into setup.rc. Fix > this by replacing the final LF by NUL before calling set(). Disregard this for now. I've just discovered some further issues involving "extrakeys", and I'd like to fix them all at once. Ken