From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113606 invoked by alias); 27 Mar 2018 19:05:03 -0000 Mailing-List: contact cygwin-apps-help@cygwin.com; run by ezmlm Precedence: bulk Sender: cygwin-apps-owner@cygwin.com List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Mail-Followup-To: cygwin-apps@cygwin.com Received: (qmail 113580 invoked by uid 89); 27 Mar 2018 19:05:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=brown, ken X-HELO: limerock01.mail.cornell.edu Received: from limerock01.mail.cornell.edu (HELO limerock01.mail.cornell.edu) (128.84.13.241) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Mar 2018 19:05:01 +0000 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w2RJ4xVd008033 for ; Tue, 27 Mar 2018 15:04:59 -0400 Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w2RJ4voo010584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Tue, 27 Mar 2018 15:04:58 -0400 Subject: Re: setup: uninstalling an orphaned package To: cygwin-apps@cygwin.com References: From: Ken Brown Message-ID: <2c565a8f-8504-6a66-a94d-3b39ca3b8968@cornell.edu> Date: Tue, 27 Mar 2018 19:05:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------96037007D82E50348DB73EE2" X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00051.txt.bz2 This is a multi-part message in MIME format. --------------96037007D82E50348DB73EE2 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-length: 1460 On 3/26/2018 1:55 PM, Ken Brown wrote: > In ChooserPage::applyCommandLinePackageSelection() we have the following > code: > >       bool wanted    = pkg.isManuallyWanted(); >       bool deleted   = pkg.isManuallyDeleted(); >       bool basemisc  = (pkg.categories.find ("Base") != > pkg.categories.end () >              || pkg.categories.find ("Orphaned") != pkg.categories.end > ()); > [...] >       bool reinstall = (wanted  || basemisc) && deleted; > > One strange consequence of this is that if the user tries to uninstall > an orphaned package on the command line, then setup will instead try to > reinstall it. > > This behavior was introduced in the following commit: > > commit a667a8b289ccb6e70ec6bf4c70cceeca4d3fb5d3 > Author: Corinna Vinschen > Date:   Thu Jul 25 12:03:49 2013 +0000 > > [...] > Uninstalled packages in categories "Base" or "Misc" are always selected > for installation; installed packages in these categories are not > eligible for deletion and will be reinstalled or upgraded instead. > [...] > > I can't understand the rationale for this.  Did "Misc" (which has since > been renamed to "Orphaned") used to have a different meaning? > > I found it very surprising when I tried to uninstall a bunch of packages > in unattended mode, and setup failed with download errors because it > tried to reinstall orphaned packages. Patch attached. Ken --------------96037007D82E50348DB73EE2 Content-Type: text/plain; charset=UTF-8; name="0001-Allow-command-line-uninstallation-of-specific-orphan.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Allow-command-line-uninstallation-of-specific-orphan.pa"; filename*1="tch" Content-length: 2367 RnJvbSAzYTc4NDUzZmQ4YTNiNWQ5NzM0YTExYjgzOWYxM2U2OGM4NGQxYzA1 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gQnJvd24gPGti cm93bkBjb3JuZWxsLmVkdT4KRGF0ZTogVHVlLCAyNyBNYXIgMjAxOCAxMzo1 NjoyNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggc2V0dXBdIEFsbG93IGNvbW1h bmQtbGluZSB1bmluc3RhbGxhdGlvbiBvZiBzcGVjaWZpYyBvcnBoYW5lZAog cGFja2FnZXMKCkFsc28gY2hhbmdlIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiB0 aGUgIi0tZGVsZXRlLW9ycGhhbnMiIG9wdGlvbiB0byB1c2UKdGhlIHNhbWUg ZGVmaW5pdGlvbiBvZiAib3JwaGFuZWQiIHRoYXQncyB1c2VkIGVsc2V3aGVy ZSBpbiB0aGUgY29kZS4KLS0tCiBjaG9vc2UuY2MgfCAxMiArKysrKystLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDYgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvY2hvb3NlLmNjIGIvY2hvb3NlLmNjCmlu ZGV4IDVhNGQzYWQuLjEyNDllZmEgMTAwNjQ0Ci0tLSBhL2Nob29zZS5jYwor KysgYi9jaG9vc2UuY2MKQEAgLTI5NSwxMyArMjk1LDEzIEBAIENob29zZXJQ YWdlOjphcHBseUNvbW1hbmRMaW5lUGFja2FnZVNlbGVjdGlvbigpCiAgICAg ICBwYWNrYWdlbWV0YSAmcGtnID0gKihpLT5zZWNvbmQpOwogICAgICAgYm9v bCB3YW50ZWQgICAgPSBwa2cuaXNNYW51YWxseVdhbnRlZCgpOwogICAgICAg Ym9vbCBkZWxldGVkICAgPSBwa2cuaXNNYW51YWxseURlbGV0ZWQoKTsKLSAg ICAgIGJvb2wgYmFzZW1pc2MgID0gKHBrZy5jYXRlZ29yaWVzLmZpbmQgKCJC YXNlIikgIT0gcGtnLmNhdGVnb3JpZXMuZW5kICgpCi0JCSAgICAgfHwgcGtn LmNhdGVnb3JpZXMuZmluZCAoIk9ycGhhbmVkIikgIT0gcGtnLmNhdGVnb3Jp ZXMuZW5kICgpKTsKLSAgICAgIGJvb2wgdXBncmFkZSAgID0gd2FudGVkIHx8 ICghcGtnLmluc3RhbGxlZCAmJiBiYXNlbWlzYyk7CisgICAgICBib29sIGJh c2UgICAgICA9IHBrZy5jYXRlZ29yaWVzLmZpbmQgKCJCYXNlIikgIT0gcGtn LmNhdGVnb3JpZXMuZW5kICgpOworICAgICAgYm9vbCBvcnBoYW5lZCAgPSBw a2cuY2F0ZWdvcmllcy5maW5kICgiT3JwaGFuZWQiKSAhPSBwa2cuY2F0ZWdv cmllcy5lbmQgKCk7CisgICAgICBib29sIHVwZ3JhZGUgICA9IHdhbnRlZCB8 fCAoIXBrZy5pbnN0YWxsZWQgJiYgYmFzZSk7CiAgICAgICBib29sIGluc3Rh bGwgICA9IHdhbnRlZCAgJiYgIWRlbGV0ZWQgJiYgIXBrZy5pbnN0YWxsZWQ7 Ci0gICAgICBib29sIHJlaW5zdGFsbCA9ICh3YW50ZWQgIHx8IGJhc2VtaXNj KSAmJiBkZWxldGVkOwotICAgICAgYm9vbCB1bmluc3RhbGwgPSAoISh3YW50 ZWQgIHx8IGJhc2VtaXNjKSAmJiAoZGVsZXRlZCB8fCBQcnVuZUluc3RhbGxP cHRpb24pKQotCQkgICAgIHx8ICghcGtnLmN1cnIgJiYgQ2xlYW5PcnBoYW5z T3B0aW9uKTsKKyAgICAgIGJvb2wgcmVpbnN0YWxsID0gKHdhbnRlZCAgfHwg YmFzZSkgJiYgZGVsZXRlZDsKKyAgICAgIGJvb2wgdW5pbnN0YWxsID0gKCEo d2FudGVkICB8fCBiYXNlKSAmJiAoZGVsZXRlZCB8fCBQcnVuZUluc3RhbGxP cHRpb24pKQorCQkgICAgIHx8IChvcnBoYW5lZCAmJiBDbGVhbk9ycGhhbnNP cHRpb24pOwogICAgICAgaWYgKGluc3RhbGwpCiAJcGtnLnNldF9hY3Rpb24g KHBhY2thZ2VtZXRhOjpJbnN0YWxsX2FjdGlvbiwgcGtnLmN1cnIpOwogICAg ICAgZWxzZSBpZiAocmVpbnN0YWxsKQotLSAKMi4xNi4yCgo= --------------96037007D82E50348DB73EE2--