From: Jon Turney <jon.turney@dronecode.org.uk>
To: Achim Gratz <Stromeko@nexgo.de>,
"cygwin-apps@cygwin.com" <cygwin-apps@cygwin.com>
Subject: Re: cygport
Date: Mon, 14 Mar 2022 19:06:08 +0000 [thread overview]
Message-ID: <331936f2-c001-d556-1dd8-00ba2cbc0517@dronecode.org.uk> (raw)
In-Reply-To: <87tueb8nry.fsf@Rainer.invalid>
On 10/01/2022 18:10, Achim Gratz wrote:
>
> I've rebased the remaining patches on my to-upstream branch onto the
> current release of cygport:
>
> https://repo.or.cz/cygport/rpm-style.git/shortlog/refs/heads/to-upstream
>
> Note that some of these are required to correctly build and distribute
> Perl and its modules for Cygwin (which is one reason I carry these for
> several years now).
A few comments after looking at:
lib/pkg_info.cygport: implement automatic determination of the
appropriate perl5_0xy requirement
1. In __list_deps(), this should look at the files list in $@, not at
files in $D, as that causes it to identify a perl5_0xy dependency for
all subpackages, irrespective of which package (if any) contains the
files in the vendor_perl directory.
2. This only identifies the perl5_0xy requirement for packages which own
files in the vendor_perl directory, not for packages which contain
executables or shared libraries dynamically linked with cygperl5_xy.dll.
That should at least be mentioned in the patch commentary.
next prev parent reply other threads:[~2022-03-14 19:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 18:10 cygport Achim Gratz
2022-03-14 19:06 ` Jon Turney [this message]
2022-03-14 20:12 ` cygport Achim Gratz
2022-03-14 20:50 ` cygport Jon Turney
2022-03-27 13:22 ` cygport Achim Gratz
2022-04-10 18:44 ` cygport Jon Turney
2022-04-10 18:57 ` cygport Achim Gratz
2022-09-15 17:45 ` cygport Jon Turney
2022-09-15 19:34 ` cygport Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=331936f2-c001-d556-1dd8-00ba2cbc0517@dronecode.org.uk \
--to=jon.turney@dronecode.org.uk \
--cc=Stromeko@nexgo.de \
--cc=cygwin-apps@cygwin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).