From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-043.btinternet.com (mailomta19-sa.btinternet.com [213.120.69.25]) by sourceware.org (Postfix) with ESMTPS id AC0EA3858D20 for ; Mon, 14 Mar 2022 19:06:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC0EA3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=dronecode.org.uk Received: from sa-prd-rgout-004.btmx-prd.synchronoss.net ([10.2.38.7]) by sa-prd-fep-043.btinternet.com with ESMTP id <20220314190619.JOKE18908.sa-prd-fep-043.btinternet.com@sa-prd-rgout-004.btmx-prd.synchronoss.net>; Mon, 14 Mar 2022 19:06:19 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com; bimi=skipped X-SNCR-Rigid: 613943C619D515BC X-Originating-IP: [86.139.156.65] X-OWM-Source-IP: 86.139.156.65 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedvvddruddvkedguddulecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedtudenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucggtffrrghtthgvrhhnpeeugffhvdeffeduvefffeeuvdeffeejvdfghefghfejveefheehvdehuedvueeihfenucffohhmrghinhepohhrrdgtiienucfkphepkeeirddufeelrdduheeirdeiheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhephhgvlhhopegludelvddrudeikedruddruddtfegnpdhinhgvthepkeeirddufeelrdduheeirdeihedpmhgrihhlfhhrohhmpehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkpdhnsggprhgtphhtthhopedvpdhrtghpthhtohepufhtrhhomhgvkhhosehnvgigghhordguvgdprhgtphhtthhopegthihgfihinhdqrghpphhssegthihgfihinhdrtghomh X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.103] (86.139.156.65) by sa-prd-rgout-004.btmx-prd.synchronoss.net (5.8.716.04) (authenticated as jonturney@btinternet.com) id 613943C619D515BC; Mon, 14 Mar 2022 19:06:19 +0000 Message-ID: <331936f2-c001-d556-1dd8-00ba2cbc0517@dronecode.org.uk> Date: Mon, 14 Mar 2022 19:06:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: cygport Content-Language: en-GB To: Achim Gratz , "cygwin-apps@cygwin.com" References: <87tueb8nry.fsf@Rainer.invalid> From: Jon Turney In-Reply-To: <87tueb8nry.fsf@Rainer.invalid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3570.8 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: cygwin-apps@cygwin.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Cygwin package maintainer discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Mar 2022 19:06:25 -0000 On 10/01/2022 18:10, Achim Gratz wrote: > > I've rebased the remaining patches on my to-upstream branch onto the > current release of cygport: > > https://repo.or.cz/cygport/rpm-style.git/shortlog/refs/heads/to-upstream > > Note that some of these are required to correctly build and distribute > Perl and its modules for Cygwin (which is one reason I carry these for > several years now). A few comments after looking at: lib/pkg_info.cygport: implement automatic determination of the appropriate perl5_0xy requirement 1. In __list_deps(), this should look at the files list in $@, not at files in $D, as that causes it to identify a perl5_0xy dependency for all subpackages, irrespective of which package (if any) contains the files in the vendor_perl directory. 2. This only identifies the perl5_0xy requirement for packages which own files in the vendor_perl directory, not for packages which contain executables or shared libraries dynamically linked with cygperl5_xy.dll. That should at least be mentioned in the patch commentary.